[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237188#comment-16237188
]
liyunzhang commented on HIVE-17973:
---
[~lirui], [~xuefuz]: can you help review? thanks!
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
> Attachments: HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q, It is
> strange to drop src_multi1 twice and maybe want to drop src_multi2.
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237212#comment-16237212
]
Rui Li commented on HIVE-17973:
---
+1 pending test
Seems src1 is created in {{q_test_init.sql}}.
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
> Attachments: HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238774#comment-16238774
]
Hive QA commented on HIVE-17973:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12895579/HIVE-17973.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11354 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_dynamicserde]
(batchId=85)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[multi_insert_union_src]
(batchId=58)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing
(batchId=281)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7625/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7625/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7625/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 20 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12895579 - PreCommit-HIVE-Build
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
> Attachments: HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239927#comment-16239927
]
Hive QA commented on HIVE-17973:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12896143/HIVE-17973.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 11357 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1]
(batchId=146)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool
(batchId=281)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing
(batchId=281)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7656/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7656/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7656/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 19 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12896143 - PreCommit-HIVE-Build
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241674#comment-16241674
]
liyunzhang commented on HIVE-17973:
---
very confused why the fix will cause other unit test failures. trigger another
round of test.
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241681#comment-16241681
]
Rui Li commented on HIVE-17973:
---
[~kellyzly], the failures may not be related. Have you tried them locally?
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242241#comment-16242241
]
Hive QA commented on HIVE-17973:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12896360/HIVE-17973.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 11362 tests
executed
*Failed tests:*
{noformat}
TestServiceDiscoveryWithMiniHS2 - did not produce a TEST-*.xml file (likely
timed out) (batchId=234)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[tez_union_with_udf]
(batchId=102)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vectorization_div0]
(batchId=102)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14]
(batchId=243)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23]
(batchId=243)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7683/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7683/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7683/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12896360 - PreCommit-HIVE-Build
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243494#comment-16243494
]
liyunzhang commented on HIVE-17973:
---
less unit test failures in 3rd,but see following unit test failures occurred
both in 2nd and 3rd round of test
{code}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{code}
running them in my local env. some indeed failed as Hive-QA. So update new
patch.
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243500#comment-16243500
]
liyunzhang commented on HIVE-17973:
---
for sysdb.q.out, the modification is like following, {{CREATE TABLE IF NOT
EXISTS `WM_TRIGGERS`}} should exist in sysdb.q.out because
{{hive-schema-3.0.0.hive.sql}} is sourced in
[sysdb.q|https://github.com/apache/hive/blob/master/ql/src/test/queries/clientpositive/sysdb.q#L27]
and [hive-schema-3.0.0.hive.sql|
https://github.com/apache/hive/blob/master/metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql#L967]
create table {{WM_TRIGGERS}} . Very confused why before HiveQA did not throw
error.
{code}
--- a/ql/src/test/results/clientpositive/llap/sysdb.q.out
+++ b/ql/src/test/results/clientpositive/llap/sysdb.q.out
@@ -2225,6 +2225,56 @@ FROM
POSTHOOK: type: CREATETABLE
POSTHOOK: Output: SYS@WM_RESOURCEPLANS
POSTHOOK: Output: database:sys
+PREHOOK: query: CREATE TABLE IF NOT EXISTS `WM_TRIGGERS` (
+ `RP_NAME` string,
+ `NAME` string,
+ `TRIGGER_EXPRESSION` string,
+ `ACTION_EXPRESSION` string
+)
+STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler'
+TBLPROPERTIES (
+"hive.sql.database.type" = "METASTORE",
+"hive.sql.query" =
+"SELECT
+ r.NAME RP_NAME,
+ t.NAME NAME,
+ TRIGGER_EXPRESSION,
+ ACTION_EXPRESSION
+FROM
+ WM_TRIGGER t
+JOIN
+ WM_RESOURCEPLAN r
+ON
{code}
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243582#comment-16243582
]
liyunzhang commented on HIVE-17973:
---
for {{ct_noperm_loc.q.out}},
{code}
set hive.test.authz.sstd.hs2.mode=true;
set
hive.security.authorization.manager=org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest;
set
hive.security.authenticator.manager=org.apache.hadoop.hive.ql.security.SessionStateConfigUserAuthenticator;
set hive.security.authorization.enabled=true;
dfs ${system:test.dfs.mkdir} hdfs:///tmp/ct_noperm_loc;
set user.name=user1;
create table foo0(id int) location 'hdfs:///tmp/ct_noperm_loc_foo0';
create table foo1 location 'hdfs:///tmp/ct_noperm_loc/foo1';
{code}
the output in my local env
{code}
A masked pattern was here
PREHOOK: type: CREATETABLE
A masked pattern was here
PREHOOK: Output: database:default
PREHOOK: Output: default@foo0
A masked pattern was here
POSTHOOK: type: CREATETABLE
A masked pattern was here
POSTHOOK: Output: database:default
POSTHOOK: Output: default@foo0
FAILED: SemanticException [Error 10043]: Either list of columns or a custom
serializer should be specified
{code}
the original ct_noperm_loc.q.out is empty. Very confused why there is not any
output for {{ct_noperm_loc.q}}, [~kgyrtkirk], do you know the reason why
[ct_noperm_loc.q.out|https://github.com/apache/hive/blob/master/ql/src/test/results/clientnegative/ct_noperm_loc.q.out]
is empty?
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243612#comment-16243612
]
Zoltan Haindrich commented on HIVE-17973:
-
the goal of the test is to check that hive doesn't let user1 to create a table
with a location under an unowned path.
earlier; it thrown some exception which was not present in the output - because
it contains the hdfs url...so the "masker" filters it out.
this semanticexception is unrelated to that goal; and shouldn't be accepted...
Earlier I've bisected this test to be broken by
5250ef450430fcdeed0a2cb7a770f48647987cd3 (HIVE-12408); but until now, I haven't
checked it thorough - I've just checked it and its true :)
the original exception was (which have been that sole masked line):
FAILED: HiveAccessControlException Permission denied: Principal [name=user1,
type=USER] does not have following privileges for operation CREATETABLE
[[OBJECT OWNERSHIP] on Object [type=DFS_URI,
name=hdfs://localhost:35753/tmp/ct_noperm_loc_foo0]]
I'm still not sure how that commit broke it...
Thanks for pinging me to check it! :)
I'll open a jira with these infos;
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243624#comment-16243624
]
liyunzhang commented on HIVE-17973:
---
[~kgyrtkirk]: {quote}
it thrown some exception which was not present in the output - because it
contains the hdfs url...so the "masker" filters it out.
{quote}
this lets me surprise that "master" will filters the content containing hdfs
url. Can you point out the detail code if have time, thanks!
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243632#comment-16243632
]
Zoltan Haindrich commented on HIVE-17973:
-
sure...
https://github.com/apache/hive/blob/4992beb5e0e904a525daaa6f6f56edd76848fa61/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java#L1615
I don't like it either very much...probably replacing only
[HIVE_ROOT|https://github.com/apache/hive/blob/4992beb5e0e904a525daaa6f6f56edd76848fa61/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java#L501]
to some verbatim string would be better...
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243677#comment-16243677
]
Zoltan Haindrich commented on HIVE-17973:
-
sysdb failure is unrelated...however; its present in #3
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244746#comment-16244746
]
Hive QA commented on HIVE-17973:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12896590/HVIE-17973.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11363 tests
executed
*Failed tests:*
{noformat}
TestJdbcWithDBTokenStoreNoDoAs - did not produce a TEST-*.xml file (likely
timed out) (batchId=244)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1]
(batchId=146)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7713/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7713/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7713/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12896590 - PreCommit-HIVE-Build
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245083#comment-16245083
]
liyunzhang commented on HIVE-17973:
---
the fix for {{ct_noperm_loc.q}} is tracked by HIVE-18012.
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch,
> HIVE-17973.patch, HVIE-17973.3.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245096#comment-16245096
]
liyunzhang commented on HIVE-17973:
---
guess these unit test failures are not related to current jira. see in the
[test|https://builds.apache.org/job/PreCommit-HIVE-Build/7712/#showFailuresLink]
of other jiras, following tests still failed
{code}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{code}
[~lirui]: can you help review
[HIVE-17973.2.patch|https://issues.apache.org/jira/secure/attachment/12896360/HIVE-17973.2.patch]?
thanks!
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245101#comment-16245101
]
Rui Li commented on HIVE-17973:
---
+1 to the 2nd patch
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17973) Fix small bug in multi_insert_union_src.q
[
https://issues.apache.org/jira/browse/HIVE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245189#comment-16245189
]
liyunzhang commented on HIVE-17973:
---
thanks [~lirui] and [~kgyrtkirk] review.
> Fix small bug in multi_insert_union_src.q
> -
>
> Key: HIVE-17973
> URL: https://issues.apache.org/jira/browse/HIVE-17973
> Project: Hive
> Issue Type: Bug
>Reporter: liyunzhang
>Assignee: liyunzhang
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HIVE-17973.2.patch, HIVE-17973.2.patch, HIVE-17973.patch
>
>
> in ql\src\test\queries\clientpositive\multi_insert_union_src.q,
> There are two problems in the query file
> 1. It is strange to drop src_multi1 twice
> 2. {{src1}} is not created but used src1(Maybe we create src1 in other qfile)
> {code}
> set hive.mapred.mode=nonstrict;
> drop table if exists src2;
> drop table if exists src_multi1;
> drop table if exists src_multi1;
> set hive.stats.dbclass=fs;
> CREATE TABLE src2 as SELECT * FROM src;
> create table src_multi1 like src;
> create table src_multi2 like src;
> explain
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> from (select * from src1 where key < 10 union all select * from src2 where
> key > 100) s
> insert overwrite table src_multi1 select key, value where key < 150 order by
> key
> insert overwrite table src_multi2 select key, value where key > 400 order by
> value;
> select * from src_multi1;
> select * from src_multi2;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
