[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[
https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295385#comment-16295385
]
Zoltan Haindrich commented on HIVE-18208:
-
I've bisected a few more test failures to this ticket
(ex:{{-Dtest=TestSparkCliDriver#testCliDriver[bucketsortoptimize_insert_7]}}),
and some other spark tests;
possibly they might have been missed in the rebase or had been added in the 5
day timeframe after the test execution.
> SMB Join : Fix the unit tests to run SMB Joins.
> ---
>
> Key: HIVE-18208
> URL: https://issues.apache.org/jira/browse/HIVE-18208
> Project: Hive
> Issue Type: Bug
>Reporter: Deepak Jaiswal
>Assignee: Deepak Jaiswal
> Fix For: 3.0.0
>
> Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch,
> HIVE-18208.3.patch
>
>
> Most of the SMB Join tests are actually not creating SMB Joins. Need them to
> test the intended join.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[
https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295033#comment-16295033
]
Zoltan Haindrich commented on HIVE-18208:
-
I've added an addendum commit to correct {{quotedid_smb.q.out}} which has a new
explain; becase HIVE-13567 have changed the statistics ; the column stats flag
should be complete - which is ok.
> SMB Join : Fix the unit tests to run SMB Joins.
> ---
>
> Key: HIVE-18208
> URL: https://issues.apache.org/jira/browse/HIVE-18208
> Project: Hive
> Issue Type: Bug
>Reporter: Deepak Jaiswal
>Assignee: Deepak Jaiswal
> Fix For: 3.0.0
>
> Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch,
> HIVE-18208.3.patch
>
>
> Most of the SMB Join tests are actually not creating SMB Joins. Need them to
> test the intended join.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[ https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288024#comment-16288024 ] Jason Dere commented on HIVE-18208: --- It looks like HIVE-13567 has updated a lot of the qfile outputs, can you rebase the patch again? > SMB Join : Fix the unit tests to run SMB Joins. > --- > > Key: HIVE-18208 > URL: https://issues.apache.org/jira/browse/HIVE-18208 > Project: Hive > Issue Type: Bug >Reporter: Deepak Jaiswal >Assignee: Deepak Jaiswal > Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch > > > Most of the SMB Join tests are actually not creating SMB Joins. Need them to > test the intended join. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[ https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287072#comment-16287072 ] Deepak Jaiswal commented on HIVE-18208: --- Thanks for the review [~jdere]. The test failures in the run are independent of changes in the patch. > SMB Join : Fix the unit tests to run SMB Joins. > --- > > Key: HIVE-18208 > URL: https://issues.apache.org/jira/browse/HIVE-18208 > Project: Hive > Issue Type: Bug >Reporter: Deepak Jaiswal >Assignee: Deepak Jaiswal > Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch > > > Most of the SMB Join tests are actually not creating SMB Joins. Need them to > test the intended join. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[ https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286986#comment-16286986 ] Jason Dere commented on HIVE-18208: --- I think the changes to the tests/plans look good. +1 > SMB Join : Fix the unit tests to run SMB Joins. > --- > > Key: HIVE-18208 > URL: https://issues.apache.org/jira/browse/HIVE-18208 > Project: Hive > Issue Type: Bug >Reporter: Deepak Jaiswal >Assignee: Deepak Jaiswal > Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch > > > Most of the SMB Join tests are actually not creating SMB Joins. Need them to > test the intended join. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[
https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284115#comment-16284115
]
Hive QA commented on HIVE-18208:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12901206/HIVE-18208.2.patch
{color:green}SUCCESS:{color} +1 due to 18 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 11514 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=160)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=113)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=226)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8146/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8146/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8146/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12901206 - PreCommit-HIVE-Build
> SMB Join : Fix the unit tests to run SMB Joins.
> ---
>
> Key: HIVE-18208
> URL: https://issues.apache.org/jira/browse/HIVE-18208
> Project: Hive
> Issue Type: Bug
>Reporter: Deepak Jaiswal
>Assignee: Deepak Jaiswal
> Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch
>
>
> Most of the SMB Join tests are actually not creating SMB Joins. Need them to
> test the intended join.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18208) SMB Join : Fix the unit tests to run SMB Joins.
[
https://issues.apache.org/jira/browse/HIVE-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284010#comment-16284010
]
Hive QA commented on HIVE-18208:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 36f0d89 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8146/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> SMB Join : Fix the unit tests to run SMB Joins.
> ---
>
> Key: HIVE-18208
> URL: https://issues.apache.org/jira/browse/HIVE-18208
> Project: Hive
> Issue Type: Bug
>Reporter: Deepak Jaiswal
>Assignee: Deepak Jaiswal
> Attachments: HIVE-18208.1.patch, HIVE-18208.2.patch
>
>
> Most of the SMB Join tests are actually not creating SMB Joins. Need them to
> test the intended join.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
