[jira] [Commented] (HIVE-18665) LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled
[ https://issues.apache.org/jira/browse/HIVE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374522#comment-16374522 ] Zoltan Haindrich commented on HIVE-18665: - [~gopalv]: it seems to me that this patch have broken a test; TestAcidOnTez https://travis-ci.org/kgyrtkirk/hive/builds/345287889 could you please take a look? > LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled > --- > > Key: HIVE-18665 > URL: https://issues.apache.org/jira/browse/HIVE-18665 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18665.1.patch > > > SplitLocationProvider removes HDFS locality in LLAP, causing more network > traffic when reading file formats which aren't currently cached. > In the absence of the IO elevator, cache affinity should be disabled. > This information is encoded into the MapWork in deriveLlapIoDescString, move > this to an Enum type for comparisons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18665) LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled
[ https://issues.apache.org/jira/browse/HIVE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359599#comment-16359599 ] Hive QA commented on HIVE-18665: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12909922/HIVE-18665.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 26 failed/errored test(s), 13136 tests executed *Failed tests:* {noformat} TestTriggersWorkloadManager - did not produce a TEST-*.xml file (likely timed out) (batchId=236) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=241) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (batchId=152) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=161) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_opt_shuffle_serde] (batchId=180) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (batchId=122) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1] (batchId=251) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=222) org.apache.hadoop.hive.metastore.client.TestTablesCreateDropAlterTruncate.testAlterTableNullStorageDescriptorInNew[Embedded] (batchId=206) org.apache.hadoop.hive.metastore.client.TestTablesList.testListTableNamesByFilterNullDatabase[Embedded] (batchId=206) org.apache.hadoop.hive.ql.TestAcidOnTez.testGetSplitsLocks (batchId=225) org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=257) org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188) org.apache.hive.jdbc.TestJdbcWithMiniLlap.testLlapInputFormatEndToEnd (batchId=236) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=235) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=235) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=235) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9142/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9142/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9142/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 26 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12909922 - PreCommit-HIVE-Build > LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled > --- > > Key: HIVE-18665 > URL: https://issues.apache.org/jira/browse/HIVE-18665 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18665.1.patch > > > SplitLocationProvider removes HDFS locality in LLAP, causing more network > traffic when reading file formats which aren't currently cached. > In the absence of the IO elevator, cache affinity should be disabled. > This information is encoded into the MapWork in deriveLlapIoDescString, move > this to an Enum type for comparisons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18665) LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled
[ https://issues.apache.org/jira/browse/HIVE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359560#comment-16359560 ] Hive QA commented on HIVE-18665: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 6 new + 39 unchanged - 2 fixed = 45 total (was 41) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh | | git revision | master / ddd4c9a | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9142/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-9142/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9142/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled > --- > > Key: HIVE-18665 > URL: https://issues.apache.org/jira/browse/HIVE-18665 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18665.1.patch > > > SplitLocationProvider removes HDFS locality in LLAP, causing more network > traffic when reading file formats which aren't currently cached. > In the absence of the IO elevator, cache affinity should be disabled. > This information is encoded into the MapWork in deriveLlapIoDescString, move > this to an Enum type for comparisons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18665) LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled
[ https://issues.apache.org/jira/browse/HIVE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359014#comment-16359014 ] Gopal V commented on HIVE-18665: Not sure if that ever gets triggered, but it is pretty much a toss-up on whether to force affinity or not. > LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled > --- > > Key: HIVE-18665 > URL: https://issues.apache.org/jira/browse/HIVE-18665 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18665.1.patch > > > SplitLocationProvider removes HDFS locality in LLAP, causing more network > traffic when reading file formats which aren't currently cached. > In the absence of the IO elevator, cache affinity should be disabled. > This information is encoded into the MapWork in deriveLlapIoDescString, move > this to an Enum type for comparisons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18665) LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled
[ https://issues.apache.org/jira/browse/HIVE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359005#comment-16359005 ] Sergey Shelukhin commented on HIVE-18665: - Why is some inputs false? +1 otherwise pending tests > LLAP: Ignore cache-affinity if the LLAP IO elevator is disabled > --- > > Key: HIVE-18665 > URL: https://issues.apache.org/jira/browse/HIVE-18665 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.0.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-18665.1.patch > > > SplitLocationProvider removes HDFS locality in LLAP, causing more network > traffic when reading file formats which aren't currently cached. > In the absence of the IO elevator, cache affinity should be disabled. > This information is encoded into the MapWork in deriveLlapIoDescString, move > this to an Enum type for comparisons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)