[jira] [Commented] (HIVE-19375) "'transactional'='false' is no longer a valid property and will be ignored:
[ https://issues.apache.org/jira/browse/HIVE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540931#comment-16540931 ] Jason Dere commented on HIVE-19375: --- ok, +1 > "'transactional'='false' is no longer a valid property and will be ignored: > > > Key: HIVE-19375 > URL: https://issues.apache.org/jira/browse/HIVE-19375 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > Attachments: HIVE-19375.01.patch > > > from {{TransactionalValidationListener.handleCreateTableTransactionalProp()}} > {noformat} > if ("false".equalsIgnoreCase(transactional)) { > // just drop transactional=false. For backward compatibility in case > someone has scripts > // with transactional=false > LOG.info("'transactional'='false' is no longer a valid property and > will be ignored: " + > Warehouse.getQualifiedName(newTable)); > return; > } > {noformat} > this msg is misleading since with metastore.create.as.acid=true, setting > transactional=false is valid to make a flat table -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19375) "'transactional'='false' is no longer a valid property and will be ignored:
[ https://issues.apache.org/jira/browse/HIVE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541949#comment-16541949 ] Hive QA commented on HIVE-19375: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 5m 24s{color} | {color:blue} standalone-metastore in master has 217 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 57s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} standalone-metastore: The patch generated 0 new + 20 unchanged - 1 fixed = 20 total (was 21) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 29s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12556/dev-support/hive-personality.sh | | git revision | master / 5ade740 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12556/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > "'transactional'='false' is no longer a valid property and will be ignored: > > > Key: HIVE-19375 > URL: https://issues.apache.org/jira/browse/HIVE-19375 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > Attachments: HIVE-19375.01.patch > > > from {{TransactionalValidationListener.handleCreateTableTransactionalProp()}} > {noformat} > if ("false".equalsIgnoreCase(transactional)) { > // just drop transactional=false. For backward compatibility in case > someone has scripts > // with transactional=false > LOG.info("'transactional'='false' is no longer a valid property and > will be ignored: " + > Warehouse.getQualifiedName(newTable)); > return; > } > {noformat} > this msg is misleading since with metastore.create.as.acid=true, setting > transactional=false is valid to make a flat table -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19375) "'transactional'='false' is no longer a valid property and will be ignored:
[ https://issues.apache.org/jira/browse/HIVE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541979#comment-16541979 ] Hive QA commented on HIVE-19375: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931228/HIVE-19375.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14649 tests executed *Failed tests:* {noformat} org.apache.hive.service.server.TestInformationSchemaWithPrivilege.test (batchId=247) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12556/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12556/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12556/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12931228 - PreCommit-HIVE-Build > "'transactional'='false' is no longer a valid property and will be ignored: > > > Key: HIVE-19375 > URL: https://issues.apache.org/jira/browse/HIVE-19375 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > Attachments: HIVE-19375.01.patch > > > from {{TransactionalValidationListener.handleCreateTableTransactionalProp()}} > {noformat} > if ("false".equalsIgnoreCase(transactional)) { > // just drop transactional=false. For backward compatibility in case > someone has scripts > // with transactional=false > LOG.info("'transactional'='false' is no longer a valid property and > will be ignored: " + > Warehouse.getQualifiedName(newTable)); > return; > } > {noformat} > this msg is misleading since with metastore.create.as.acid=true, setting > transactional=false is valid to make a flat table -- This message was sent by Atlassian JIRA (v7.6.3#76005)