[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521308#comment-16521308 ] Matt McCline commented on HIVE-19564: - Forgot a file. Committed to master again. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521280#comment-16521280 ] Prasanth Jayachandran commented on HIVE-19564: -- This is breaking the build on master. Reverted the master patch. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521251#comment-16521251 ] Matt McCline commented on HIVE-19564: - Committed to master. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521252#comment-16521252 ] Matt McCline commented on HIVE-19564: - Holding off on branch-3 for a while. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521250#comment-16521250 ] Matt McCline commented on HIVE-19564: - Successful tests. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[
https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521226#comment-16521226
]
Hive QA commented on HIVE-19564:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928692/HIVE-19564.02.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14594 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12024/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12024/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12024/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12928692 - PreCommit-HIVE-Build
> Vectorization: Fix NULL / Wrong Results issues in Arithmetic
>
>
> Key: HIVE-19564
> URL: https://issues.apache.org/jira/browse/HIVE-19564
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%)
> Divide by 0 bug found in Long Scalar % Column.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[
https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521223#comment-16521223
]
Hive QA commented on HIVE-19564:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
0s{color} | {color:blue} ql in master has 2282 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
33s{color} | {color:red} ql in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} ql: The patch generated 95 new + 382 unchanged - 5
fixed = 477 total (was 387) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} vector-code-gen: The patch generated 1 new + 318
unchanged - 0 fixed = 319 total (was 318) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12024/dev-support/hive-personality.sh
|
| git revision | master / 23d2b80 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12024/yetus/patch-mvninstall-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12024/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12024/yetus/diff-checkstyle-vector-code-gen.txt
|
| modules | C: ql vector-code-gen U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12024/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Vectorization: Fix NULL / Wrong Results issues in Arithmetic
>
>
> Key: HIVE-19564
> URL: https://issues.apache.org/jira/browse/HIVE-19564
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19564.01.patch, HIVE-19564.02.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%)
> Divide by 0 bug found in Long Scalar % Column.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[ https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519482#comment-16519482 ] Teddy Choi commented on HIVE-19564: --- LGTM +1. > Vectorization: Fix NULL / Wrong Results issues in Arithmetic > > > Key: HIVE-19564 > URL: https://issues.apache.org/jira/browse/HIVE-19564 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-19564.01.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%) > Divide by 0 bug found in Long Scalar % Column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[
https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519122#comment-16519122
]
Hive QA commented on HIVE-19564:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928445/HIVE-19564.01.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14539 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.io.TestSymlinkTextInputFormat.testFailure
(batchId=281)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11964/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11964/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11964/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12928445 - PreCommit-HIVE-Build
> Vectorization: Fix NULL / Wrong Results issues in Arithmetic
>
>
> Key: HIVE-19564
> URL: https://issues.apache.org/jira/browse/HIVE-19564
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19564.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Arithmetic
[
https://issues.apache.org/jira/browse/HIVE-19564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519089#comment-16519089
]
Hive QA commented on HIVE-19564:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
49s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
30s{color} | {color:red} ql in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 45 new + 382 unchanged - 5
fixed = 427 total (was 387) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} vector-code-gen: The patch generated 1 new + 318
unchanged - 0 fixed = 319 total (was 318) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11964/dev-support/hive-personality.sh
|
| git revision | master / 8f0973b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11964/yetus/patch-mvninstall-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11964/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11964/yetus/diff-checkstyle-vector-code-gen.txt
|
| modules | C: ql vector-code-gen U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11964/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Vectorization: Fix NULL / Wrong Results issues in Arithmetic
>
>
> Key: HIVE-19564
> URL: https://issues.apache.org/jira/browse/HIVE-19564
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19564.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized arithmetic (+,-,*,/,%)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
