[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403337#comment-17403337 ] Soumyakanti Das commented on HIVE-19647: Hey [~kgyrtkirk], I have started working on this. Just FYI :) > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, > HIVE-19647.03.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681568#comment-16681568 ] Hive QA commented on HIVE-19647: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947389/HIVE-19647.03.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 15537 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=333) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.addNoSuchTable[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.createGetDrop[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.createTableWithConstraintsPkInOtherCatalog[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.createTableWithConstraintsPk[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.doubleAddUniqueConstraint[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.getNoSuchCatalog[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.getNoSuchDb[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.getNoSuchTable[Remote] (batchId=223) org.apache.hadoop.hive.metastore.client.TestDefaultConstraint.inOtherCatalog[Remote] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14833/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14833/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14833/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12947389 - PreCommit-HIVE-Build > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, > HIVE-19647.03.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681507#comment-16681507 ] Hive QA commented on HIVE-19647: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 41s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s{color} | {color:red} ql: The patch generated 5 new + 101 unchanged - 1 fixed = 106 total (was 102) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 47s{color} | {color:red} ql generated 3 new + 2315 unchanged - 0 fixed = 2318 total (was 2315) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 14s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Found reliance on default encoding in org.apache.hadoop.hive.ql.optimizer.stats.annotation.HiveMurmur3Adapter.murmur3(Object):in org.apache.hadoop.hive.ql.optimizer.stats.annotation.HiveMurmur3Adapter.murmur3(Object): String.getBytes() At HiveMurmur3Adapter.java:[line 68] | | | org.apache.hadoop.hive.ql.plan.ColStatistics.getBitVectors() may expose internal representation by returning ColStatistics.bitVectors At ColStatistics.java:by returning ColStatistics.bitVectors At ColStatistics.java:[line 206] | | | org.apache.hadoop.hive.ql.plan.ColStatistics.setBitVectors(byte[]) may expose internal representation by storing an externally mutable object into ColStatistics.bitVectors At ColStatistics.java:by storing an externally mutable object into ColStatistics.bitVectors At ColStatistics.java:[line 202] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14833/dev-support/hive-personality.sh | | git revision | master / dc3cbf2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14833/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14833/yetus/new-findbugs-ql.html | | modules | C: common ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14833/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > use bitvectors in IN operators > ---
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679559#comment-16679559 ] Zoltan Haindrich commented on HIVE-19647: - [~ashutoshc] Could you please take a look? > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652992#comment-16652992 ] Zoltan Haindrich commented on HIVE-19647: - opened rb: https://reviews.apache.org/r/69058/ [~ashutoshc] Could you please take a look? > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650694#comment-16650694 ] Hive QA commented on HIVE-19647: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12943921/HIVE-19647.02.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14481/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14481/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14481/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12943921/HIVE-19647.02.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12943921 - PreCommit-HIVE-Build > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650693#comment-16650693 ] Hive QA commented on HIVE-19647: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12943921/HIVE-19647.02.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14480/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14480/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14480/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12943921/HIVE-19647.02.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12943921 - PreCommit-HIVE-Build > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650520#comment-16650520 ] Zoltan Haindrich commented on HIVE-19647: - [~ashutoshc] Could you please take a look? > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650506#comment-16650506 ] Hive QA commented on HIVE-19647: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12943921/HIVE-19647.02.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15083 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14476/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14476/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14476/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12943921 - PreCommit-HIVE-Build > use bitvectors in IN operators > -- > > Key: HIVE-19647 > URL: https://issues.apache.org/jira/browse/HIVE-19647 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19647.01.patch, HIVE-19647.02.patch, partial.patch > > > for strings there is no easy way to filter things out ; even min/max is null; > but the bitvectors could be used if they are available -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19647) use bitvectors in IN operators
[ https://issues.apache.org/jira/browse/HIVE-19647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650466#comment-16650466 ] Hive QA commented on HIVE-19647: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 35s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 8s{color} | {color:blue} ql in master has 2318 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 5 new + 101 unchanged - 1 fixed = 106 total (was 102) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 16s{color} | {color:red} ql generated 3 new + 2318 unchanged - 0 fixed = 2321 total (was 2318) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 21s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Found reliance on default encoding in org.apache.hadoop.hive.ql.optimizer.stats.annotation.HiveMurmur3Adapter.murmur3(Object):in org.apache.hadoop.hive.ql.optimizer.stats.annotation.HiveMurmur3Adapter.murmur3(Object): String.getBytes() At HiveMurmur3Adapter.java:[line 68] | | | org.apache.hadoop.hive.ql.plan.ColStatistics.getBitVectors() may expose internal representation by returning ColStatistics.bitVectors At ColStatistics.java:by returning ColStatistics.bitVectors At ColStatistics.java:[line 206] | | | org.apache.hadoop.hive.ql.plan.ColStatistics.setBitVectors(byte[]) may expose internal representation by storing an externally mutable object into ColStatistics.bitVectors At ColStatistics.java:by storing an externally mutable object into ColStatistics.bitVectors At ColStatistics.java:[line 202] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14476/dev-support/hive-personality.sh | | git revision | master / 8f3b312 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14476/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14476/yetus/new-findbugs-ql.html | | modules | C: common ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14476/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > use bitvectors in IN operators > ---