[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500799#comment-16500799
]
Sahil Takiar commented on HIVE-19752:
-
Thanks for taking a look [~vihangk1]. I double checked, and the {{HashMap}} in
each {{PerfLogger}} gets reset by the {{Driver}} so we shouldn't be leaking
them. Each {{PerfLogger}} is {{ThreadLocal}} too, so it should be garbage
collected after each session is closed.
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500792#comment-16500792
]
Vihang Karajgaonkar commented on HIVE-19752:
Ah, I see. Thanks [~stakiar] LGTM +1 On a side note, I am curious to understand
the behavior of Metrics scope when there are exceptions and we don't call the
{{PerfLogEnd}}. I hope we don't leak them.
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500731#comment-16500731
]
Sahil Takiar commented on HIVE-19752:
-
[~vihangk1] added an RB: https://reviews.apache.org/r/67439/
Yes, "FileMoves" is being used for {{loadPartition}} - this patch expands
"FileMoves" to cover other areas where files get moved like {{loadTable}} and
{{MoveTask#moveFile}}
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500714#comment-16500714
]
Vihang Karajgaonkar commented on HIVE-19752:
Hi [~stakiar] can you please add a review board url? Its hard to get which
methods are being used to insert the PERF logger counters. Also, I see
"FileMoves" is already being used in {{Hive#loadPartition}}. How does it
related to the one you are proposing to add here?
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499664#comment-16499664
]
Hive QA commented on HIVE-19752:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926006/HIVE-19752.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14451 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11486/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11486/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11486/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926006 - PreCommit-HIVE-Build
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499644#comment-16499644
]
Hive QA commented on HIVE-19752:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
29s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
34s{color} | {color:blue} ql in master has 2278 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11486/dev-support/hive-personality.sh
|
| git revision | master / a929d4c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11486/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[ https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498031#comment-16498031 ] Sahil Takiar commented on HIVE-19752: - [~vihangk1] could you take a look? > PerfLogger integration for critical Hive-on-S3 paths > > > Key: HIVE-19752 > URL: https://issues.apache.org/jira/browse/HIVE-19752 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Sahil Takiar >Assignee: Sahil Takiar >Priority: Major > Attachments: HIVE-19752.1.patch > > > There are several areas where Hive performs a lot of S3 operations, it would > be good to add PerfLogger statements around this so we can measure how long > they take. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19752) PerfLogger integration for critical Hive-on-S3 paths
[
https://issues.apache.org/jira/browse/HIVE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498029#comment-16498029
]
Sahil Takiar commented on HIVE-19752:
-
This is probably useful in general too, not just for S3. Added PerLogger
wrappers around {{getInputPaths}}, {{loadPartition}}, {{loadTable}},
{{loadDynamicPartitions}} and anywhere where files get moved to their final
directory.
> PerfLogger integration for critical Hive-on-S3 paths
>
>
> Key: HIVE-19752
> URL: https://issues.apache.org/jira/browse/HIVE-19752
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Sahil Takiar
>Assignee: Sahil Takiar
>Priority: Major
> Attachments: HIVE-19752.1.patch
>
>
> There are several areas where Hive performs a lot of S3 operations, it would
> be good to add PerfLogger statements around this so we can measure how long
> they take.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
