[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515742#comment-16515742
]
Peter Vary commented on HIVE-19807:
---
[~belugabehr]: If you take a look at the callers of
{{Utilities.getHeaderCount}} you will see, that these methods expect
IOExceptions if there is a problem reading the files. In some cases they catch
every exception and they are creating an IOException from it anyway, but in
case of {{HiveInputFormat}} we might have some extra surprises... As we see in
the test failure (at least this is my guess :) ):
{code}
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[file_with_header_footer_negative]
(batchId=98)
{code}
Thanks,
Peter
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch, HIVE-19807.2.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509570#comment-16509570
]
BELUGA BEHR commented on HIVE-19807:
[~stakiar] [~aihuaxu] :)
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch, HIVE-19807.2.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509457#comment-16509457
]
Hive QA commented on HIVE-19807:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927335/HIVE-19807.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14521 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[file_with_header_footer_negative]
(batchId=98)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testQueueingWithThreads
(batchId=277)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11726/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11726/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11726/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12927335 - PreCommit-HIVE-Build
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch, HIVE-19807.2.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509382#comment-16509382
]
Hive QA commented on HIVE-19807:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
21s{color} | {color:blue} ql in master has 2279 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11726/dev-support/hive-personality.sh
|
| git revision | master / e7cee30 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11726/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch, HIVE-19807.2.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505594#comment-16505594
]
Hive QA commented on HIVE-19807:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926643/HIVE-19807.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14481 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[file_with_header_footer_negative]
(batchId=98)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures
(batchId=296)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11603/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11603/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11603/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926643 - PreCommit-HIVE-Build
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19807) Add Useful Error Message To Table Header/Footer Parsing
[
https://issues.apache.org/jira/browse/HIVE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505567#comment-16505567
]
Hive QA commented on HIVE-19807:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
31s{color} | {color:blue} ql in master has 2284 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
35s{color} | {color:red} ql: The patch generated 1 new + 119 unchanged - 0
fixed = 120 total (was 119) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11603/dev-support/hive-personality.sh
|
| git revision | master / 5aa8f87 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11603/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11603/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add Useful Error Message To Table Header/Footer Parsing
> ---
>
> Key: HIVE-19807
> URL: https://issues.apache.org/jira/browse/HIVE-19807
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HIVE-19807.1.patch
>
>
> Add some useful logging messages to invalid value parsing of
> {{skip.header.line.count}} and {{skip.footer.line.count}} for better
> troubleshooting.
> Also, parsing error resulted in {{java.io.IOException}} which:
> {quote}
> Signals that an I/O exception of some sort has occurred. This class is the
> general class of exceptions produced by failed or interrupted I/O operations.
> {quote}
> A parsing error is not the result of a failed or interrupted I/O operation so
> I dropped it and replaced with runtime exception {{IllegalArgumentException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
