[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[
https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507228#comment-16507228
]
Hive QA commented on HIVE-19813:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927138/HIVE-19813.3.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11670/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11670/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11670/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12927138/HIVE-19813.3.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12927138 - PreCommit-HIVE-Build
> SessionState.start don't have to be synchronized
>
>
> Key: HIVE-19813
> URL: https://issues.apache.org/jira/browse/HIVE-19813
> Project: Hive
> Issue Type: Bug
>Reporter: Daniel Dai
>Assignee: Daniel Dai
>Priority: Major
> Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch,
> HIVE-19813.3.patch
>
>
> This is introduced in HIVE-14690. However, only check-set block needs to be
> synchronized, not the whole block. The method will start Tez AM, which is a
> long operation. Make the method synchronized will serialize session start
> thus slow down hs2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[
https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506861#comment-16506861
]
Hive QA commented on HIVE-19813:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927138/HIVE-19813.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14512 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11647/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11647/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11647/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12927138 - PreCommit-HIVE-Build
> SessionState.start don't have to be synchronized
>
>
> Key: HIVE-19813
> URL: https://issues.apache.org/jira/browse/HIVE-19813
> Project: Hive
> Issue Type: Bug
>Reporter: Daniel Dai
>Assignee: Daniel Dai
>Priority: Major
> Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch,
> HIVE-19813.3.patch
>
>
> This is introduced in HIVE-14690. However, only check-set block needs to be
> synchronized, not the whole block. The method will start Tez AM, which is a
> long operation. Make the method synchronized will serialize session start
> thus slow down hs2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[
https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506855#comment-16506855
]
Hive QA commented on HIVE-19813:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
25s{color} | {color:blue} ql in master has 2284 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} ql: The patch generated 0 new + 58 unchanged - 1
fixed = 58 total (was 59) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11647/dev-support/hive-personality.sh
|
| git revision | master / 6454585 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11647/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> SessionState.start don't have to be synchronized
>
>
> Key: HIVE-19813
> URL: https://issues.apache.org/jira/browse/HIVE-19813
> Project: Hive
> Issue Type: Bug
>Reporter: Daniel Dai
>Assignee: Daniel Dai
>Priority: Major
> Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch,
> HIVE-19813.3.patch
>
>
> This is introduced in HIVE-14690. However, only check-set block needs to be
> synchronized, not the whole block. The method will start Tez AM, which is a
> long operation. Make the method synchronized will serialize session start
> thus slow down hs2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[ https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506643#comment-16506643 ] Daniel Dai commented on HIVE-19813: --- Retest. > SessionState.start don't have to be synchronized > > > Key: HIVE-19813 > URL: https://issues.apache.org/jira/browse/HIVE-19813 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch, > HIVE-19813.3.patch > > > This is introduced in HIVE-14690. However, only check-set block needs to be > synchronized, not the whole block. The method will start Tez AM, which is a > long operation. Make the method synchronized will serialize session start > thus slow down hs2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[
https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505788#comment-16505788
]
Hive QA commented on HIVE-19813:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926966/HIVE-19813.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14509 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMetastoreTablesCleanup
(batchId=303)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11611/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11611/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11611/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926966 - PreCommit-HIVE-Build
> SessionState.start don't have to be synchronized
>
>
> Key: HIVE-19813
> URL: https://issues.apache.org/jira/browse/HIVE-19813
> Project: Hive
> Issue Type: Bug
>Reporter: Daniel Dai
>Assignee: Daniel Dai
>Priority: Major
> Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch
>
>
> This is introduced in HIVE-14690. However, only check-set block needs to be
> synchronized, not the whole block. The method will start Tez AM, which is a
> long operation. Make the method synchronized will serialize session start
> thus slow down hs2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[
https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505753#comment-16505753
]
Hive QA commented on HIVE-19813:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
30s{color} | {color:blue} ql in master has 2284 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} ql: The patch generated 0 new + 58 unchanged - 1
fixed = 58 total (was 59) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11611/dev-support/hive-personality.sh
|
| git revision | master / 13960aa |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11611/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> SessionState.start don't have to be synchronized
>
>
> Key: HIVE-19813
> URL: https://issues.apache.org/jira/browse/HIVE-19813
> Project: Hive
> Issue Type: Bug
>Reporter: Daniel Dai
>Assignee: Daniel Dai
>Priority: Major
> Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch
>
>
> This is introduced in HIVE-14690. However, only check-set block needs to be
> synchronized, not the whole block. The method will start Tez AM, which is a
> long operation. Make the method synchronized will serialize session start
> thus slow down hs2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[ https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505234#comment-16505234 ] Daniel Dai commented on HIVE-19813: --- Thanks for the suggestion. Patch updated. > SessionState.start don't have to be synchronized > > > Key: HIVE-19813 > URL: https://issues.apache.org/jira/browse/HIVE-19813 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-19813.1.patch, HIVE-19813.2.patch > > > This is introduced in HIVE-14690. However, only check-set block needs to be > synchronized, not the whole block. The method will start Tez AM, which is a > long operation. Make the method synchronized will serialize session start > thus slow down hs2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19813) SessionState.start don't have to be synchronized
[ https://issues.apache.org/jira/browse/HIVE-19813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503983#comment-16503983 ] Sergey Shelukhin commented on HIVE-19813: - +1. Could also be atomicboolean? > SessionState.start don't have to be synchronized > > > Key: HIVE-19813 > URL: https://issues.apache.org/jira/browse/HIVE-19813 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-19813.1.patch > > > This is introduced in HIVE-14690. However, only check-set block needs to be > synchronized, not the whole block. The method will start Tez AM, which is a > long operation. Make the method synchronized will serialize session start > thus slow down hs2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
