[jira] [Commented] (HIVE-19950) Hive ACID NOT LOCK LockComponent Correctly
[ https://issues.apache.org/jira/browse/HIVE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621348#comment-16621348 ] Hive QA commented on HIVE-19950: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12928594/patch.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13916/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13916/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13916/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-09-20 00:31:21.054 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-13916/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-09-20 00:31:21.058 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 487714a HIVE-19166: TestMiniLlapLocalCliDriver sysdb failure (Daniel Dai, reviewed by Vaibhav Gumashta) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 487714a HIVE-19166: TestMiniLlapLocalCliDriver sysdb failure (Daniel Dai, reviewed by Vaibhav Gumashta) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-09-20 00:31:21.775 + rm -rf ../yetus_PreCommit-HIVE-Build-13916 + mkdir ../yetus_PreCommit-HIVE-Build-13916 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-13916 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-13916/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: does not exist in index error: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: does not exist in index error: src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-13916 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12928594 - PreCommit-HIVE-Build > Hive ACID NOT LOCK LockComponent Correctly > -- > > Key: HIVE-19950 > URL: https://issues.apache.org/jira/browse/HIVE-19950 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.3.2 >Reporter: nickSoul >Priority: Blocker > Attachments: patch.patch > > > Hi, > When using Streaming Mutation recently, I found LockComponents were not > locked correctly by current transaction. Below is my test case: > Step1: Begin a transaction with transactionId 126, and the transaction locks > a table. Then hangs the transaction. The lock information were correctly > restored in mariaDB. > {code:sql} > MariaDB [hive]> select > HL_LOCK_EXT_ID,HL_LOCK_INT_ID,HL_TXNID,HL_DB,HL_TABLE,HL_PARTITION,HL_LOCK_STATE,HL_LOCK_TYPE,HL_ACQUIRED_AT,HL_BLOCKEDBY_EXT_ID,HL_BLOCKEDBY_INT_ID > from HIVE_LOCKS; > {code} > | HL_LOCK_EXT_ID | HL_LOCK_INT_ID | HL_TXNID | HL_DB | HL_TABLE | > HL_PARTITION | HL_LOCK_STATE | HL_LOCK_TYPE | HL_ACQUIRED_AT | > HL_BLOCKEDBY_EXT_ID | HL_BLOCKEDBY_INT_ID | > | 384 | 1 | 126 | test_acid | acid_test | NULL | a | w | 1529512857000 | NULL > | NULL | > > Step2: Begin the other transaction with a transactionId 127 before previous > transaction 126 finished. Transac
[jira] [Commented] (HIVE-19950) Hive ACID NOT LOCK LockComponent Correctly
[ https://issues.apache.org/jira/browse/HIVE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520052#comment-16520052 ] Hive QA commented on HIVE-19950: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 3s{color} | {color:blue} standalone-metastore in master has 227 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s{color} | {color:red} standalone-metastore: The patch generated 4 new + 531 unchanged - 11 fixed = 535 total (was 542) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 16s{color} | {color:red} standalone-metastore generated 1 new + 227 unchanged - 0 fixed = 228 total (was 227) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 36s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore | | | Private method org.apache.hadoop.hive.metastore.txn.TxnHandler.shouldNeverHappen(long, long, long) is never called At TxnHandler.java:is never called At TxnHandler.java:[lines 2497-2498] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11989/dev-support/hive-personality.sh | | git revision | master / 24e16cc | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11989/yetus/diff-checkstyle-standalone-metastore.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-11989/yetus/new-findbugs-standalone-metastore.html | | modules | C: standalone-metastore U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11989/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Hive ACID NOT LOCK LockComponent Correctly > -- > > Key: HIVE-19950 > URL: https://issues.apache.org/jira/browse/HIVE-19950 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.3.2 >Reporter: nickSoul >Priority: Blocker > Attachments: patch.patch > > > Hi, > When using Streaming Mutation recently, I found LockComponents were not > locked correctly by current transaction. Below is my test case: > Step1: Begin a transaction with transactionId 126, and the transaction locks > a table. Then hangs the transaction. The lock information were correctly > restored in mariaDB > {code:java} > MariaDB [hive]> select > HL_LOCK_EXT_ID,HL_LOCK_INT_ID,HL_TXNID,HL_DB,HL_TABLE,HL_PARTITION,HL_LOCK_STATE,HL_LOCK_TYPE,HL_ACQUIRED_AT,HL_BLOCKEDBY_EXT_ID,HL_BLOCKEDBY_INT_ID > from HIVE_LOCKS; > +++--+---
[jira] [Commented] (HIVE-19950) Hive ACID NOT LOCK LockComponent Correctly
[ https://issues.apache.org/jira/browse/HIVE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520084#comment-16520084 ] Hive QA commented on HIVE-19950: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12928594/patch.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 36 failed/errored test(s), 14589 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.txn.TestTxnHandler.showLocks (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testCheckLockAcquireAfterWaiting (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockDbLocksTable (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockEESR (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockEESW (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockESRE (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockESRSR (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockESRSW (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockSRE (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockSameDB (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockSamePartition (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockSameTable (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testLockTableLocksPartition (batchId=268) org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testMultipleLockWait (batchId=268) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.basicBlocking (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.checkExpectedLocks (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.checkExpectedLocks2 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.lockConflictDbTable (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testFairness (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testFairness2 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testLockBlockedBy (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testLockRetryLimit (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMerge3Way01 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMerge3Way02 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergePartitioned01 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergePartitioned02 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergeUnpartitioned01 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMetadataOperationLocks (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking10 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking11 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking3 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking5 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking7 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking8 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking9 (batchId=305) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.updateSelectUpdate (batchId=305) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11989/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11989/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11989/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 36 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12928594 - PreCommit-HIVE-Build > Hive ACID NOT LOCK LockComponent Correctly > -- > > Key: HIVE-19950 > URL: https://issues.apache.org/jira/browse/HIVE-19950 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.3.2 >Reporter: nickSoul >Priority: Blocker > Attachments: patch.patch > > > Hi, > When using Streaming Mutation recently, I found LockComponents were not > locked correctly by current transaction. Below is my test case: > Step1: Begin a transaction with transactionId 126, and the transaction locks > a