[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537202#comment-16537202
]
Gopal V commented on HIVE-20043:
Yup, pushed to master, thanks [~abstractdog].
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Fix For: 4.0.0
>
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch, HIVE-20043.04.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536774#comment-16536774
]
Laszlo Bodor commented on HIVE-20043:
-
[~gopalv], [~kgyrtkirk] : tests passed, i think this is ready to commit
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch, HIVE-20043.04.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536771#comment-16536771
]
Hive QA commented on HIVE-20043:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12930796/HIVE-20043.04.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14620 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12485/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12485/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12485/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12930796 - PreCommit-HIVE-Build
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch, HIVE-20043.04.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536753#comment-16536753
]
Hive QA commented on HIVE-20043:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
27s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12485/dev-support/hive-personality.sh
|
| git revision | master / 9fb4292 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12485/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch, HIVE-20043.04.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536160#comment-16536160
]
Hive QA commented on HIVE-20043:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12930663/HIVE-20043.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 14631 tests
executed
*Failed tests:*
{noformat}
TestAutoPurgeTables - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
TestLocationQueries - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
TestSparkStatistics - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
org.apache.hadoop.hive.metastore.TestHiveMetaStoreAlterColumnPar.org.apache.hadoop.hive.metastore.TestHiveMetaStoreAlterColumnPar
(batchId=235)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12472/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12472/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12472/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12930663 - PreCommit-HIVE-Build
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536154#comment-16536154
]
Hive QA commented on HIVE-20043:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
57s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 4 new + 74 unchanged - 0 fixed
= 78 total (was 74) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
7s{color} | {color:red} root: The patch generated 4 new + 74 unchanged - 0
fixed = 78 total (was 74) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 62m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12472/dev-support/hive-personality.sh
|
| git revision | master / 406cde9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12472/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12472/yetus/diff-checkstyle-root.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12472/yetus/whitespace-eol.txt
|
| modules | C: ql . U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12472/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch,
> HIVE-20043.03.patch
>
>
> {code}
>
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535714#comment-16535714
]
Hive QA commented on HIVE-20043:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12930506/HIVE-20043.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 14616 tests
executed
*Failed tests:*
{noformat}
TestAlterTableMetadata - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
TestAutoPurgeTables - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
TestLocationQueries - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
TestReplicationScenariosAcidTables - did not produce a TEST-*.xml file (likely
timed out) (batchId=240)
TestSemanticAnalyzerHookLoading - did not produce a TEST-*.xml file (likely
timed out) (batchId=240)
TestSparkStatistics - did not produce a TEST-*.xml file (likely timed out)
(batchId=240)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_dynamic_partition]
(batchId=190)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_expressions]
(batchId=190)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test1]
(batchId=190)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test_alter]
(batchId=190)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test_insert]
(batchId=190)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12439/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12439/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12439/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12930506 - PreCommit-HIVE-Build
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535695#comment-16535695
]
Hive QA commented on HIVE-20043:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
47s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12439/dev-support/hive-personality.sh
|
| git revision | master / 8494522 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12439/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Branch3Candidate, Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534663#comment-16534663
]
Zoltan Haindrich commented on HIVE-20043:
-
+1
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534652#comment-16534652
]
Laszlo Bodor commented on HIVE-20043:
-
[~gopalv] [~kgyrtkirk] could you take a look?
I removed the "unrelated" unit test in 02.patch, it was just a "POC"
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Concurrency
> Attachments: HIVE-20043.01.patch, HIVE-20043.02.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20043) HiveServer2: SessionState has a static sync block around an AtomicBoolean
[
https://issues.apache.org/jira/browse/HIVE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533680#comment-16533680
]
Laszlo Bodor commented on HIVE-20043:
-
i think AtomicBoolean is enough, checked patch history of HIVE-19813, first
synchronized was moved from method signature to isStarted checker block, and
then AtomicBoolean was added, however the latter seems to be enough in this case
attached test case
> HiveServer2: SessionState has a static sync block around an AtomicBoolean
> -
>
> Key: HIVE-20043
> URL: https://issues.apache.org/jira/browse/HIVE-20043
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Laszlo Bodor
>Priority: Major
> Labels: Concurrency
> Attachments: HIVE-20043.01.patch
>
>
> {code}
> private static void start(SessionState startSs, boolean isAsync, LogHelper
> console) {
> ...
> synchronized(SessionState.class) {
> if (!startSs.isStarted.compareAndSet(false, true)) {
> return;
> }
> }
> {code}
> startSs.isStarted is an AtomicBoolean, which makes it hard to know why this
> code is locked with a static lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
