[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553842#comment-16553842 ] Hive QA commented on HIVE-20082: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932789/HIVE-20082.4.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12814/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12814/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12814/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12932789/HIVE-20082.4.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12932789 - PreCommit-HIVE-Build > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553805#comment-16553805 ] Hive QA commented on HIVE-20082: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932789/HIVE-20082.4.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14685 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12812/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12812/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12812/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12932789 - PreCommit-HIVE-Build > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553790#comment-16553790 ] Hive QA commented on HIVE-20082: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 15s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 41s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 1s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 27s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} accumulo-handler in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} serde: The patch generated 4 new + 299 unchanged - 0 fixed = 303 total (was 299) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} accumulo-handler: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 49s{color} | {color:red} ql: The patch generated 14 new + 899 unchanged - 10 fixed = 913 total (was 909) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12812/dev-support/hive-personality.sh | | git revision | master / 87b9f64 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-12812/yetus/patch-mvninstall-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12812/yetus/diff-checkstyle-serde.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12812/yetus/diff-checkstyle-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12812/yetus/diff-checkstyle-ql.txt | | modules | C: serde accumulo-handler ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12812/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > >
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553506#comment-16553506 ] Ashutosh Chauhan commented on HIVE-20082: - +1 > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553489#comment-16553489 ] Jason Dere commented on HIVE-20082: --- Ok, I think I've updated the patch correctly > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553486#comment-16553486 ] Jason Dere commented on HIVE-20082: --- Oh, if you mean I accidentally included the changes from HIVE-20204 as well, that might be the case, let me check. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553484#comment-16553484 ] Jason Dere commented on HIVE-20082: --- Which differences are you referring to? I think any changes in this patch have to do with the change in decimal-to-string conversion, so either extra 0-padding or change in the string cast function name. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553477#comment-16553477 ] Ashutosh Chauhan commented on HIVE-20082: - Looks like latest patch contains diffs from HIVE-20204 . Incorrectly generated patch? > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch, HIVE-20082.4.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552529#comment-16552529 ] Hive QA commented on HIVE-20082: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932652/HIVE-20082.3.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14682 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12789/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12789/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12789/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12932652 - PreCommit-HIVE-Build > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552495#comment-16552495 ] Hive QA commented on HIVE-20082: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 43s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 43s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 0s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} accumulo-handler in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} serde: The patch generated 4 new + 299 unchanged - 0 fixed = 303 total (was 299) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} accumulo-handler: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 46s{color} | {color:red} ql: The patch generated 16 new + 898 unchanged - 3 fixed = 914 total (was 901) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 31m 35s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12789/dev-support/hive-personality.sh | | git revision | master / 170a012 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-12789/yetus/patch-mvninstall-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12789/yetus/diff-checkstyle-serde.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12789/yetus/diff-checkstyle-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12789/yetus/diff-checkstyle-ql.txt | | modules | C: serde accumulo-handler ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12789/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > >
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552395#comment-16552395 ] Jason Dere commented on HIVE-20082: --- RB at https://reviews.apache.org/r/68013/ > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552391#comment-16552391 ] Jason Dere commented on HIVE-20082: --- Patch v3 no longer includes HIVE-20204, since that has been committed. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch, > HIVE-20082.3.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552164#comment-16552164 ] Hive QA commented on HIVE-20082: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932605/HIVE-20082.2.patch {color:green}SUCCESS:{color} +1 due to 7 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14681 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12782/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12782/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12782/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12932605 - PreCommit-HIVE-Build > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552156#comment-16552156 ] Hive QA commented on HIVE-20082: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 47s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 22s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 42s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 15s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 32s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 21s{color} | {color:red} accumulo-handler in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} serde: The patch generated 4 new + 299 unchanged - 0 fixed = 303 total (was 299) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} accumulo-handler: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 48s{color} | {color:red} ql: The patch generated 20 new + 940 unchanged - 4 fixed = 960 total (was 944) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12782/dev-support/hive-personality.sh | | git revision | master / cce3a05 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-12782/yetus/patch-mvninstall-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12782/yetus/diff-checkstyle-serde.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12782/yetus/diff-checkstyle-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12782/yetus/diff-checkstyle-ql.txt | | modules | C: serde accumulo-handler ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12782/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > >
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552131#comment-16552131 ] Jason Dere commented on HIVE-20082: --- Another combined patch of HIVE-20204 + HIVE-20082, with fixes to the test failures. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch, HIVE-20082.2.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551796#comment-16551796 ] Hive QA commented on HIVE-20082: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932518/HIVE-20082.1.patch {color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 14676 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=192) [druidmini_dynamic_partition.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test1.q,druidmini_test_insert.q] org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_index] (batchId=255) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[char_pad_convert] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[show_functions] (batchId=77) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[infer_bucket_sort_map_operators] (batchId=188) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query36] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query70] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query86] (batchId=265) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query36] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query86] (batchId=263) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTypeCasts.testCastDecimalToString (batchId=299) org.apache.hadoop.hive.serde2.objectinspector.TestObjectInspectorConverters.testObjectInspectorConverters (batchId=317) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12769/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12769/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12769/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12932518 - PreCommit-HIVE-Build > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551793#comment-16551793 ] Hive QA commented on HIVE-20082: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 19s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 41s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 33s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 10s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 21s{color} | {color:red} accumulo-handler in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} serde: The patch generated 4 new + 257 unchanged - 0 fixed = 261 total (was 257) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} accumulo-handler: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 50s{color} | {color:red} ql: The patch generated 20 new + 908 unchanged - 4 fixed = 928 total (was 912) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 34s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12769/dev-support/hive-personality.sh | | git revision | master / e569ef0 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-12769/yetus/patch-mvninstall-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12769/yetus/diff-checkstyle-serde.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12769/yetus/diff-checkstyle-accumulo-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12769/yetus/diff-checkstyle-ql.txt | | modules | C: serde accumulo-handler ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12769/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > >
[jira] [Commented] (HIVE-20082) HiveDecimal to string conversion doesn't format the decimal correctly - master
[ https://issues.apache.org/jira/browse/HIVE-20082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551429#comment-16551429 ] Jason Dere commented on HIVE-20082: --- Adding initial patch which also includes the changes for HIVE-20204. Hopefully this covers most of the qfile changes. Quite a bit of the qfile changes are due to the change from "UDFToString(...)" to "CAST( ... as STRING), which I suppose could be eliminated by changing GenericUDFToString.getDisplayString() to show "UDFToString(...)", but that seems a bit sneaky. cc [~ashutoshc] > HiveDecimal to string conversion doesn't format the decimal correctly - master > -- > > Key: HIVE-20082 > URL: https://issues.apache.org/jira/browse/HIVE-20082 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-20082.1.patch > > > Example: LPAD on a decimal(7,1) values of 0 returns "0" (plus padding) but it > should be "0.0" (plus padding) -- This message was sent by Atlassian JIRA (v7.6.3#76005)