[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559020#comment-16559020 ] Andrew Sherman commented on HIVE-20158: --- Thaks [~vihangk1] > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-20158.1.patch, HIVE-20158.2.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556218#comment-16556218 ] Vihang Karajgaonkar commented on HIVE-20158: +1 > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20158.1.patch, HIVE-20158.2.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555160#comment-16555160 ] Hive QA commented on HIVE-20158: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932931/HIVE-20158.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14687 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12838/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12838/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12838/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12932931 - PreCommit-HIVE-Build > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20158.1.patch, HIVE-20158.2.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555148#comment-16555148 ] Hive QA commented on HIVE-20158: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 53m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} contrib in master has 13 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} contrib: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 56m 21s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12838/dev-support/hive-personality.sh | | git revision | master / ca0d706 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: contrib U: contrib | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12838/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20158.1.patch, HIVE-20158.2.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554056#comment-16554056 ] Hive QA commented on HIVE-20158: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932795/HIVE-20158.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 14684 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timestamptz] (batchId=193) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_joins] (batchId=193) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_masking] (batchId=193) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12818/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12818/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12818/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12932795 - PreCommit-HIVE-Build > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20158.1.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554011#comment-16554011 ] Hive QA commented on HIVE-20158: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} contrib in master has 13 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} contrib: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 10m 41s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12818/dev-support/hive-personality.sh | | git revision | master / 87b9f64 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12818/yetus/diff-checkstyle-contrib.txt | | modules | C: contrib U: contrib | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12818/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Andrew Sherman >Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20158.1.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardC
[jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
[ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542278#comment-16542278 ] BELUGA BEHR commented on HIVE-20158: The class {{Base64TextInputFormat}} has the same issue. > Do Not Print StackTraces to STDERR in Base64TextOutputFormat > > > Key: HIVE-20158 > URL: https://issues.apache.org/jira/browse/HIVE-20158 > Project: Hive > Issue Type: Improvement > Components: Contrib >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Priority: Trivial > Labels: newbie, noob > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java > {code} > try { > String signatureString = > job.get("base64.text.output.format.signature"); > if (signatureString != null) { > signature = signatureString.getBytes("UTF-8"); > } else { > signature = new byte[0]; > } > } catch (UnsupportedEncodingException e) { > e.printStackTrace(); > } > {code} > The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method > call. Instead, use the {{CharSet}} version of the method and it doesn't > throw this explicit exception so the 'try' block can simply be removed. > Every JVM will support UTF-8. > https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset) > https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)