[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543294#comment-16543294 ] BELUGA BEHR commented on HIVE-20168: Actually... don't remove anything... just change the guards to match the {{MapOperator}} implementation. Though you should do: {code} if (LOG.isTraceEnabled()) { LOG.info(toString() + ": records written - " + numRows); } // --- LOG.info("{} records written - {}", this, numRows); {code} > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Priority: Minor > Labels: newbie, noob > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551407#comment-16551407 ] Bharathkrishna Guruvayoor Murali commented on HIVE-20168: - So do you mean this log should be shown in INFO level? In that case, should the log in ReduceSinkOperator#closeOp also be shown in INFO level? > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552899#comment-16552899 ] BELUGA BEHR commented on HIVE-20168: [~bharos92] Yes. Thanks for pointing that out. I've updated my comment. And yes, the closeOp should also be INFO: {code} if (LOG.isTraceEnabled()) { LOG.info(toString() + ": records written - " + numRows); } // ---> LOG.info("{}: records written - {}", this, numRows); {code} > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553412#comment-16553412 ] Bharathkrishna Guruvayoor Murali commented on HIVE-20168: - Updated the patch with parameterized logging. > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553703#comment-16553703 ] Hive QA commented on HIVE-20168: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932776/HIVE-20168.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14683 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12807/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12807/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12807/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12932776 - PreCommit-HIVE-Build > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553704#comment-16553704 ] Hive QA commented on HIVE-20168: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12932776/HIVE-20168.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12808/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12808/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12808/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12932776/HIVE-20168.2.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12932776 - PreCommit-HIVE-Build > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554665#comment-16554665 ] BELUGA BEHR commented on HIVE-20168: [~bharos92] Thank you the assist. One more item. Sorry. Can you please include the {{abort}} flag in the logging message of {{closeOp}} as well? Thanks! > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556473#comment-16556473 ] Hive QA commented on HIVE-20168: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 21s{color} | {color:blue} ql in master has 2296 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 5s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12864/dev-support/hive-personality.sh | | git revision | master / 9d78fac | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12864/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch, > HIVE-20168.3.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556748#comment-16556748 ] Hive QA commented on HIVE-20168: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12933091/HIVE-20168.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14812 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12864/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12864/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12864/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12933091 - PreCommit-HIVE-Build > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch, > HIVE-20168.3.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559007#comment-16559007 ] Vihang Karajgaonkar commented on HIVE-20168: +1 > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch, > HIVE-20168.3.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden
[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562220#comment-16562220 ] Vihang Karajgaonkar commented on HIVE-20168: patch merged into master and branch-3. Thanks for your contribution [~bharos92] > ReduceSinkOperator Logging Hidden > - > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators >Affects Versions: 3.0.0, 4.0.0 >Reporter: BELUGA BEHR >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Minor > Labels: newbie, noob > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-20168.1.patch, HIVE-20168.2.patch, > HIVE-20168.3.patch > > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)