[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[ https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553363#comment-16553363 ] Naveen Gangam commented on HIVE-20201: -- [~vgarg] Thanks. Pushed to branch-3. I have updated the Fixed versions to include 3.2. Please correct if it is wrong. Thanks > Hive shouldn't use HBase's Base64 implementation > > > Key: HIVE-20201 > URL: https://issues.apache.org/jira/browse/HIVE-20201 > Project: Hive > Issue Type: Task > Components: HBase Handler >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-20201.0.patch > > > HBase is removing their Base64 implementation because it never should have > been public, so Hive should switch to a different provider. Hive already uses > Commons-Codec Base64 in other places, so that would be a natural replacement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[ https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552212#comment-16552212 ] Vineet Garg commented on HIVE-20201: [~ngangam] Sure go ahead and push this to branch-3. > Hive shouldn't use HBase's Base64 implementation > > > Key: HIVE-20201 > URL: https://issues.apache.org/jira/browse/HIVE-20201 > Project: Hive > Issue Type: Task > Components: HBase Handler >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20201.0.patch > > > HBase is removing their Base64 implementation because it never should have > been public, so Hive should switch to a different provider. Hive already uses > Commons-Codec Base64 in other places, so that would be a natural replacement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[ https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549381#comment-16549381 ] Naveen Gangam commented on HIVE-20201: -- [~vgarg] I think we should push this to branch-3 as well because we are planning on committing HIVE-20205 to branch-3 that move Hbase from 2.0.0-alpha to 2.0.1 release. Please let me know if you agree. Thanks > Hive shouldn't use HBase's Base64 implementation > > > Key: HIVE-20201 > URL: https://issues.apache.org/jira/browse/HIVE-20201 > Project: Hive > Issue Type: Task > Components: HBase Handler >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20201.0.patch > > > HBase is removing their Base64 implementation because it never should have > been public, so Hive should switch to a different provider. Hive already uses > Commons-Codec Base64 in other places, so that would be a natural replacement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[
https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548901#comment-16548901
]
Hive QA commented on HIVE-20201:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12932111/HIVE-20201.0.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14657 tests
executed
*Failed tests:*
{noformat}
TestWebHCatE2e - did not produce a TEST-*.xml file (likely timed out)
(batchId=202)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12687/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12687/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12687/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12932111 - PreCommit-HIVE-Build
> Hive shouldn't use HBase's Base64 implementation
>
>
> Key: HIVE-20201
> URL: https://issues.apache.org/jira/browse/HIVE-20201
> Project: Hive
> Issue Type: Task
> Components: HBase Handler
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Attachments: HIVE-20201.0.patch
>
>
> HBase is removing their Base64 implementation because it never should have
> been public, so Hive should switch to a different provider. Hive already uses
> Commons-Codec Base64 in other places, so that would be a natural replacement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[
https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548876#comment-16548876
]
Hive QA commented on HIVE-20201:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 39m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12687/dev-support/hive-personality.sh
|
| git revision | master / d5c589b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: hbase-handler U: hbase-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12687/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Hive shouldn't use HBase's Base64 implementation
>
>
> Key: HIVE-20201
> URL: https://issues.apache.org/jira/browse/HIVE-20201
> Project: Hive
> Issue Type: Task
> Components: HBase Handler
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Attachments: HIVE-20201.0.patch
>
>
> HBase is removing their Base64 implementation because it never should have
> been public, so Hive should switch to a different provider. Hive already uses
> Commons-Codec Base64 in other places, so that would be a natural replacement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[ https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548276#comment-16548276 ] Mike Drob commented on HIVE-20201: -- Precommit has been having issues recently, INFRA-16784 tracks that. > Hive shouldn't use HBase's Base64 implementation > > > Key: HIVE-20201 > URL: https://issues.apache.org/jira/browse/HIVE-20201 > Project: Hive > Issue Type: Task > Components: HBase Handler >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Attachments: HIVE-20201.0.patch > > > HBase is removing their Base64 implementation because it never should have > been public, so Hive should switch to a different provider. Hive already uses > Commons-Codec Base64 in other places, so that would be a natural replacement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20201) Hive shouldn't use HBase's Base64 implementation
[ https://issues.apache.org/jira/browse/HIVE-20201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548265#comment-16548265 ] Naveen Gangam commented on HIVE-20201: -- Change looks good to me. +1 on the patch. I will wait for the pre-commits to run and then commit the fix. Thanks > Hive shouldn't use HBase's Base64 implementation > > > Key: HIVE-20201 > URL: https://issues.apache.org/jira/browse/HIVE-20201 > Project: Hive > Issue Type: Task > Components: HBase Handler >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Attachments: HIVE-20201.0.patch > > > HBase is removing their Base64 implementation because it never should have > been public, so Hive should switch to a different provider. Hive already uses > Commons-Codec Base64 in other places, so that would be a natural replacement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
