[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-27 Thread Alice Fan (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560070#comment-16560070
 ] 

Alice Fan commented on HIVE-20226:
--

Thank you [~ychena]!

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch, 
> HIVE-20226.3.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-27 Thread Yongzhi Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559820#comment-16559820
 ] 

Yongzhi Chen commented on HIVE-20226:
-

Committed the fix into master

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch, 
> HIVE-20226.3.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-26 Thread Yongzhi Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558877#comment-16558877
 ] 

Yongzhi Chen commented on HIVE-20226:
-

patch 3 looks good +1

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch, 
> HIVE-20226.3.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-26 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558850#comment-16558850
 ] 

Hive QA commented on HIVE-20226:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12933222/HIVE-20226.3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14813 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/12881/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12881/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12881/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12933222 - PreCommit-HIVE-Build

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch, 
> HIVE-20226.3.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-26 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558802#comment-16558802
 ] 

Hive QA commented on HIVE-20226:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
23s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
24s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 12s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12881/dev-support/hive-personality.sh
 |
| git revision | master / 2d097dc |
| Default Java | 1.8.0_111 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12881/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12881/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12881/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch, 
> HIVE-20226.3.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556433#comment-16556433
 ] 

Hive QA commented on HIVE-20226:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12933079/HIVE-20226.2.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/12862/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12862/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12862/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12933079/HIVE-20226.2.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12933079 - PreCommit-HIVE-Build

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556374#comment-16556374
 ] 

Hive QA commented on HIVE-20226:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12933079/HIVE-20226.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 14812 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands (batchId=202)
org.apache.hive.hcatalog.api.TestHCatClient.testDatabaseLocation (batchId=202)
org.apache.hive.hcatalog.api.TestHCatClient.testDropPartitionsWithPartialSpec 
(batchId=202)
org.apache.hive.hcatalog.api.TestHCatClient.testGetPartitionsWithPartialSpec 
(batchId=202)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/12860/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12860/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12860/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12933079 - PreCommit-HIVE-Build

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556334#comment-16556334
 ] 

Hive QA commented on HIVE-20226:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
14s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12860/dev-support/hive-personality.sh
 |
| git revision | master / 14bb840 |
| Default Java | 1.8.0_111 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12860/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12860/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12860/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch, HIVE-20226.2.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Alice Fan (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555969#comment-16555969
 ] 

Alice Fan commented on HIVE-20226:
--

Thanks [~ychena] I will include this into the change.

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Alice Fan (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555968#comment-16555968
 ] 

Alice Fan commented on HIVE-20226:
--

Thanks [~ychena] I will include this into the change.

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Yongzhi Chen (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555854#comment-16555854
 ] 

Yongzhi Chen commented on HIVE-20226:
-

We'd better let ConfVars.METASTORE_MAX_EVENT_RESPONSE be the new range size 
even when rqst.getMaxEvents() < 0 . Then we have centralized hive property to 
manage the maximum rows of events can be returned. 


> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1628#comment-1628
 ] 

Hive QA commented on HIVE-20226:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12932998/HIVE-20226.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14688 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse 
(batchId=228)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/12849/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12849/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12849/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12932998 - PreCommit-HIVE-Build

> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HIVE-20226) HMS getNextNotification will throw exception when request maxEvents exceed table's max_rows

2018-07-25 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555498#comment-16555498
 ] 

Hive QA commented on HIVE-20226:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
12s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
13s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 28s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12849/dev-support/hive-personality.sh
 |
| git revision | master / ca0d706 |
| Default Java | 1.8.0_111 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12849/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12849/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12849/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> HMS getNextNotification will throw exception when request maxEvents exceed 
> table's max_rows
> ---
>
> Key: HIVE-20226
> URL: https://issues.apache.org/jira/browse/HIVE-20226
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 3.0.0, 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20226.1.patch
>
>
> When Sentry call getNextNotification(), its request max_events will always be 
> Integer.MAX_VALUE.
> query.setRange(0, maxEvents) of ObjectStore will throw exception when 
> maxEvents exceed table's max_rows.
> Ex: assumed max_rows =  50,000,000 in a mysql table
> java.sql.SQLException: setMaxRows() out of range. 2147483647 > 5000.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)