[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[ https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578782#comment-16578782 ] Sergey Shelukhin commented on HIVE-20338: - [~gopalv] doesn't inode id guarantee immutability? I remember discussing with someone that it would change on append. > LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls > with POSIX mutation semantics > -- > > Key: HIVE-20338 > URL: https://issues.apache.org/jira/browse/HIVE-20338 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Priority: Major > > HDFS protocol does not guarantee immutability of files - the synthetic > file-id includes the mtime of the file as well, which is a fail-safe for such > filesystems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[ https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578809#comment-16578809 ] Gopal V commented on HIVE-20338: [~sershe]: this is true only for HDFS NameNodes. FYI - https://www.ibm.com/support/knowledgecenter/STXKQY_5.0.0/com.ibm.spectrum.scale.v5r00.doc/bl1adv_Overviewhdfs.htm > LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls > with POSIX mutation semantics > -- > > Key: HIVE-20338 > URL: https://issues.apache.org/jira/browse/HIVE-20338 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Priority: Major > Attachments: HIVE-20338.WIP.patch > > > HDFS protocol does not guarantee immutability of files - the synthetic > file-id includes the mtime of the file as well, which is a fail-safe for such > filesystems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[ https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583033#comment-16583033 ] Sergey Shelukhin commented on HIVE-20338: - If that is also not a guaranteed on HDFS, should we just never use inode ID for updatable files like text? So, only ORC + HDFS would ever use inode ID. And then I think some ORC files are also theoretically appendable (isn't that how merge works?) so to be safe we can never use it, at least by default. > LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls > with POSIX mutation semantics > -- > > Key: HIVE-20338 > URL: https://issues.apache.org/jira/browse/HIVE-20338 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-20338.WIP.patch > > > HDFS client protocol is not a guarantee of the immutability of files - the > synthetic file-id includes the mtime of the file as well, which is a > fail-safe for filesystems which implement the client wire protocol without > offering the same storage side restrictions on immutability (i.e allow NFS > read-write-modify on the backend). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[ https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594311#comment-16594311 ] Gopal V commented on HIVE-20338: [~sershe]: removed the extra config and defaults to synthetic file-ids if file-id paths are disabled. > LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls > with POSIX mutation semantics > -- > > Key: HIVE-20338 > URL: https://issues.apache.org/jira/browse/HIVE-20338 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20338.1.patch, HIVE-20338.WIP.patch, > HIVE-20338.patch > > > HDFS client protocol is not a guarantee of the immutability of files - the > synthetic file-id includes the mtime of the file as well, which is a > fail-safe for filesystems which implement the client wire protocol without > offering the same storage side restrictions on immutability (i.e allow NFS > read-write-modify on the backend). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[ https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594313#comment-16594313 ] Sergey Shelukhin commented on HIVE-20338: - Heh, so it basically becomes an "is HDFS" config. +1 > LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls > with POSIX mutation semantics > -- > > Key: HIVE-20338 > URL: https://issues.apache.org/jira/browse/HIVE-20338 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20338.1.patch, HIVE-20338.WIP.patch, > HIVE-20338.patch > > > HDFS client protocol is not a guarantee of the immutability of files - the > synthetic file-id includes the mtime of the file as well, which is a > fail-safe for filesystems which implement the client wire protocol without > offering the same storage side restrictions on immutability (i.e allow NFS > read-write-modify on the backend). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[
https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594472#comment-16594472
]
Hive QA commented on HIVE-20338:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} common in master has 64 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
45s{color} | {color:blue} llap-server in master has 84 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
9s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
21s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 2 new + 199 unchanged - 0
fixed = 201 total (was 199) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13497/dev-support/hive-personality.sh
|
| git revision | master / acc6fa2 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13497/yetus/patch-mvninstall-llap-server.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13497/yetus/diff-checkstyle-ql.txt
|
| modules | C: common llap-server ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13497/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls
> with POSIX mutation semantics
> --
>
> Key: HIVE-20338
> URL: https://issues.apache.org/jira/browse/HIVE-20338
> Project: Hive
> Issue Type: Bug
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-20338.1.patch, HIVE-20338.WIP.patch,
> HIVE-20338.patch
>
>
> HDFS client protocol is not a guarantee of the immutability of files - the
> synthetic file-id includes the mtime of the file as well, which is a
> fail-safe for filesystems which implement the client wire protocol without
[jira] [Commented] (HIVE-20338) LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls with POSIX mutation semantics
[
https://issues.apache.org/jira/browse/HIVE-20338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594493#comment-16594493
]
Hive QA commented on HIVE-20338:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12937347/HIVE-20338.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14897 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13497/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13497/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13497/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12937347 - PreCommit-HIVE-Build
> LLAP: Force synthetic file-id for filesystems which have HDFS protocol impls
> with POSIX mutation semantics
> --
>
> Key: HIVE-20338
> URL: https://issues.apache.org/jira/browse/HIVE-20338
> Project: Hive
> Issue Type: Bug
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
> Attachments: HIVE-20338.1.patch, HIVE-20338.WIP.patch,
> HIVE-20338.patch
>
>
> HDFS client protocol is not a guarantee of the immutability of files - the
> synthetic file-id includes the mtime of the file as well, which is a
> fail-safe for filesystems which implement the client wire protocol without
> offering the same storage side restrictions on immutability (i.e allow NFS
> read-write-modify on the backend).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
