[jira] [Commented] (HIVE-20345) Drop database may hang if the tables get deleted from a different call
[ https://issues.apache.org/jira/browse/HIVE-20345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578743#comment-16578743 ] Naveen Gangam commented on HIVE-20345: -- Looks good to me .. +1 > Drop database may hang if the tables get deleted from a different call > -- > > Key: HIVE-20345 > URL: https://issues.apache.org/jira/browse/HIVE-20345 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore >Affects Versions: 1.3.0, 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-20345.1.patch > > > In HiveMetaStore.java drop_database_core function, HIVE-11258 updates the > startIndex from endIndex incorrectly inside {{if (tables != null && > !tables.isEmpty())}} statement. If the tables get deleted before > getTableObjectsByName() call, then returned table list is empty and > startIndex won't get updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20345) Drop database may hang if the tables get deleted from a different call
[ https://issues.apache.org/jira/browse/HIVE-20345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574371#comment-16574371 ] Hive QA commented on HIVE-20345: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12934897/HIVE-20345.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14872 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13117/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13117/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13117/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12934897 - PreCommit-HIVE-Build > Drop database may hang if the tables get deleted from a different call > -- > > Key: HIVE-20345 > URL: https://issues.apache.org/jira/browse/HIVE-20345 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore >Affects Versions: 1.3.0, 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-20345.1.patch > > > In HiveMetaStore.java drop_database_core function, HIVE-11258 updates the > startIndex from endIndex incorrectly inside {{if (tables != null && > !tables.isEmpty())}} statement. If the tables get deleted before > getTableObjectsByName() call, then returned table list is empty and > startIndex won't get updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20345) Drop database may hang if the tables get deleted from a different call
[ https://issues.apache.org/jira/browse/HIVE-20345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574334#comment-16574334 ] Hive QA commented on HIVE-20345: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 15s{color} | {color:red} metastore-server in master failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 14s{color} | {color:red} metastore-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13117/dev-support/hive-personality.sh | | git revision | master / 873d31f | | Default Java | 1.8.0_111 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13117/yetus/branch-findbugs-standalone-metastore_metastore-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13117/yetus/patch-findbugs-standalone-metastore_metastore-server.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13117/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Drop database may hang if the tables get deleted from a different call > -- > > Key: HIVE-20345 > URL: https://issues.apache.org/jira/browse/HIVE-20345 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore >Affects Versions: 1.3.0, 2.0.0 >Reporter: Aihua Xu >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-20345.1.patch > > > In HiveMetaStore.java drop_database_core function, HIVE-11258 updates the > startIndex from endIndex incorrectly inside {{if (tables != null && > !tables.isEmpty())}} statement. If the tables get deleted before > getTableObjectsByName() call, then returned table list is empty and > startIndex won't get updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)