[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584580#comment-16584580
]
Hive QA commented on HIVE-20406:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12936065/HIVE-20406.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14885 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13312/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13312/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13312/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12936065 - PreCommit-HIVE-Build
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch, HIVE-20406.2.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584561#comment-16584561
]
Hive QA commented on HIVE-20406:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
39s{color} | {color:blue} serde in master has 195 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
3s{color} | {color:blue} ql in master has 2307 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13312/dev-support/hive-personality.sh
|
| git revision | master / 468907e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: serde itests ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13312/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch, HIVE-20406.2.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584488#comment-16584488
]
Ashutosh Chauhan commented on HIVE-20406:
-
+1 pending tests
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch, HIVE-20406.2.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583375#comment-16583375
]
Hive QA commented on HIVE-20406:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12935933/HIVE-20406.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14884 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test1]
(batchId=194)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[udf_coalesce]
(batchId=155)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13291/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13291/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13291/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12935933 - PreCommit-HIVE-Build
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583351#comment-16583351
]
Hive QA commented on HIVE-20406:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} serde in master has 195 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
10s{color} | {color:blue} ql in master has 2305 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13291/dev-support/hive-personality.sh
|
| git revision | master / 8c6b5c6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: serde itests ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13291/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583149#comment-16583149
]
Vineet Garg commented on HIVE-20406:
COALESCE(null) is typed void and during constant folding
JavaVoidObjectInspector.getPrimitiveWritableObject is called which in turn
calls NullWritable.get() to get to the object (null here) value. For some
reason it ends up returning {{(null)}} instead of {{null}. Therefore coalesce
ends up returning this "supposedly" non null value.
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Assignee: Vineet Garg
>Priority: Critical
> Attachments: HIVE-20406.1.patch
>
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20406) Nested Coalesce giving incorrect results
[
https://issues.apache.org/jira/browse/HIVE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582956#comment-16582956
]
Gopal V commented on HIVE-20406:
[~ashutoshc]: this looks like a Calcite/CBO issue.
> Nested Coalesce giving incorrect results
>
>
> Key: HIVE-20406
> URL: https://issues.apache.org/jira/browse/HIVE-20406
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 3.0.0
>Reporter: Riju Trivedi
>Priority: Critical
>
> Below query is returning NULL instead of 'TEST'
> select coalesce(coalesce(null), 'TEST');
> {noformat}
> INFO : OK
> +---+
> | _c0 |
> +---+
> | NULL |
> +---+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
