[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[ https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606254#comment-16606254 ] Andrew Sherman commented on HIVE-20437: --- +1 LGTM > Handle schema evolution from float, double and decimal > -- > > Key: HIVE-20437 > URL: https://issues.apache.org/jira/browse/HIVE-20437 > Project: Hive > Issue Type: Bug >Reporter: Janaki Lahorani >Assignee: Janaki Lahorani >Priority: Major > Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch, > HIVE-20437.3.patch > > > When data created as float, double or decimal in parquet format is read back > using some other type, errors are seen. Parquet should behave just like any > other format. If the value is valid for the new type, data is retuned > otherwise null has to be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[ https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606253#comment-16606253 ] Janaki Lahorani commented on HIVE-20437: The following test failure is not related to this patch: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf] (batchId=56) It can be seen for other runs as well. Also reproduces without this patch. > Handle schema evolution from float, double and decimal > -- > > Key: HIVE-20437 > URL: https://issues.apache.org/jira/browse/HIVE-20437 > Project: Hive > Issue Type: Bug >Reporter: Janaki Lahorani >Assignee: Janaki Lahorani >Priority: Major > Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch, > HIVE-20437.3.patch > > > When data created as float, double or decimal in parquet format is read back > using some other type, errors are seen. Parquet should behave just like any > other format. If the value is valid for the new type, data is retuned > otherwise null has to be returned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606031#comment-16606031
]
Hive QA commented on HIVE-20437:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12938636/HIVE-20437.3.patch
{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14930 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf]
(batchId=56)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13625/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13625/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13625/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12938636 - PreCommit-HIVE-Build
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch,
> HIVE-20437.3.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606028#comment-16606028
]
Hive QA commented on HIVE-20437:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
13s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13625/dev-support/hive-personality.sh
|
| git revision | master / 50d5bbb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: . ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13625/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch,
> HIVE-20437.3.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604097#comment-16604097
]
Hive QA commented on HIVE-20437:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12938374/HIVE-20437.2.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14927 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13596/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13596/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13596/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12938374 - PreCommit-HIVE-Build
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604075#comment-16604075
]
Hive QA commented on HIVE-20437:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
0s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13596/dev-support/hive-personality.sh
|
| git revision | master / 48f92c3 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: . ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13596/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch, HIVE-20437.2.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588729#comment-16588729
]
Hive QA commented on HIVE-20437:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12936565/HIVE-20437.1.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 14887 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedListColumnReader.testListReadEqualOneBatch
(batchId=287)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedListColumnReader.testListReadLessOneBatch
(batchId=287)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedListColumnReader.testListReadMoreOneBatch
(batchId=287)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedMapColumnReader.testMapReadEqualOneBatch
(batchId=288)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedMapColumnReader.testMapReadLessOneBatch
(batchId=288)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedMapColumnReader.testMapReadMoreOneBatch
(batchId=288)
org.apache.hive.hcatalog.pig.TestParquetHCatStorer.testDateCharTypes
(batchId=206)
org.apache.hive.hcatalog.pig.TestParquetHCatStorer.testWriteDecimal
(batchId=206)
org.apache.hive.hcatalog.pig.TestParquetHCatStorer.testWriteDecimalX
(batchId=206)
org.apache.hive.hcatalog.pig.TestParquetHCatStorer.testWriteDecimalXY
(batchId=206)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13393/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13393/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13393/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12936565 - PreCommit-HIVE-Build
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20437) Handle schema evolution from float, double and decimal
[
https://issues.apache.org/jira/browse/HIVE-20437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588719#comment-16588719
]
Hive QA commented on HIVE-20437:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
16s{color} | {color:blue} ql in master has 2308 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
32s{color} | {color:red} ql generated 1 new + 2308 unchanged - 0 fixed = 2309
total (was 2308) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 61m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Load of known null value in
org.apache.hadoop.hive.ql.io.parquet.convert.ETypeConverter$8.getConverter(PrimitiveType,
int, ConverterParent, TypeInfo) At ETypeConverter.java:in
org.apache.hadoop.hive.ql.io.parquet.convert.ETypeConverter$8.getConverter(PrimitiveType,
int, ConverterParent, TypeInfo) At ETypeConverter.java:[line 586] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13393/dev-support/hive-personality.sh
|
| git revision | master / 25e747f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13393/yetus/new-findbugs-ql.html
|
| modules | C: . ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13393/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Handle schema evolution from float, double and decimal
> --
>
> Key: HIVE-20437
> URL: https://issues.apache.org/jira/browse/HIVE-20437
> Project: Hive
> Issue Type: Bug
>Reporter: Janaki Lahorani
>Assignee: Janaki Lahorani
>Priority: Major
> Attachments: HIVE-20437.1.patch
>
>
> When data created as float, double or decimal in parquet format is read back
> using some other type, errors are seen. Parquet should behave just like any
> other format. If the value is valid for the new type, data is retuned
> otherwise null has to be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
