[jira] [Commented] (HIVE-20598) Fix typos in HiveAlgorithmsUtil calculations
[ https://issues.apache.org/jira/browse/HIVE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622252#comment-16622252 ] Ashutosh Chauhan commented on HIVE-20598: - +1 > Fix typos in HiveAlgorithmsUtil calculations > > > Key: HIVE-20598 > URL: https://issues.apache.org/jira/browse/HIVE-20598 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-20598.01.patch > > > HIVE-10343 have made the costs changeable by hiveconf settings; however there > was a method in which there was already a local variable named > cpuCostbottom line is the cost of n-way joins calculated by this method > is computed as the product of the number of rows... > https://github.com/apache/hive/blob/9c907769a63a6b23c91fdf0b3f3d0aa6387035dc/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java#L83 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20598) Fix typos in HiveAlgorithmsUtil calculations
[ https://issues.apache.org/jira/browse/HIVE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621703#comment-16621703 ] Zoltan Haindrich commented on HIVE-20598: - [~ashutoshc] Could you please take a look? > Fix typos in HiveAlgorithmsUtil calculations > > > Key: HIVE-20598 > URL: https://issues.apache.org/jira/browse/HIVE-20598 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-20598.01.patch > > > HIVE-10343 have made the costs changeable by hiveconf settings; however there > was a method in which there was already a local variable named > cpuCostbottom line is the cost of n-way joins calculated by this method > is computed as the product of the number of rows... > https://github.com/apache/hive/blob/9c907769a63a6b23c91fdf0b3f3d0aa6387035dc/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java#L83 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20598) Fix typos in HiveAlgorithmsUtil calculations
[
https://issues.apache.org/jira/browse/HIVE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621542#comment-16621542
]
Hive QA commented on HIVE-20598:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940430/HIVE-20598.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14992 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13922/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13922/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13922/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12940430 - PreCommit-HIVE-Build
> Fix typos in HiveAlgorithmsUtil calculations
>
>
> Key: HIVE-20598
> URL: https://issues.apache.org/jira/browse/HIVE-20598
> Project: Hive
> Issue Type: Bug
> Components: Logical Optimizer
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20598.01.patch
>
>
> HIVE-10343 have made the costs changeable by hiveconf settings; however there
> was a method in which there was already a local variable named
> cpuCostbottom line is the cost of n-way joins calculated by this method
> is computed as the product of the number of rows...
> https://github.com/apache/hive/blob/9c907769a63a6b23c91fdf0b3f3d0aa6387035dc/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java#L83
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20598) Fix typos in HiveAlgorithmsUtil calculations
[
https://issues.apache.org/jira/browse/HIVE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621514#comment-16621514
]
Hive QA commented on HIVE-20598:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
59s{color} | {color:blue} ql in master has 2326 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} ql: The patch generated 0 new + 71 unchanged - 2
fixed = 71 total (was 73) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13922/dev-support/hive-personality.sh
|
| git revision | master / ee5566b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13922/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix typos in HiveAlgorithmsUtil calculations
>
>
> Key: HIVE-20598
> URL: https://issues.apache.org/jira/browse/HIVE-20598
> Project: Hive
> Issue Type: Bug
> Components: Logical Optimizer
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20598.01.patch
>
>
> HIVE-10343 have made the costs changeable by hiveconf settings; however there
> was a method in which there was already a local variable named
> cpuCostbottom line is the cost of n-way joins calculated by this method
> is computed as the product of the number of rows...
> https://github.com/apache/hive/blob/9c907769a63a6b23c91fdf0b3f3d0aa6387035dc/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java#L83
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20598) Fix typos in HiveAlgorithmsUtil calculations
[ https://issues.apache.org/jira/browse/HIVE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620594#comment-16620594 ] Zoltan Haindrich commented on HIVE-20598: - there were a few more...in which cases it might have multiplied by 0 > Fix typos in HiveAlgorithmsUtil calculations > > > Key: HIVE-20598 > URL: https://issues.apache.org/jira/browse/HIVE-20598 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-20598.01.patch > > > HIVE-10343 have made the costs changeable by hiveconf settings; however there > was a method in which there was already a local variable named > cpuCostbottom line is the cost of n-way joins calculated by this method > is computed as the product of the number of rows... > https://github.com/apache/hive/blob/9c907769a63a6b23c91fdf0b3f3d0aa6387035dc/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java#L83 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
