[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833498#comment-16833498 ] Hive QA commented on HIVE-20613: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12967882/HIVE-20613.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15980 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17126/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17126/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17126/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12967882 - PreCommit-HIVE-Build > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch, > HIVE-20613.2.patch, HIVE-20613.3.patch, HIVE-20613.4.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833482#comment-16833482 ] Hive QA commented on HIVE-20613: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 11s{color} | {color:blue} standalone-metastore/metastore-server in master has 182 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 19s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 23 new + 179 unchanged - 9 fixed = 202 total (was 188) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 18s{color} | {color:green} standalone-metastore/metastore-server generated 0 new + 181 unchanged - 1 fixed = 181 total (was 182) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 32s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17126/dev-support/hive-personality.sh | | git revision | master / aebfaad | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17126/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-17126/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17126/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch, > HIVE-20613.2.patch, HIVE-20613.3.patch, HIVE-20613.4.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833469#comment-16833469 ] Hive QA commented on HIVE-20613: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12967881/HIVE-20613.3.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17125/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17125/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17125/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-05-05 22:25:44.638 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-17125/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-05-05 22:25:44.642 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at aebfaad HIVE-20615: CachedStore: Background refresh thread bug fixes (Vaibhav Gumashta, reviewed by Daniel Dai) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at aebfaad HIVE-20615: CachedStore: Background refresh thread bug fixes (Vaibhav Gumashta, reviewed by Daniel Dai) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-05-05 22:25:45.607 + rm -rf ../yetus_PreCommit-HIVE-Build-17125 + mkdir ../yetus_PreCommit-HIVE-Build-17125 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-17125 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-17125/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java: does not exist in index error: a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java: does not exist in index Going to apply patch with: git apply -p1 /data/hiveptest/working/scratch/build.patch:215: trailing whitespace. } /data/hiveptest/working/scratch/build.patch:837: trailing whitespace. // Note: the 44Kb approximation has been determined based on trial/error. /data/hiveptest/working/scratch/build.patch:902: trailing whitespace. // Create a new unpartitioned table under basedb1 /data/hiveptest/working/scratch/build.patch:1198: trailing whitespace. // Create a new unpartitioned table under db1 /data/hiveptest/working/scratch/build.patch:1288: trailing whitespace. // Note: the 44Kb approximation has been determined based on trial/error. warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors. + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc1775397990093280147.exe, --version] libprotoc 2.5.0 protoc-jar: executing: [/tmp/protoc1775397990093280147.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713281#comment-16713281 ] Hive QA commented on HIVE-20613: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12951003/HIVE-20613.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15667 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15215/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15215/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15215/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12951003 - PreCommit-HIVE-Build > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch, > HIVE-20613.2.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713237#comment-16713237 ] Hive QA commented on HIVE-20613: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 2s{color} | {color:blue} standalone-metastore/metastore-server in master has 184 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 14 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 6s{color} | {color:green} standalone-metastore/metastore-server generated 0 new + 183 unchanged - 1 fixed = 183 total (was 184) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15215/dev-support/hive-personality.sh | | git revision | master / aae392f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15215/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15215/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch, > HIVE-20613.2.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673976#comment-16673976 ] Hive QA commented on HIVE-20613: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12946631/HIVE-20613.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15526 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=196) [druidmini_masking.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_joins.q,druid_timestamptz.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14719/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14719/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14719/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12946631 - PreCommit-HIVE-Build > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673961#comment-16673961 ] Hive QA commented on HIVE-20613: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 6s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 14 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 11s{color} | {color:green} standalone-metastore/metastore-server generated 0 new + 184 unchanged - 1 fixed = 184 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 42s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14719/dev-support/hive-personality.sh | | git revision | master / f3fab45 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14719/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14719/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672551#comment-16672551 ] Daniel Dai commented on HIVE-20613: --- +1 > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch, HIVE-20613.2.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659836#comment-16659836 ] Daniel Dai commented on HIVE-20613: --- [~vgumashta], can you create a review board? > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649326#comment-16649326 ] Hive QA commented on HIVE-20613: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12943716/HIVE-20613.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15088 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14435/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14435/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14435/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12943716 - PreCommit-HIVE-Build > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20613) CachedStore: Add more UT coverage (outside of .q files)
[ https://issues.apache.org/jira/browse/HIVE-20613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649309#comment-16649309 ] Hive QA commented on HIVE-20613: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 6s{color} | {color:blue} standalone-metastore/metastore-server in master has 182 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 12s{color} | {color:green} standalone-metastore/metastore-server generated 0 new + 181 unchanged - 1 fixed = 181 total (was 182) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14435/dev-support/hive-personality.sh | | git revision | master / 3527842 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14435/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14435/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > CachedStore: Add more UT coverage (outside of .q files) > --- > > Key: HIVE-20613 > URL: https://issues.apache.org/jira/browse/HIVE-20613 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20613.1.patch > > > 1. Add tests which will use the background thread for updating the cached > data (database, table, partition, table stats, partition stats) > 2. Add more tests for existing APIs: stats aggregation, listing partitions > when partial specs are provided, testing the storage descriptor > caching/deduplication (specially when tables/ptns are dropped/added), table > col stats, partition col stats > 3. Test 1. in a multithreaded scenario > 4. Test whitelist/blacklist > 5. Test prewarm memory limit estimation code -- This message was sent by Atlassian JIRA (v7.6.3#76005)