[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638976#comment-16638976
]
Hive QA commented on HIVE-20678:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} hbase-handler: The patch generated 8 new + 6 unchanged
- 1 fixed = 14 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} hbase-handler generated 0 new + 7 unchanged - 6
fixed = 7 total (was 13) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14237/dev-support/hive-personality.sh
|
| git revision | master / fe3a457 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14237/yetus/diff-checkstyle-hbase-handler.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14237/yetus/patch-asflicense-problems.txt
|
| modules | C: hbase-handler U: hbase-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14237/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639027#comment-16639027
]
Hive QA commented on HIVE-20678:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12942357/HIVE-20678.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15026 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stat_estimate_related_col]
(batchId=43)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14237/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14237/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14237/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12942357 - PreCommit-HIVE-Build
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639258#comment-16639258 ] Alice Fan commented on HIVE-20678: -- Submit patch 2 to improve style errors. > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639269#comment-16639269 ] Alice Fan commented on HIVE-20678: -- Hi [~ychena] [~ngangam], Could you please help to review this? Thanks! > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639441#comment-16639441 ] Alice Fan commented on HIVE-20678: -- stat_estimate_related_col.q is irrelevant to my change. Tested it locally and it passed. > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639847#comment-16639847
]
Yongzhi Chen commented on HIVE-20678:
-
Do we still need implement the method?
public org.apache.hadoop.mapred.RecordWriter
getRecordWriter(
And do we still need implement mapred.RecordWriter in the MyRecordWriter?
static private class MyRecordWriter
implements org.apache.hadoop.mapred.RecordWriter,
org.apache.hadoop.hive.ql.exec.FileSinkOperator.RecordWriter {
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640319#comment-16640319
]
Hive QA commented on HIVE-20678:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
31s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} hbase-handler: The patch generated 1 new + 6 unchanged
- 1 fixed = 7 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} hbase-handler generated 0 new + 7 unchanged - 6
fixed = 7 total (was 13) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14259/dev-support/hive-personality.sh
|
| git revision | master / 159305a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14259/yetus/diff-checkstyle-hbase-handler.txt
|
| modules | C: hbase-handler U: hbase-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14259/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640333#comment-16640333 ] Alice Fan commented on HIVE-20678: -- Thanks [~ychena] very much for reviewing the patch. Because HiveOutputFormat is an interface extends interface OutputFormat. As HiveHBaseTableOutputFormat is going to implement HiveOutputFormat, so we will have to implements methods for both interfaces, which are getHiveRecordWriter() and getRecordWriter(). Let me know if you have any other feedback to help to improve the patch :) Thanks! > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640374#comment-16640374
]
Hive QA commented on HIVE-20678:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12942514/HIVE-20678.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15026 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14259/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14259/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14259/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12942514 - PreCommit-HIVE-Build
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641221#comment-16641221
]
Hive QA commented on HIVE-20678:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} hbase-handler: The patch generated 0 new + 6
unchanged - 1 fixed = 6 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} hbase-handler generated 0 new + 7 unchanged - 6
fixed = 7 total (was 13) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14299/dev-support/hive-personality.sh
|
| git revision | master / 827f4f9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14299/yetus/patch-asflicense-problems.txt
|
| modules | C: hbase-handler U: hbase-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14299/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch,
> HIVE-20678.4.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641230#comment-16641230
]
Hive QA commented on HIVE-20678:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12942718/HIVE-20678.4.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15031 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.testPigPopulation
(batchId=260)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14299/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14299/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14299/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12942718 - PreCommit-HIVE-Build
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch,
> HIVE-20678.4.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641701#comment-16641701 ] Yongzhi Chen commented on HIVE-20678: - The hcatalog still need old OutputFormat, so we can not deprecate the implementation from HiveHBaseTableOutputFormat for now. +1 for patch change 2 > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642208#comment-16642208 ] Alice Fan commented on HIVE-20678: -- Submitted patch 5 which is identical to patch 2 and just improved javadoc style for TestHiveHBaseTableOutputFormat.java. > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch, HIVE-20678.5.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643655#comment-16643655
]
Hive QA commented on HIVE-20678:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
31s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} hbase-handler: The patch generated 0 new + 6
unchanged - 1 fixed = 6 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} hbase-handler generated 0 new + 7 unchanged - 6
fixed = 7 total (was 13) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14331/dev-support/hive-personality.sh
|
| git revision | master / 717a15b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: hbase-handler U: hbase-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14331/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch,
> HIVE-20678.4.patch, HIVE-20678.5.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[
https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643714#comment-16643714
]
Hive QA commented on HIVE-20678:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12942860/HIVE-20678.5.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15064 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14331/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14331/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14331/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12942860 - PreCommit-HIVE-Build
> HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
>
>
> Key: HIVE-20678
> URL: https://issues.apache.org/jira/browse/HIVE-20678
> Project: Hive
> Issue Type: Bug
> Components: HBase Handler, Hive, Spark
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch,
> HIVE-20678.4.patch, HIVE-20678.5.patch
>
>
> This issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems
> to be abandoned, so create this one to resolve the issue.
> HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will
> break the compatibility in spark's API when it is using hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643721#comment-16643721 ] Ruslan Dautkhanov commented on HIVE-20678: -- Thank you [~afan]! Would it be possible to backport to Hive 1.2 / CDH 5.14? > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch, HIVE-20678.5.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643737#comment-16643737 ] Yongzhi Chen commented on HIVE-20678: - +1 for patch 5 > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch, HIVE-20678.5.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644098#comment-16644098 ] Alice Fan commented on HIVE-20678: -- Hi [~Tagar], I will let support to reply you the current status/plan via internal csh. Thank you. > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch, HIVE-20678.5.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility
[ https://issues.apache.org/jira/browse/HIVE-20678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645438#comment-16645438 ] Alice Fan commented on HIVE-20678: -- Thank you [~ychena]. > HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure > compatibility > > > Key: HIVE-20678 > URL: https://issues.apache.org/jira/browse/HIVE-20678 > Project: Hive > Issue Type: Bug > Components: HBase Handler, Hive, Spark >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20678.1.patch, HIVE-20678.2.patch, > HIVE-20678.4.patch, HIVE-20678.5.patch > > > This issue was caused by same reason described in > https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems > to be abandoned, so create this one to resolve the issue. > HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will > break the compatibility in spark's API when it is using hive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
