[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724532#comment-16724532 ] ASF GitHub Bot commented on HIVE-20785: --- Github user Mogztter closed the pull request at: https://github.com/apache/hive/pull/440 > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-20785.1.patch, patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723535#comment-16723535 ] Hive QA commented on HIVE-20785: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12952095/HIVE-20785.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15728 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15357/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15357/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15357/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12952095 - PreCommit-HIVE-Build > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: HIVE-20785.1.patch, patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723507#comment-16723507 ] Hive QA commented on HIVE-20785: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} service in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} service: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 23s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15357/dev-support/hive-personality.sh | | git revision | master / 4d9df0f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15357/yetus/diff-checkstyle-service.txt | | modules | C: service U: service | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15357/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: HIVE-20785.1.patch, patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723465#comment-16723465 ] Prasanth Jayachandran commented on HIVE-20785: -- {code:java} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_groupby_reduce] (batchId=61) org.apache.hadoop.hive.common.metrics.metrics2.TestCodahaleMetrics.testFileReporting (batchId=282){code} These 2 test failures seems to be unrelated. Giving the patch another try to see if the tests are flaky. > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: HIVE-20785.1.patch, patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722944#comment-16722944 ] Hive QA commented on HIVE-20785: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12952021/patch.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15352/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15352/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15352/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12952021/patch.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12952021 - PreCommit-HIVE-Build > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722942#comment-16722942 ] Hive QA commented on HIVE-20785: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12952021/patch.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15724 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_groupby_reduce] (batchId=61) org.apache.hadoop.hive.common.metrics.metrics2.TestCodahaleMetrics.testFileReporting (batchId=282) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15351/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15351/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15351/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12952021 - PreCommit-HIVE-Build > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722901#comment-16722901 ] Hive QA commented on HIVE-20785: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 35s{color} | {color:blue} service in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} service: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 35s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15351/dev-support/hive-personality.sh | | git revision | master / 4e41560 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15351/yetus/diff-checkstyle-service.txt | | modules | C: service U: service | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15351/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20785) Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method
[ https://issues.apache.org/jira/browse/HIVE-20785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722632#comment-16722632 ] Hive QA commented on HIVE-20785: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12951971/patch.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15347/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15347/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15347/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-12-17 01:24:37.053 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-15347/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-12-17 01:24:37.056 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 4e41560 HIVE-21030 : Add credential store env properties redaction in JobConf (Denys Kuzmenko reviewed by Vihang Karajgaonkar) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 4e41560 HIVE-21030 : Add credential store env properties redaction in JobConf (Denys Kuzmenko reviewed by Vihang Karajgaonkar) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-12-17 01:24:38.922 + rm -rf ../yetus_PreCommit-HIVE-Build-15347 + mkdir ../yetus_PreCommit-HIVE-Build-15347 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-15347 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15347/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch fatal: corrupt patch at line 25 fatal: corrupt patch at line 25 fatal: corrupt patch at line 25 The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-15347 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12951971 - PreCommit-HIVE-Build > Wrong key name in the JDBC DatabaseMetaData.getPrimaryKeys method > - > > Key: HIVE-20785 > URL: https://issues.apache.org/jira/browse/HIVE-20785 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Guillaume Grossetie >Assignee: Guillaume Grossetie >Priority: Major > Attachments: 20785.patch, 20785.patch, patch.patch > > > According to the documentation (1) the key should be {{KEY_SEQ, not KEQ_SEQ.}} > Pull request available: https://github.com/apache/hive/pull/440 > > (1) > [https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys-java.lang.String-java.lang.String-java.lang.String-] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)