[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765829#comment-16765829 ] Abhishek Somani commented on HIVE-20823: [~ekoifman], [~vgumashta] Is there a plan to backport this to the 3.x branch? > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch, > HIVE-20823.13.patch, HIVE-20823.14.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695314#comment-16695314 ] Vaibhav Gumashta commented on HIVE-20823: - +1 > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch, > HIVE-20823.13.patch, HIVE-20823.14.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692566#comment-16692566 ] Eugene Koifman commented on HIVE-20823: --- no related failures > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch, > HIVE-20823.13.patch, HIVE-20823.14.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692561#comment-16692561 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12948780/HIVE-20823.14.patch {color:green}SUCCESS:{color} +1 due to 22 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15531 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=196) [druidmini_dynamic_partition.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_test_insert.q,druidkafkamini_delimited.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14998/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14998/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14998/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12948780 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch, > HIVE-20823.13.patch, HIVE-20823.14.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692550#comment-16692550 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 22s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 15s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 2s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 38s{color} | {color:blue} ql in master has 2317 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 36s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 49s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 59s{color} | {color:red} ql: The patch generated 76 new + 2433 unchanged - 54 fixed = 2509 total (was 2487) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} streaming: The patch generated 0 new + 455 unchanged - 1 fixed = 455 total (was 456) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 11 new + 347 unchanged - 14 fixed = 358 total (was 361) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 9s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 57s{color} | {color:red} ql generated 1 new + 2316 unchanged - 1 fixed = 2317 total (was 2317) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} |
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687491#comment-16687491 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12948238/HIVE-20823.13.patch {color:green}SUCCESS:{color} +1 due to 21 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15537 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithOpenInMiddle (batchId=294) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorWithOpenInMiddle (batchId=294) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14936/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14936/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14936/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12948238 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch, > HIVE-20823.13.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687474#comment-16687474 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 3s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 21s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 16s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 25s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 39s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 1s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 51s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s{color} | {color:red} itests/hive-unit: The patch generated 16 new + 347 unchanged - 14 fixed = 363 total (was 361) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 0s{color} | {color:red} ql: The patch generated 90 new + 2410 unchanged - 51 fixed = 2500 total (was 2461) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} streaming: The patch generated 2 new + 455 unchanged - 1 fixed = 457 total (was 456) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 51s{color} | {color:red} ql generated 1 new + 2315 unchanged - 1 fixed = 2316 total (was 2316) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 11s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green}
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687259#comment-16687259 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12948208/HIVE-20823.12.patch {color:green}SUCCESS:{color} +1 due to 21 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 15536 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCompactStatsGather (batchId=308) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCompactStatsGather (batchId=308) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[0] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[1] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[0] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[1] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[0] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[1] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[0] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[1] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[0] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[1] (batchId=244) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithOpenInMiddle (batchId=294) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorWithOpenInMiddle (batchId=294) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14930/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14930/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14930/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 15 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12948208 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch, HIVE-20823.12.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687246#comment-16687246 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 8s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 9s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 36s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 41s{color} | {color:blue} ql in master has 2317 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 0s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 3s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 53s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 13 new + 348 unchanged - 13 fixed = 361 total (was 361) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 2s{color} | {color:red} ql: The patch generated 90 new + 2410 unchanged - 51 fixed = 2500 total (was 2461) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} streaming: The patch generated 2 new + 455 unchanged - 1 fixed = 457 total (was 456) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 51s{color} | {color:red} ql generated 1 new + 2316 unchanged - 1 fixed = 2317 total (was 2317) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 9s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green}
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684847#comment-16684847 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14905/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14905/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14905/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12947931 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684845#comment-16684845 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14904/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14904/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14904/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12947931 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684745#comment-16684745 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch {color:green}SUCCESS:{color} +1 due to 20 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 28 failed/errored test(s), 15531 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=196) [druidmini_masking.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_joins.q,druid_timestamptz.q] org.apache.hadoop.hive.ql.TestTxnCommands.testNonAcidToAcidConversion01 (batchId=323) org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCompactStatsGather (batchId=307) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCompactStatsGather (batchId=307) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableNoBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithOpenInMiddle (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorPartitionWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithOpenInMiddle (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorTableNoBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.majorWithOpenInMiddle (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorPartitionWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorWithOpenInMiddle (batchId=293) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14900/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14900/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14900/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 28 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12947931 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch, > HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, > HIVE-20823.11.patch, HIVE-20823.11.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > #
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684733#comment-16684733 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 11s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 35s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 46s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 4s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 54s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 10 new + 179 unchanged - 10 fixed = 189 total (was 189) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 56s{color} | {color:red} ql: The patch generated 88 new + 2410 unchanged - 51 fixed = 2498 total (was 2461) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} streaming: The patch generated 2 new + 455 unchanged - 1 fixed = 457 total (was 456) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 51s{color} | {color:red} ql generated 1 new + 2315 unchanged - 1 fixed = 2316 total (was 2316) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 10s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green}
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682791#comment-16682791 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947727/HIVE-20823.09.patch {color:green}SUCCESS:{color} +1 due to 15 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 67 failed/errored test(s), 15531 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) org.apache.hadoop.hive.ql.TestAcidOnTez.testInsertWithRemoveUnion (batchId=242) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3 (batchId=307) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion3 (batchId=319) org.apache.hadoop.hive.ql.TestTxnCommandsWithSplitUpdateAndVectorization.testNonAcidToAcidConversion01 (batchId=307) org.apache.hadoop.hive.ql.TestTxnConcatenate.testConcatenate (batchId=292) org.apache.hadoop.hive.ql.TestTxnConcatenate.testConcatenatePart (batchId=292) org.apache.hadoop.hive.ql.TestTxnExIm.testImport (batchId=305) org.apache.hadoop.hive.ql.TestTxnExIm.testImportNoTarget (batchId=305) org.apache.hadoop.hive.ql.TestTxnLoadData.loadData (batchId=283) org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataNonAcid2AcidConversion (batchId=283) org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataUpdate (batchId=283) org.apache.hadoop.hive.ql.TestTxnLoadData.testMultiStatement (batchId=283) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testNoBuckets (batchId=307) org.apache.hadoop.hive.ql.io.TestAcidUtils.deleteDeltasWithOpenTxnInRead (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead2 (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testParsing (batchId=294) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithInsertsAndDeletes[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testMinorCompactionForSplitUpdateWithOnlyInserts[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorNoBaseLotsOfDeltas (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorPartitionWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorPartitionWithBaseMissingBuckets (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableLegacy (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableNoBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorTableWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithAborted (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.majorWithOpenInMiddle (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorNoBaseLotsOfDeltas (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorPartitionWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableLegacy (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableNoBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorTableWithBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestWorker.minorWithAborted (batchId=293)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682783#comment-16682783 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 40s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 14s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 39s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 4s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 27s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 49s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 58s{color} | {color:red} ql: The patch generated 82 new + 2367 unchanged - 23 fixed = 2449 total (was 2390) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} streaming: The patch generated 2 new + 455 unchanged - 1 fixed = 457 total (was 456) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 48s{color} | {color:red} ql generated 1 new + 2315 unchanged - 1 fixed = 2316 total (was 2316) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 11s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s{color} | {color:green} storage-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s{color} | {color:green} standalone-metastore_metastore-common generated 0 new + 16 unchanged - 1 fixed = 16 total (was 17) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} streaming in
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682676#comment-16682676 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947716/HIVE-20823.08.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14867/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14867/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14867/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-11-11 00:02:01.369 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-14867/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-11-11 00:02:01.372 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 7ae4a2c HIVE-20833: package.jdo needs to be updated to conform with HIVE-20221 changes (Vineet Garg, reviewed by Jason Dere) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 7ae4a2c HIVE-20833: package.jdo needs to be updated to conform with HIVE-20221 changes (Vineet Garg, reviewed by Jason Dere) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-11-11 00:02:02.190 + rm -rf ../yetus_PreCommit-HIVE-Build-14867 + mkdir ../yetus_PreCommit-HIVE-Build-14867 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-14867 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-14867/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: git apply -p0 + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc907441325743139.exe, --version] libprotoc 2.5.0 protoc-jar: executing: [/tmp/protoc907441325743139.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (process-resource-bundles) on project hive-pre-upgrade: Execution process-resource-bundles of goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process failed. ConcurrentModificationException -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :hive-pre-upgrade + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-14867 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12947716 - PreCommit-HIVE-Build > Make Compactor run in a transaction >
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681203#comment-16681203 ] Abhishek Somani commented on HIVE-20823: [~ekoifman] is this expected to solve https://issues.apache.org/jira/browse/HIVE-20392 as well? > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680785#comment-16680785 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947316/HIVE-20823.07.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14823/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14823/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14823/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12947316/HIVE-20823.07.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12947316 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680783#comment-16680783 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947316/HIVE-20823.07.patch {color:green}SUCCESS:{color} +1 due to 12 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15521 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestCatalogNonDefaultClient.tablesList (batchId=221) org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=320) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14822/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14822/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14822/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12947316 - PreCommit-HIVE-Build > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch, HIVE-20823.07.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680761#comment-16680761 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 16s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 45s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 7s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 35s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 54s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 53s{color} | {color:red} ql: The patch generated 47 new + 1769 unchanged - 13 fixed = 1816 total (was 1782) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} streaming: The patch generated 2 new + 455 unchanged - 1 fixed = 457 total (was 456) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 56s{color} | {color:red} ql generated 1 new + 2314 unchanged - 1 fixed = 2315 total (was 2315) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 13s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} storage-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} standalone-metastore_metastore-common generated 0 new + 16 unchanged - 1 fixed = 16 total (was 17) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} streaming in
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679133#comment-16679133 ] Eugene Koifman commented on HIVE-20823: --- patch 5 bunch more test fixes and some real (Replication) fixes > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, > HIVE-20823.04.patch, HIVE-20823.05.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678703#comment-16678703 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947174/HIVE-20823.04.patch {color:green}SUCCESS:{color} +1 due to 10 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 55 failed/errored test(s), 15520 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=320) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable (batchId=283) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable (batchId=305) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidBootstrapReplLoadRetryAfterFailure (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrap (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentWrites (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithOpenTxnsTimeout (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationBootStrap (batchId=250) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidBootstrapReplLoadRetryAfterFailure (batchId=247) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrap (batchId=247) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithConcurrentWrites (batchId=247) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithOpenTxnsTimeout (batchId=247) org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesMoveOptimizationBootStrap (batchId=247) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningDelete[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningDelete[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningInsert[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningInsert[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningInsert[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningInsert[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningUpdate[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningUpdate[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties[0] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties[1] (batchId=243) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.chooseMajorOverMinorWhenBothValid (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactPartitionHighDeltaPct (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactPartitionTooManyDeltas (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactTableHighDeltaPct (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactTableTooManyDeltas (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.enoughDeltasNoBase (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableDeltaPctNotHighEnough (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableNotEnoughDeltas (batchId=293) org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.twoTxnsOnSamePartitionGenerateOneCompactionRequest (batchId=293) org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbortAndCommit (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Delimited (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_DelimitedUGI (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json (batchId=217) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Regex (batchId=217)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678670#comment-16678670 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 25s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 15s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 44s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 5s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 49s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} storage-api: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 7s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 50s{color} | {color:red} ql: The patch generated 42 new + 1633 unchanged - 13 fixed = 1675 total (was 1646) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 50s{color} | {color:red} ql generated 1 new + 2314 unchanged - 1 fixed = 2315 total (was 2315) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 12s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 7s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 8s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.txn.compactor.Cleaner.clean(CompactionInfo, long) At Cleaner.java:is not thrown in org.apache.hadoop.hive.ql.txn.compactor.Cleaner.clean(CompactionInfo, long) At Cleaner.java:[line 210] | | FindBugs | module:standalone-metastore/metastore-server | | | org.apache.hadoop.hive.metastore.txn.CompactionTxnHandler.findMinOpenTxnGLB(Statement) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at CompactionTxnHandler.java:up java.sql.ResultSet Obligation to clean up resource created at CompactionTxnHandler.java:[line 356] is not
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674260#comment-16674260 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12946771/HIVE-20823.03.patch {color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 95 failed/errored test(s), 15513 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=195) [druidmini_dynamic_partition.q,druidmini_test_ts.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test_insert.q] org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId (batchId=307) org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner (batchId=307) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId (batchId=319) org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.writeBetweenWorkerAndCleaner (batchId=319) org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=320) org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable (batchId=283) org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable (batchId=305) org.apache.hadoop.hive.ql.io.TestAcidUtils.deleteDeltasWithOpenTxnInRead (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasAndDeleteDeltasWithOpenTxnsNotInCompact (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead2 (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnsNotInCompact (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnsNotInCompact2 (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testBaseDeltas (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testBaseWithDeleteDeltas (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testMinorCompactedDeltaMakesInBetweenDelteDeltaObsolete (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testObsoleteOriginals (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testOriginalDeltas (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDelta (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDelta2 (batchId=294) org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDeltaAndDeleteDelta (batchId=294) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderFooterSerializeWithDeltas (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderNoFooterSerializeWithDeltas (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDSplitStrategy (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDSplitStrategyForSplitUpdate (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testCombinationInputFormatWithAcid (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testEtlCombinedStrategy (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testFSCallsVectorizedOrcAcidRowBatchReader (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testVectorizationWithAcid (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testEmpty (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testNewBaseAndDelta (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderDelta (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderIncompleteDelta (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderNewBaseAndDelta (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderOldBaseAndDelta (batchId=298) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOff (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOff2 (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOn (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOn2 (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventOriginalFilteringOff (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventOriginalFilteringOn (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testVectorizedOrcAcidRowBatchReader (batchId=297) org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidBootstrapReplLoadRetryAfterFailure
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674256#comment-16674256 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 16s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 36s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 2s{color} | {color:blue} standalone-metastore/metastore-server in master has 185 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 49s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} storage-api: The patch generated 0 new + 16 unchanged - 2 fixed = 16 total (was 18) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-common passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 49s{color} | {color:red} ql: The patch generated 28 new + 1274 unchanged - 12 fixed = 1302 total (was 1286) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 6s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 55s{color} | {color:red} ql generated 1 new + 2314 unchanged - 1 fixed = 2315 total (was 2315) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 10s{color} | {color:red} standalone-metastore/metastore-server generated 1 new + 184 unchanged - 1 fixed = 185 total (was 185) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 15s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.txn.compactor.Cleaner.clean(CompactionInfo, long) At Cleaner.java:is not thrown in org.apache.hadoop.hive.ql.txn.compactor.Cleaner.clean(CompactionInfo, long) At Cleaner.java:[line 203] | | FindBugs | module:standalone-metastore/metastore-server | | | org.apache.hadoop.hive.metastore.txn.CompactionTxnHandler.findMinOpenTxnGLB(Statement) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at CompactionTxnHandler.java:up java.sql.ResultSet Obligation to clean up resource created at CompactionTxnHandler.java:[line 356] is not
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671063#comment-16671063 ] Hive QA commented on HIVE-20823: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12946143/HIVE-20823.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 654 failed/errored test(s), 15490 tests executed *Failed tests:* {noformat} TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=180) [tez_union_group_by.q,vector_like_2.q,llap_acid.q,sqlmerge.q,vector_udf_character_length.q,tez_dynpart_hashjoin_1.q,runtime_stats_merge.q,vector_groupby_grouping_sets1.q,vector_binary_join_groupby.q,runtime_stats_hs2.q,lateral_view.q,optimize_nullscan.q,nonmr_fetch_threshold.q,vectorization_decimal_date.q,schema_evol_orc_nonvec_table_llap_io.q,schema_evol_text_vecrow_part_all_complex.q,tez_fsstat.q,vector_fullouter_mapjoin_1_optimized_passthru.q,stats11.q,tez_join_tests.q,join_acid_non_acid.q,empty_join.q,vector_groupby_grouping_window.q,auto_join21.q,schema_evol_text_vecrow_part.q,vector_groupby_sort_11.q,results_cache_2.q,schema_evol_orc_nonvec_part_all_complex_llap_io.q,orc_ppd_timestamp.q,vector_decimal_1.q] org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_buckets] (batchId=275) org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_format_nonpart] (batchId=275) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket_if_with_path_filter] (batchId=6) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[char_serde] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[convert_decimal64_to_decimal] (batchId=53) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[date_serde] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_join2] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynamic_partition_insert] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[implicit_cast_during_insert] (batchId=55) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[materialized_view_authorization_sqlstd] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_avro_partition_uniontype] (batchId=50) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_createas1] (batchId=94) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_dictionary_threshold] (batchId=23) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_diff_part_cols2] (batchId=27) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_diff_part_cols] (batchId=24) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_empty_strings] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ends_with_nulls] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_file_dump] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_int_type_promotion] (batchId=45) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge10] (batchId=69) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge11] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge12] (batchId=67) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge13] (batchId=92) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge1] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge3] (batchId=29) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge4] (batchId=71) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge5] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge6] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge_diff_fs] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge_incompat1] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge_incompat2] (batchId=90) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_boolean] (batchId=38) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_char] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_is_null] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_same_table_multiple_aliases] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_schema_evol_1a] (batchId=45) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_schema_evol_1b] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_schema_evol_2a] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_schema_evol_2b] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_remove_cols] (batchId=7)
[jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
[ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671042#comment-16671042 ] Hive QA commented on HIVE-20823: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 54s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 2 new + 633 unchanged - 0 fixed = 635 total (was 633) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 28s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14692/dev-support/hive-personality.sh | | git revision | master / 08349b1 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14692/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14692/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Make Compactor run in a transaction > --- > > Key: HIVE-20823 > URL: https://issues.apache.org/jira/browse/HIVE-20823 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-20823.01.patch > > > Have compactor open a transaction and run the job in that transaction. > # make compactor produced base/delta include this txn id in the folder name, > e.g. base_7_c17 where 17 is the txnid. > # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to > record this txn id > # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction > on read and ignores this dir if this txn id is not committed in the current > snapshot > ## this means not only validWriteIdList but ValidTxnIdList should be passed > along in config (if it isn't yet) > # once this is done, {{CompactorMR.createCompactorMarker()}} can be > eliminated and {{AcidUtils.isValidBase}} modified accordingly > # modify Cleaner so that it doesn't clean old files until new file is visible > to all readers > # -- This message was sent by Atlassian JIRA (v7.6.3#76005)