[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687019#comment-16687019
]
Eugene Koifman commented on HIVE-20888:
---
+1
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Assignee: Igor Kryvenko
>Priority: Major
> Attachments: HIVE-20888.01.patch
>
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685490#comment-16685490
]
Igor Kryvenko commented on HIVE-20888:
--
The failed test is not related.
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Assignee: Igor Kryvenko
>Priority: Major
> Attachments: HIVE-20888.01.patch
>
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685483#comment-16685483
]
Hive QA commented on HIVE-20888:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947987/HIVE-20888.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15534 tests
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=195)
[druidmini_dynamic_partition.q,druidmini_test_ts.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test_insert.q]
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit]
(batchId=182)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14913/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14913/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14913/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947987 - PreCommit-HIVE-Build
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Assignee: Igor Kryvenko
>Priority: Major
> Attachments: HIVE-20888.01.patch
>
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685433#comment-16685433
]
Hive QA commented on HIVE-20888:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
3s{color} | {color:blue} standalone-metastore/metastore-server in master has
185 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14913/dev-support/hive-personality.sh
|
| git revision | master / 99d25f0 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14913/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Assignee: Igor Kryvenko
>Priority: Major
> Attachments: HIVE-20888.01.patch
>
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalo
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685229#comment-16685229
]
Igor Kryvenko commented on HIVE-20888:
--
After an investigation, the easiest approach to fix this just add checking
which Gopal proposed, since we can't differentiate do we handle singleton list
or lists with txn ids.
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Assignee: Igor Kryvenko
>Priority: Major
> Attachments: HIVE-20888.01.patch
>
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680581#comment-16680581
]
Eugene Koifman commented on HIVE-20888:
---
cc [~ikryvenko]
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Reporter: Gopal V
>Priority: Major
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20888) TxnHandler: sort() called on immutable lists
[
https://issues.apache.org/jira/browse/HIVE-20888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679284#comment-16679284
]
Gopal V commented on HIVE-20888:
The current workaround is
{code}
if (txnIds.size() > 1) {
Collections.sort(txnIds); //easier to read logs and for assumption done
in replication flow
}
{code}
which works fine for Singleton lists.
> TxnHandler: sort() called on immutable lists
>
>
> Key: HIVE-20888
> URL: https://issues.apache.org/jira/browse/HIVE-20888
> Project: Hive
> Issue Type: Bug
>Reporter: Gopal V
>Priority: Major
>
> {code}
> } else {
> assert (!rqst.isSetSrcTxnToWriteIdList());
> assert (rqst.isSetTxnIds());
> txnIds = rqst.getTxnIds();
> }
> Collections.sort(txnIds); //easier to read logs and for assumption
> done in replication flow
> {code}
> when the input comes from
> {code}
> @Override
> public long allocateTableWriteId(long txnId, String dbName, String
> tableName) throws TException {
> return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
> dbName, tableName).get(0).getWriteId();
> }
> {code}
> {code}
> java.lang.UnsupportedOperationException: null
> at java.util.AbstractList.set(AbstractList.java:132) ~[?:1.8.0]
> at java.util.AbstractList$ListItr.set(AbstractList.java:426) ~[?:1.8.0]
> at java.util.Collections.sort(Collections.java:170) ~[?:1.8.0]
> at
> org.apache.hadoop.hive.metastore.txn.TxnHandler.allocateTableWriteIds(TxnHandler.java:1523)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.allocate_table_write_ids(HiveMetaStore.java:7349)
> ~[hive-standalone-metastore-server-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
