[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[
https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887645#comment-16887645
]
Hive QA commented on HIVE-20908:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947923/HIVE-20908.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 16674 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup
(batchId=232)
org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession
(batchId=232)
org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=232)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18076/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18076/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18076/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947923 - PreCommit-HIVE-Build
> Avoid multiple getTableMeta calls during GetTablesOperation.
>
>
> Key: HIVE-20908
> URL: https://issues.apache.org/jira/browse/HIVE-20908
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.1.1
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Minor
> Labels: performance
> Attachments: HIVE-20908.patch
>
>
> following HIVE-19432, we are doing getTableMeta for each authorized db
> instead of that we can pass pattern for metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[
https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887613#comment-16887613
]
Hive QA commented on HIVE-20908:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} service in master has 48 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} service: The patch generated 13 new + 13 unchanged - 0
fixed = 26 total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18076/dev-support/hive-personality.sh
|
| git revision | master / 198ab0e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18076/yetus/diff-checkstyle-service.txt
|
| modules | C: service U: service |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18076/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Avoid multiple getTableMeta calls during GetTablesOperation.
>
>
> Key: HIVE-20908
> URL: https://issues.apache.org/jira/browse/HIVE-20908
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.1.1
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Minor
> Labels: performance
> Attachments: HIVE-20908.patch
>
>
> following HIVE-19432, we are doing getTableMeta for each authorized db
> instead of that we can pass pattern for metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[ https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887486#comment-16887486 ] Rajkumar Singh commented on HIVE-20908: --- by passing a pattern/dbnames in a single call will make the HMS stall while pulling so many objects in one go. I think HIVE-19432 is good for embedded HMS but for remote HMS we may need to work on making ObjectStore.getTableMeta call fast https://github.com/apache/hive/blob/2a625f77ff5d5b46366e9ce253896c53f4fd9fe4/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1822-L1821 I will try to optimize ObjectStore.getTableMeta so that it can sustain gettablemeta call for huge no of databases (tables). > Avoid multiple getTableMeta calls during GetTablesOperation. > > > Key: HIVE-20908 > URL: https://issues.apache.org/jira/browse/HIVE-20908 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 3.1.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Minor > Labels: performance > Attachments: HIVE-20908.patch > > > following HIVE-19432, we are doing getTableMeta for each authorized db > instead of that we can pass pattern for metastore. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[ https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887468#comment-16887468 ] Ashutosh Chauhan commented on HIVE-20908: - I dont see how this patch will improve perf, if anything it might make it worse. You are still making a call per DB, so nothing changes there but now instead of passing name you are passing pattern, so you will get more table objects then necessary. Suggestion on HIVE-19432 was to create a pattern on dbNames and then make a *single* metastoreClient.getTableMeta() to get all table objects in one shot, instead of per DB. > Avoid multiple getTableMeta calls during GetTablesOperation. > > > Key: HIVE-20908 > URL: https://issues.apache.org/jira/browse/HIVE-20908 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 3.1.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Minor > Labels: performance > Attachments: HIVE-20908.patch > > > following HIVE-19432, we are doing getTableMeta for each authorized db > instead of that we can pass pattern for metastore. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[ https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693739#comment-16693739 ] Rajkumar Singh commented on HIVE-20908: --- cc:[~thejas] > Avoid multiple getTableMeta calls during GetTablesOperation. > > > Key: HIVE-20908 > URL: https://issues.apache.org/jira/browse/HIVE-20908 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 3.1.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Minor > Labels: performance > Attachments: HIVE-20908.patch > > > following HIVE-19432, we are doing getTableMeta for each authorized db > instead of that we can pass pattern for metastore. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[
https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684842#comment-16684842
]
Hive QA commented on HIVE-20908:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947923/HIVE-20908.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15539 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14902/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14902/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14902/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947923 - PreCommit-HIVE-Build
> Avoid multiple getTableMeta calls during GetTablesOperation.
>
>
> Key: HIVE-20908
> URL: https://issues.apache.org/jira/browse/HIVE-20908
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.1.1
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Minor
> Labels: performance
> Attachments: HIVE-20908.patch
>
>
> following HIVE-19432, we are doing getTableMeta for each authorized db
> instead of that we can pass pattern for metastore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20908) Avoid multiple getTableMeta calls during GetTablesOperation.
[
https://issues.apache.org/jira/browse/HIVE-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684799#comment-16684799
]
Hive QA commented on HIVE-20908:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
34s{color} | {color:blue} service in master has 48 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} service: The patch generated 13 new + 13 unchanged - 0
fixed = 26 total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14902/dev-support/hive-personality.sh
|
| git revision | master / af40170 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14902/yetus/diff-checkstyle-service.txt
|
| modules | C: service U: service |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14902/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Avoid multiple getTableMeta calls during GetTablesOperation.
>
>
> Key: HIVE-20908
> URL: https://issues.apache.org/jira/browse/HIVE-20908
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
>Affects Versions: 3.1.1
>Reporter: Rajkumar Singh
>Assignee: Rajkumar Singh
>Priority: Minor
> Labels: performance
> Attachments: HIVE-20908.patch
>
>
> following HIVE-19432, we are doing getTableMeta for each authorized db
> instead of that we can pass pattern for metastore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
