[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755300#comment-16755300 ] Vihang Karajgaonkar commented on HIVE-21077: Thanks [~ngangam] merged the addendum to master and branch-3 > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch, HIVE-21077.addendum.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755230#comment-16755230 ] Naveen Gangam commented on HIVE-21077: -- [~vihangk1] The add-on patch for the MSSQL datatype looks good to me. So +1 for me. Thanks > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch, HIVE-21077.addendum.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750462#comment-16750462 ] Vihang Karajgaonkar commented on HIVE-21077: Attaching a addendum patch which changes datatype of CREATE_TIME field in mssql scripts for database and catalog to INT from BIGINT to make it consistent with other create_time fields. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch, HIVE-21077.addendum.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748992#comment-16748992 ] Vihang Karajgaonkar commented on HIVE-21077: patch merged into branch-3 and master. Thanks [~bharos92] for the review. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745797#comment-16745797 ] Bharathkrishna Guruvayoor Murali commented on HIVE-21077: - The changes for upgrade scripts from 3.1.0 to 3.2.0 looks good to me. +1 > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745651#comment-16745651 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955300/HIVE-21077.10.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15699 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15672/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15672/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15672/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12955300 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745631#comment-16745631 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 11s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 59s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 20m 39s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15672/dev-support/hive-personality.sh | | git revision | master / 67284b0 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15672/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15672/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745529#comment-16745529 ] Vihang Karajgaonkar commented on HIVE-21077: It looks like environment issue. The build works for me locally. Reattaaching > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch, HIVE-21077.10.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744549#comment-16744549 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955160/HIVE-21077.09.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15651/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15651/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15651/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-01-17 00:13:43.057 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-15651/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-01-17 00:13:43.060 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 4c73511 HIVE-21040 : msck does unnecessary file listing at last level of directory tree (Vihang Karajgaonkar, reviewed by Prasanth Jayachandran) + git clean -f -d + git checkout master Switched to branch 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at 4d5d806 Revert "HIVE-21077 : Database and Catalogs should have creation time (Vihang Karajgaonkar reviewed by Karthik Manamcheri and Bharath Krishna)" + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-01-17 00:13:47.398 + rm -rf ../yetus_PreCommit-HIVE-Build-15651 + mkdir ../yetus_PreCommit-HIVE-Build-15651 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-15651 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15651/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java: does not exist in index error: a/standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java: does not exist in index error: a/standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php: does not exist in index error: a/standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py: does not exist in index error: a/standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb: does not exist in index error: a/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java: does not exist in index error: a/standalone-metastore/metastore-server/src/main/resources/package.jdo: does not exist in index error: a/standalone-metastore/metastore-server/src/main/sql/derby/hive-schem
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744545#comment-16744545 ] Vihang Karajgaonkar commented on HIVE-21077: I actually reverted the v8 patch from the master since I wanted to include the schema changes for 3.2.0 release as well. In order to keep master in sync, the v9 patch makes changes to both the hive-schema-3.2.0* and hive-schema-4.0.0* files. Also, the upgrade scripts from 3.1.0-to-3.2.0 are modified so that we port this patch to branch-3 as well. [~bharos92] Can you please take a look again? There is no code change involved since last patch. The only additional change over v8 is schema changes are applied to 3.2.0 files as well and the upgrade logic is moved to 3.1.0-to-3.2.0 files. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch, > HIVE-21077.09.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1676#comment-1676 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955144/HIVE-21077.08.branch-3.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15650/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15650/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15650/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-01-16 20:37:58.776 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-15650/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z branch-3 ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-01-16 20:37:58.779 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 4c73511 HIVE-21040 : msck does unnecessary file listing at last level of directory tree (Vihang Karajgaonkar, reviewed by Prasanth Jayachandran) + git clean -f -d Removing kafka-handler/ Removing standalone-metastore/metastore-common/ Removing standalone-metastore/metastore-server/ Removing standalone-metastore/metastore-tools/ Removing upgrade-acid/pre-upgrade/ + git checkout branch-3 Already on 'branch-3' Your branch is up-to-date with 'origin/branch-3'. + git reset --hard origin/branch-3 HEAD is now at 4c73511 HIVE-21040 : msck does unnecessary file listing at last level of directory tree (Vihang Karajgaonkar, reviewed by Prasanth Jayachandran) + git merge --ff-only origin/branch-3 Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-01-16 20:37:59.391 + rm -rf ../yetus_PreCommit-HIVE-Build-15650 + mkdir ../yetus_PreCommit-HIVE-Build-15650 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-15650 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15650/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py: does not exist in index error: a/standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java: does not exist in index error: a/standalone-metastore/src/main/resources/package.jdo: does not exist in index error: a/standalone-metastore/src/main/sql/derby/hive-schem
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744430#comment-16744430 ] Vihang Karajgaonkar commented on HIVE-21077: Thanks for the review [~bharos92]. Attaching a patch for branch-3. I merged the patch for the master branch, but I think since I plan to merge this patch in branch-3 as well, I will have to add a addentum patch to the master branch so that upgrade scripts are from 3.1.0-3.2.0 are modified instead of 3.2.0-4.0.0. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch, HIVE-21077.08.branch-3.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743320#comment-16743320 ] Bharathkrishna Guruvayoor Murali commented on HIVE-21077: - LGTM +1. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742486#comment-16742486 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954869/HIVE-21077.07.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15698 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15618/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15618/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15618/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12954869 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742450#comment-16742450 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 17s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 2s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 42s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15618/dev-support/hive-personality.sh | | git revision | master / a3aa074 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15618/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15618/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742421#comment-16742421 ] Vihang Karajgaonkar commented on HIVE-21077: Looks like a flaky test failure. Works for me locally. Reattaching > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch, HIVE-21077.07.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739982#comment-16739982 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954502/HIVE-21077.06.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15716 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=336) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15585/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15585/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15585/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12954502 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739958#comment-16739958 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 37s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 16s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 4s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15585/dev-support/hive-personality.sh | | git revision | master / f713140 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15585/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15585/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739885#comment-16739885 ] Vihang Karajgaonkar commented on HIVE-21077: The last set of timeouts are most likely due to excessive time taken by TestReplAcidTablesWithJsonMessage test. I have added it to skip batching. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739887#comment-16739887 ] Vihang Karajgaonkar commented on HIVE-21077: Reattached the same patch as v5 to trigger tests after skipping TestReplAcidTablesWithJsonMessage > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch, > HIVE-21077.06.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738634#comment-16738634 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954341/HIVE-21077.05.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 15700 tests executed *Failed tests:* {noformat} TestAlterTableMetadata - did not produce a TEST-*.xml file (likely timed out) (batchId=251) TestReplAcidTablesWithJsonMessage - did not produce a TEST-*.xml file (likely timed out) (batchId=251) TestSemanticAnalyzerHookLoading - did not produce a TEST-*.xml file (likely timed out) (batchId=251) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15566/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15566/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15566/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12954341 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738585#comment-16738585 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 22s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 6s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 2s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15566/dev-support/hive-personality.sh | | git revision | master / 4d03e31 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15566/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15566/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch, HIVE-21077.05.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: opti
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737825#comment-16737825 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954246/HIVE-21077.04.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15554/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15554/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15554/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12954246/HIVE-21077.04.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12954246 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737824#comment-16737824 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954246/HIVE-21077.04.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 15699 tests executed *Failed tests:* {noformat} TestAlterTableMetadata - did not produce a TEST-*.xml file (likely timed out) (batchId=251) TestReplAcidTablesWithJsonMessage - did not produce a TEST-*.xml file (likely timed out) (batchId=251) TestSemanticAnalyzerHookLoading - did not produce a TEST-*.xml file (likely timed out) (batchId=251) org.apache.hadoop.hive.metastore.cache.TestCachedStore.testDatabaseOps (batchId=230) org.apache.hive.jdbc.TestSSL.testMetastoreWithSSL (batchId=258) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15553/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15553/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15553/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12954246 - PreCommit-HIVE-Build > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737805#comment-16737805 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 39s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 17s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 6s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15553/dev-support/hive-personality.sh | | git revision | master / e92df8d | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15553/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15553/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737704#comment-16737704 ] Vihang Karajgaonkar commented on HIVE-21077: Latest patch should fix most of the test failures above. Also, rethought about the default 0 which is not really what we want since it maps to a legitimate time value (1st Jan 1970 0:0:0 GMT). I think its best to keep this column allowing nulls to keep backwards compatibility with the existing database and catalogs in the system. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch, HIVE-21077.04.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737602#comment-16737602 ] Vihang Karajgaonkar commented on HIVE-21077: test failures are related. Looking into these. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736344#comment-16736344 ] Hive QA commented on HIVE-21077: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954033/HIVE-21077.03.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 336 failed/errored test(s), 15580 tests executed *Failed tests:* {noformat} TestCompactor - did not produce a TEST-*.xml file (likely timed out) (batchId=242) TestDbTxnManager2 - did not produce a TEST-*.xml file (likely timed out) (batchId=325) TestHiveCredentialProviders - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestKeyWrapperFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestLog4j2Appenders - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestOperators - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestSlidingFilenameRolloverStrategy - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestTxnCommandsWithSplitUpdateAndVectorization - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestTxnNoBuckets - did not produce a TEST-*.xml file (likely timed out) (batchId=308) TestTxnNoBucketsVectorized - did not produce a TEST-*.xml file (likely timed out) (batchId=308) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.stringifyValidTxns (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testLocks (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testLocksWithTxn (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testOpenTxnNotExcluded (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxNWithKeyValue (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxNWithKeyValueNoTableId (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxNWithKeyWrongPrefix (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxns (batchId=230) org.apache.hadoop.hive.metastore.cache.TestCachedStore.testDatabaseOps (batchId=230) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.alterCatalog (batchId=238) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.createCatalog (batchId=238) org.apache.hadoop.hive.metastore.tools.TestSchemaToolCatalogOps.createExistingCatalogWithIfNotExists (batchId=238) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateLocations (batchId=227) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateNullValues (batchId=227) org.apache.hadoop.hive.metastore.tools.TestSchemaToolForMetastore.testValidateSequences (batchId=227) org.apache.hadoop.hive.ql.TestAcidOnTez.testAcidInsertWithRemoveUnion (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testBucketedAcidInsertWithRemoveUnion (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testGetSplitsLocks (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testGetSplitsLocksWithMaterializedView (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testInsertWithRemoveUnion (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnMR (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnTez (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnMR (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnTez (batchId=241) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartition (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionBucketed (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionMM (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionMMVectorized (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionRename (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionTransactional (batchId=322) org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionVectorized (batchId=322) org.apache.hadoop.hive.ql.TestTxnCommands.exchangePartition (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testBadOnClause (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testCompactionBlocking (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testDelete (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testDeleteIn (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testErrors (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testExplicitRollback (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testImplicitRollback (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testInsertOverwrite (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testMergeCardinalityViolation (batchId=326) org.apache.hadoop.hive.ql.TestTxnCommands.testMergeCase (batc
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736277#comment-16736277 ] Hive QA commented on HIVE-21077: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 44s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 9s{color} | {color:blue} standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 2s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15530/dev-support/hive-personality.sh | | git revision | master / 0dbb896 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-15530/yetus/whitespace-eol.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15530/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional Pri
[jira] [Commented] (HIVE-21077) Database and catalogs should have creation time
[ https://issues.apache.org/jira/browse/HIVE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736208#comment-16736208 ] Vihang Karajgaonkar commented on HIVE-21077: not sure why the precommit didn't run over the weekend. Re-attached the patch. > Database and catalogs should have creation time > --- > > Key: HIVE-21077 > URL: https://issues.apache.org/jira/browse/HIVE-21077 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore >Reporter: Vihang Karajgaonkar >Assignee: Vihang Karajgaonkar >Priority: Major > Attachments: HIVE-21077.01.patch, HIVE-21077.02.patch, > HIVE-21077.03.patch > > > Currently, database do not have creation time like we have for tables and > partitions. > {noformat} > // namespace for tables > struct Database { > 1: string name, > 2: string description, > 3: string locationUri, > 4: map parameters, // properties associated with the > database > 5: optional PrincipalPrivilegeSet privileges, > 6: optional string ownerName, > 7: optional PrincipalType ownerType, > 8: optional string catalogName > } > {noformat} > Currently, without creationTime there is no way to identify if the copy of > Database which a client has is the same as the one on the server if the name > is same. Without object ids creationTime value is the only way currently to > identify uniquely a instance of metastore object. It would be good to have > Database creation time as well. > Same applies for catalogs as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)