[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807741#comment-16807741 ] Marta Kuczora commented on HIVE-21443: -- +1 Thanks a lot [~pvary] for the patch. > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.02.patch, HIVE-21443.03.patch, > HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807514#comment-16807514 ] Peter Vary commented on HIVE-21443: --- [~kuczoram]: Can you review please? Thanks, Peter > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.02.patch, HIVE-21443.03.patch, > HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806223#comment-16806223
]
Peter Vary commented on HIVE-21443:
---
So the original failures:
* resourceplan - Runs the changed {{hive-schema-4.0.0.hive.sql}}, so the q.out
has to be updated
* strict_managed_tables_sysdb - Runs the changed
{{hive-schema-4.0.0.hive.sql}}, so the q.out has to be updated
* sysdb - The transaction/compaction data is not cleaned up between the runs -
could cause flakiness depending on the batch queries. Needed to change
{{QTestUtil.clearTestSideEffects}} to drop and recreate transactional data
The failure found by [~gopalv]: Unrelated issue caused by HIVE-21554
Have a green run. [~kgyrtkirk]/[~vgarg]/[~gopalv] review please?
Thanks, and sorry for the extra rounds!
Peter
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.03.patch,
> HIVE-21443.addendum.patch, HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806183#comment-16806183
]
Hive QA commented on HIVE-21443:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12964364/HIVE-21443.03.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15883 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16785/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16785/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16785/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12964364 - PreCommit-HIVE-Build
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.03.patch,
> HIVE-21443.addendum.patch, HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806179#comment-16806179
]
Hive QA commented on HIVE-21443:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
18s{color} | {color:blue} ql in master has 2257 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
50s{color} | {color:blue} itests/util in master has 46 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16785/dev-support/hive-personality.sh
|
| git revision | master / dc0b16a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: metastore ql itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16785/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.03.patch,
> HIVE-21443.addendum.patch, HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805998#comment-16805998
]
Hive QA commented on HIVE-21443:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12964328/HIVE-21443.02.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16782/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16782/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16782/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12964328/HIVE-21443.02.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12964328 - PreCommit-HIVE-Build
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.addendum.patch,
> HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805997#comment-16805997
]
Hive QA commented on HIVE-21443:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12964328/HIVE-21443.02.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15883 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_no_buckets]
(batchId=178)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16781/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16781/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16781/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12964328 - PreCommit-HIVE-Build
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.addendum.patch,
> HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805987#comment-16805987
]
Hive QA commented on HIVE-21443:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
16s{color} | {color:blue} ql in master has 2257 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
52s{color} | {color:blue} itests/util in master has 46 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16781/dev-support/hive-personality.sh
|
| git revision | master / dc0b16a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: metastore ql itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16781/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.02.patch, HIVE-21443.addendum.patch,
> HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805248#comment-16805248 ] Vineet Garg commented on HIVE-21443: No problem. I reverted the commit because it was blocking other patches (to get green run). I think it is better to fix all the tests and commit it once so that other patches don't push separate test failure inadvertently (like in pre-historic times of 3.0 development). > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805245#comment-16805245 ] Peter Vary commented on HIVE-21443: --- Thanks [~vgarg]! Couldn't revert myself (fetching the kids). I always wait for the green run, but this time I made a mistake (juggling too many things in parallel). Sorry for the problems caused. :( Peter > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805236#comment-16805236 ] Gopal V commented on HIVE-21443: the addendum isn't committed, because of sysdb.q result change (+6,-3 in there). > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805210#comment-16805210 ] Peter Vary commented on HIVE-21443: --- The id of the compaction is changed so some other compaction is initiated on the driver. It will cause flakiness depending on the batch. Will fix on Monday. > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.addendum.patch, HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805201#comment-16805201 ] Peter Vary commented on HIVE-21443: --- Revert please. Something else left some compaction there. Will be flaky. [~kgyrtkirk]: mixed up with another jira :( > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805191#comment-16805191
]
Gopal V commented on HIVE-21443:
[~pvary]: the failed tests are related.
{code}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
Failing for the past 1 build (Since Failed#16745 )
Took 59 sec.
Error Message
Client Execution succeeded but contained differences (error code = 1) after
executing sysdb.q
4810,4811c4810,4811
< 4 default default scr_txn NULL major initiated NULL NULL NULL NULL NULL NULL
NULL
< 5 default default scr_txn_2 NULL minor initiated NULL NULL NULL NULL NULL
NULL NULL
---
> 1 default default scr_txn NULL major initiated NULL NULL NULL NULL NULL NULL
> NULL
> 2 default default scr_txn_2 NULL minor initiated NULL NULL NULL NULL NULL
> NULL NULL
5047,5048c5047,5048
< 4 default default scr_txn NULL major initiated NULL NULL NULL NULL NULL NULL
NULL
< 5 default default scr_txn_2 NULL minor initiated NULL NULL NULL NULL NULL
NULL NULL
---
> 1 default default scr_txn NULL major initiated NULL NULL NULL NULL NULL NULL
> NULL
> 2 default default scr_txn_2 NULL minor initiated NULL NULL NULL NULL NULL
> NULL NULL
{code}
[~kgyrtkirk]: I'll check in an addendum.
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805189#comment-16805189 ] Zoltan Haindrich commented on HIVE-21443: - where is the clean testrun??? > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804685#comment-16804685
]
Hive QA commented on HIVE-21443:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12964067/HIVE-21443.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 15869 tests
executed
*Failed tests:*
{noformat}
TestJdbcWithMiniLlapArrow - did not produce a TEST-*.xml file (likely timed
out) (batchId=263)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
(batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[strict_managed_tables_sysdb]
(batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=169)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16745/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16745/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16745/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12964067 - PreCommit-HIVE-Build
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804651#comment-16804651 ] Gopal V commented on HIVE-21443: LGTM - +1 (not a single line of java, which is a "wow" in itself) > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-21443.patch > > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804650#comment-16804650
]
Hive QA commented on HIVE-21443:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 7 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 3m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16745/dev-support/hive-personality.sh
|
| git revision | master / 559efea |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16745/yetus/patch-asflicense-problems.txt
|
| modules | C: metastore ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16745/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[
https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804180#comment-16804180
]
Peter Vary commented on HIVE-21443:
---
Sample output:
{code:java}
0: jdbc:hive2://localhost:10003> select * from compactions;
[..]
+---++-+--+--+-+--+-+--+--+-+--+---+-+
| compactions.c_id | compactions.c_catalog | compactions.c_database |
compactions.c_table | compactions.c_partition | compactions.c_type |
compactions.c_state | compactions.c_hostname | compactions.c_worker_id |
compactions.c_start | compactions.c_duration | compactions.c_hadoop_job_id |
compactions.c_run_as | compactions.c_highest_write_id |
+---++-+--+--+-+--+-+--+--+-+--+---+-+
| 1 | default | default | acid | NULL | minor | failed | PeterVary |
MBP15.local | 1551275865000 | 11000 | NULL | petervary | 5 |
| 10 | default | default | acid | NULL | major | failed | PeterVary |
MBP15.local | 1551355199000 | 3 | NULL | petervary | 5 |
| 15 | default | default | acid | NULL | major | failed | PeterVary |
MBP15.local | 1552074769000 | 22000 | NULL | petervary | 5 |
| 16 | default | default | acid | NULL | major | working | PeterVary |
MBP15.local | 1553716252000 | NULL | NULL | petervary | 5 |
| 17 | default | default | acid2 | NULL | major | working | PeterVary |
MBP15.local | 1553785387000 | NULL | NULL | petervary | 5 |
| 18 | default | default | acid3 | NULL | major | initiated | NULL | NULL |
NULL | NULL | NULL | NULL | NULL |
| 19 | default | default | acid_buck | NULL | major | initiated | NULL | NULL |
NULL | NULL | NULL | NULL | NULL |
+---++-+--+--+-+--+-+--+--+-+--+---+-+
7 rows selected (18.503 seconds)
0: jdbc:hive2://localhost:10003>{code}
> Better usability for SHOW COMPACTIONS
> -
>
> Key: HIVE-21443
> URL: https://issues.apache.org/jira/browse/HIVE-21443
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Reporter: Todd Lipcon
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-21443.patch
>
>
> Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows.
> This makes it basically useless to work with.
> For better usability, we should support syntax like 'SHOW COMPACTIONS IN
> ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be
> chosen for consistency with other operations I suppose).
> Alternatively (or maybe in addition) it seems like it would be nice to expose
> the same data in a queryable table (eg in information_schema or a system
> namespace) so that I could do things like: SELECT dbname, state, count(*)
> from compactions group by 1,2;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798322#comment-16798322 ] Peter Vary commented on HIVE-21443: --- [~gopalv], [~tlipcon]: I think adding this to the sys.COMPACTIONS could be done adding the new tables here. See: [https://github.com/apache/hive/blob/master/metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql] As a follow-up jira, maybe the SQL scripts creating the schema should be moved to the standalone-metastore directory as well (just to make the review easier). Is it enough to have the same data exposed as for the SHOW COMPACTIONS command?: * CompactionId * Database * Table * Partition * Type * State * Hostname * Worker * Start Time * Duration(ms) * HadoopJobId The missing columns are: * CC_TBLPROPERTIES varchar(2048), * CC_WORKER_ID varchar(128), * CC_RUN_AS varchar(128), * CC_HIGHEST_WRITE_ID bigint, * CC_META_INFO varbinary(2048), If you guys do not have an opinion, I would go for the same data as for the original command. What should we do with the SHOW COMPACTIONS command? Will this expose dbnames/tablenames/partitionnames for unauthorized users? Thanks, Peter > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Priority: Major > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21443) Better usability for SHOW COMPACTIONS
[ https://issues.apache.org/jira/browse/HIVE-21443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792087#comment-16792087 ] Gopal V commented on HIVE-21443: The sys.COMPACTIONS is better in general, because the authorization, cell-level masking can be implemented over a table entity than over a command. > Better usability for SHOW COMPACTIONS > - > > Key: HIVE-21443 > URL: https://issues.apache.org/jira/browse/HIVE-21443 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Todd Lipcon >Priority: Major > > Currently on a test cluster the output of 'SHOW COMPACTIONS' has 117k rows. > This makes it basically useless to work with. > For better usability, we should support syntax like 'SHOW COMPACTIONS IN > ' or maybe 'SHOW COMPACTIONS ON ' (particular syntax to be > chosen for consistency with other operations I suppose). > Alternatively (or maybe in addition) it seems like it would be nice to expose > the same data in a queryable table (eg in information_schema or a system > namespace) so that I could do things like: SELECT dbname, state, count(*) > from compactions group by 1,2; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
