[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805592#comment-16805592 ] Hive QA commented on HIVE-21499: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12964208/HIVE-21499.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15882 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16765/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16765/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16765/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12964208 - PreCommit-HIVE-Build > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.01.patch, HIVE-21499.02.patch, > HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805589#comment-16805589 ] Hive QA commented on HIVE-21499: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 55s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 19s{color} | {color:blue} ql in master has 2256 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 44s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 24s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16765/dev-support/hive-personality.sh | | git revision | master / 6f18bbb | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16765/yetus/diff-checkstyle-itests_hive-unit.txt | | modules | C: ql itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16765/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.01.patch, HIVE-21499.02.patch, > HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804754#comment-16804754 ] Hive QA commented on HIVE-21499: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12964090/HIVE-21499.01.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16748/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16748/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16748/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-03-29 09:41:07.851 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-16748/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-03-29 09:41:07.854 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive 759123a..1eb3194 master -> origin/master + git reset --hard HEAD HEAD is now at 759123a HIVE-21512: Upgrade jms-api to 2.0.2 (Zoltan Haindrich reviewed by Peter Vary) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is behind 'origin/master' by 4 commits, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at 1eb3194 HIVE-21541: Fix missing asf headers from HIVE-15406 (Laszlo Bodor reviewed by Peter Vary) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-03-29 09:41:09.688 + rm -rf ../yetus_PreCommit-HIVE-Build-16748 + mkdir ../yetus_PreCommit-HIVE-Build-16748 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-16748 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-16748/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java: does not exist in index error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:208 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java' with conflicts. Going to apply patch with: git apply -p1 error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java:208 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java' with conflicts. U ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-16748 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12964090 - PreCommit-HIVE-Build > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.01.patch, HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804461#comment-16804461 ] Thejas M Nair commented on HIVE-21499: -- +1 > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.01.patch, HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804326#comment-16804326 ] Rajkumar Singh commented on HIVE-21499: --- [~thejas] incorporated the suggested change and added the unit test, please review. thanks > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.01.patch, HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803360#comment-16803360 ] Thejas M Nair commented on HIVE-21499: -- Also can you use {} for the "if" statement. That makes it less error prone. (Famous example - https://blog.codecentric.de/en/2014/02/curly-braces/ ) > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803355#comment-16803355 ] Thejas M Nair commented on HIVE-21499: -- Change looks good. Can you also please add a unit test case ? > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800213#comment-16800213 ] Hive QA commented on HIVE-21499: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12963564/HIVE-21499.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15836 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16663/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16663/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16663/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12963564 - PreCommit-HIVE-Build > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21499) should not remove the function from registry if create command failed with AlreadyExistsException
[ https://issues.apache.org/jira/browse/HIVE-21499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800197#comment-16800197 ] Hive QA commented on HIVE-21499: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 25s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 43s{color} | {color:red} ql: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16663/dev-support/hive-personality.sh | | git revision | master / 2fa22bf | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16663/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16663/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > should not remove the function from registry if create command failed with > AlreadyExistsException > - > > Key: HIVE-21499 > URL: https://issues.apache.org/jira/browse/HIVE-21499 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 3.1.0 > Environment: Hive-3.1 >Reporter: Rajkumar Singh >Assignee: Rajkumar Singh >Priority: Major > Attachments: HIVE-21499.patch > > > As a part of HIVE-20953 we are removing the function if creation for same > failed with any reason, this will yield into the following situation. > 1. create function failed since function already exists > 2. on #1 failure hive will clear the permanent function from the registry > 3. this function will be of no use until hiveserver2 restarted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)