[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805513#comment-16805513 ] Laszlo Bodor commented on HIVE-21541: - thanks [~pvary], [~kgyrtkirk] ! I double-checked, and I found the root cause of duplications...I copied it from GenericUDFTrunc :) [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java#L2-L3] so, seems like it's a pattern, which could have spread in the codebase, we should check that... > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805040#comment-16805040 ] Peter Vary commented on HIVE-21541: --- Done with addendum > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805029#comment-16805029 ] Zoltan Haindrich commented on HIVE-21541: - I think an addendum is fine :D > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804972#comment-16804972 ] Peter Vary commented on HIVE-21541: --- Arrghh.. good catch [~kgyrtkirk]. Revert? Or addendum? > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[
https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804882#comment-16804882
]
Zoltan Haindrich commented on HIVE-21541:
-
this patch seem to have added duplicat "first lines":
{code}
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * Licensed to the Apache Software Foundation (ASF) under one
{code}
> Fix missing asf headers from HIVE-15406
> ---
>
> Key: HIVE-21541
> URL: https://issues.apache.org/jira/browse/HIVE-21541
> Project: Hive
> Issue Type: Bug
>Reporter: Laszlo Bodor
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21541.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804741#comment-16804741 ] Peter Vary commented on HIVE-21541: --- +1 > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21541) Fix missing asf headers from HIVE-15406
[ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804725#comment-16804725 ] Laszlo Bodor commented on HIVE-21541: - cc: [~pvary] > Fix missing asf headers from HIVE-15406 > --- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
