[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834337#comment-16834337 ] Hive QA commented on HIVE-21625: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12967953/HIVE-21625.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15981 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17142/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17142/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17142/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12967953 - PreCommit-HIVE-Build > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch, > HIVE-21625.3.patch, HIVE-21625.4.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834312#comment-16834312 ] Hive QA commented on HIVE-21625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} storage-api: The patch generated 63 new + 44 unchanged - 1 fixed = 107 total (was 45) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 22s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17142/dev-support/hive-personality.sh | | git revision | master / c5e6608 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17142/yetus/diff-checkstyle-storage-api.txt | | modules | C: storage-api U: storage-api | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17142/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch, > HIVE-21625.3.patch, HIVE-21625.4.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833594#comment-16833594 ] Hive QA commented on HIVE-21625: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12967896/HIVE-21625.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15981 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.mapreduce.TestHCatMutableNonPartitioned.testHCatNonPartitionedTable[3] (batchId=215) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17129/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17129/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17129/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12967896 - PreCommit-HIVE-Build > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch, > HIVE-21625.3.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833563#comment-16833563 ] Hive QA commented on HIVE-21625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} storage-api: The patch generated 63 new + 44 unchanged - 1 fixed = 107 total (was 45) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 19s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17129/dev-support/hive-personality.sh | | git revision | master / c5e6608 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17129/yetus/diff-checkstyle-storage-api.txt | | modules | C: storage-api U: storage-api | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17129/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch, > HIVE-21625.3.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833531#comment-16833531 ] Jason Dere commented on HIVE-21625: --- +1, pending green run for ptests > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820760#comment-16820760 ] Daniel Dai commented on HIVE-21625: --- [~jdere], can you review? > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820751#comment-16820751 ] Hive QA commented on HIVE-21625: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12966313/HIVE-21625.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15940 tests executed *Failed tests:* {noformat} TestReplicationScenariosAcidTables - did not produce a TEST-*.xml file (likely timed out) (batchId=258) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16984/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16984/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16984/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12966313 - PreCommit-HIVE-Build > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820730#comment-16820730 ] Hive QA commented on HIVE-21625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 25s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} storage-api: The patch generated 63 new + 44 unchanged - 1 fixed = 107 total (was 45) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 23s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16984/dev-support/hive-personality.sh | | git revision | master / 8f7f5d1 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16984/yetus/diff-checkstyle-storage-api.txt | | modules | C: storage-api U: storage-api | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16984/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch, HIVE-21625.2.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820591#comment-16820591 ] Hive QA commented on HIVE-21625: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12966275/HIVE-21625.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 15940 tests executed *Failed tests:* {noformat} TestReplAcidTablesWithJsonMessage - did not produce a TEST-*.xml file (likely timed out) (batchId=256) org.apache.hive.hcatalog.mapreduce.TestHCatPartitioned.testHCatPartitionedTable[2] (batchId=210) org.apache.hive.minikdc.TestJdbcWithMiniKdcCookie.testCookie (batchId=284) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16981/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16981/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16981/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12966275 - PreCommit-HIVE-Build > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21625) Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method
[ https://issues.apache.org/jira/browse/HIVE-21625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820556#comment-16820556 ] Hive QA commented on HIVE-21625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} storage-api: The patch generated 63 new + 44 unchanged - 1 fixed = 107 total (was 45) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 57s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16981/dev-support/hive-personality.sh | | git revision | master / 8f7f5d1 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16981/yetus/diff-checkstyle-storage-api.txt | | modules | C: storage-api U: storage-api | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16981/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Fix TxnIdUtils.checkEquivalentWriteIds, also provides a comparison method > - > > Key: HIVE-21625 > URL: https://issues.apache.org/jira/browse/HIVE-21625 > Project: Hive > Issue Type: Bug >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-21625.1.patch > > > TxnIdUtils.checkEquivalentWriteIds has a bug which thinks (\{1,2,3,4\}, 6) > and (\{1,2,3,4,5,6\}, 8) compatible (the notation is (invalidlist, hwm)). > Here is a patch to fix it, also provide a comparison method to check which is > newer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)