[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837005#comment-16837005
]
Adam Szita commented on HIVE-21681:
---
Committed to master. Thanks for reviewing Jesus!
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch, HIVE-21681.1.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834915#comment-16834915
]
Jesus Camacho Rodriguez commented on HIVE-21681:
+1
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch, HIVE-21681.1.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834870#comment-16834870
]
Hive QA commented on HIVE-21681:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12968054/HIVE-21681.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15982 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/17154/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17154/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17154/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12968054 - PreCommit-HIVE-Build
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch, HIVE-21681.1.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834819#comment-16834819
]
Hive QA commented on HIVE-21681:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
2s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17154/dev-support/hive-personality.sh
|
| git revision | master / ff98efa |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17154/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch, HIVE-21681.1.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831790#comment-16831790
]
Hive QA commented on HIVE-21681:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12967655/HIVE-21681.0.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15935 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_with_constraints2]
(batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_with_constraints]
(batchId=75)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/17097/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17097/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17097/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12967655 - PreCommit-HIVE-Build
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys
[
https://issues.apache.org/jira/browse/HIVE-21681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831753#comment-16831753
]
Hive QA commented on HIVE-21681:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
17s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17097/dev-support/hive-personality.sh
|
| git revision | master / 356bb6f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17097/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Describe formatted shows incorrect information for multiple primary keys
>
>
> Key: HIVE-21681
> URL: https://issues.apache.org/jira/browse/HIVE-21681
> Project: Hive
> Issue Type: Bug
>Reporter: Adam Szita
>Assignee: Adam Szita
>Priority: Minor
> Attachments: HIVE-21681.0.patch
>
>
> In tables with primary key spanning across multiple columns 'describe
> formatted' shows a maximum of two column names only: In the ASCII art table
> of 3 columns it will show:
> {{Column name|p1|p2}}
> Example queries:
> {code:java}
> CREATE TABLE test (
> p1 string,
> p2 string,
> p3 string,
> c0 int,
> PRIMARY KEY(p1,p2,p3) DISABLE NOVALIDATE
> );
> describe formatted test;{code}
> I propose we fix this so that primary key columns get listed one-by-one in
> separate rows, somewhat like how foreign keys are listed too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
