[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-09-05 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923373#comment-16923373
 ] 

Hive QA commented on HIVE-21996:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979483/HIVE-21996.02.patch

{color:green}SUCCESS:{color} +1 due to 12 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16714 tests 
executed
*Failed tests:*
{noformat}
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed 
out) (batchId=233)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=233)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18452/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18452/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18452/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12979483 - PreCommit-HIVE-Build

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch, HIVE-21996.02.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-09-05 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923310#comment-16923310
 ] 

Hive QA commented on HIVE-21996:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m  
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
48s{color} | {color:blue} ql in master has 2248 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
35s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
37s{color} | {color:green} ql: The patch generated 0 new + 200 unchanged - 8 
fixed = 200 total (was 208) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} itests/hive-unit: The patch generated 0 new + 24 
unchanged - 4 fixed = 24 total (was 28) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18452/dev-support/hive-personality.sh
 |
| git revision | master / ebcc9bc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18452/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch, HIVE-21996.02.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-08-12 Thread Miklos Gergely (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905241#comment-16905241
 ] 

Miklos Gergely commented on HIVE-21996:
---

I've checked it, and no other project is using the Driver class. Still as 
agreed with [~jcamachorodriguez] this modification will be merged only after 
the release.

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-16 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886095#comment-16886095
 ] 

Hive QA commented on HIVE-21996:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12974807/HIVE-21996.01.patch

{color:green}SUCCESS:{color} +1 due to 12 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16674 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18043/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18043/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18043/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12974807 - PreCommit-HIVE-Build

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-16 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886064#comment-16886064
 ] 

Hive QA commented on HIVE-21996:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
5s{color} | {color:blue} ql in master has 2249 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
41s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} ql: The patch generated 0 new + 200 unchanged - 8 
fixed = 200 total (was 208) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} itests/hive-unit: The patch generated 0 new + 24 
unchanged - 4 fixed = 24 total (was 28) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18043/dev-support/hive-personality.sh
 |
| git revision | master / 03b92fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18043/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-16 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886021#comment-16886021
 ] 

Hive QA commented on HIVE-21996:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12974805/HIVE-21996.01.patch

{color:green}SUCCESS:{color} +1 due to 13 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16671 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18042/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18042/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18042/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12974805 - PreCommit-HIVE-Build

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-16 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885965#comment-16885965
 ] 

Hive QA commented on HIVE-21996:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  7s{color} 
| {color:red} 
/data/hiveptest/logs/PreCommit-HIVE-Build-18042/patches/PreCommit-HIVE-Build-18042.patch
 does not apply to master. Rebase required? Wrong Branch? See 
http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18042/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-15 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885761#comment-16885761
 ] 

Hive QA commented on HIVE-21996:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12974774/HIVE-21996.01.patch

{color:green}SUCCESS:{color} +1 due to 14 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16670 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.org.apache.hadoop.hive.ql.TestWarehouseExternalDir
 (batchId=273)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testExternalDefaultPaths 
(batchId=273)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18037/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18037/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18037/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12974774 - PreCommit-HIVE-Build

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-15 Thread Hive QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885723#comment-16885723
 ] 

Hive QA commented on HIVE-21996:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m 15s{color} 
| {color:red} 
/data/hiveptest/logs/PreCommit-HIVE-Build-18037/patches/PreCommit-HIVE-Build-18037.patch
 does not apply to master. Rebase required? Wrong Branch? See 
http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18037/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HIVE-21996) Remove unused code from Driver

2019-07-15 Thread Miklos Gergely (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885633#comment-16885633
 ] 

Miklos Gergely commented on HIVE-21996:
---

[~jcamachorodriguez], could you please review?

 

> Remove unused code from Driver
> --
>
> Key: HIVE-21996
> URL: https://issues.apache.org/jira/browse/HIVE-21996
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>  Labels: pull-request-available, refactor-driver
> Attachments: HIVE-21996.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the IDriver interface there is an "int compile(String command)' function 
> which is only used by tests. As this is production code, it should be removed 
> from the interface. Also there are several other unused codes and 
> functions/fields with visibility that should be reduced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)