[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2

2019-08-27 Thread Laszlo Bodor (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916637#comment-16916637
 ] 

Laszlo Bodor commented on HIVE-22140:
-

thanks for the review [~kgyrtkirk], I've pushed this to master

> Metrics: unify codahale metric frequency unit between metastore and 
> hiveserver2
> ---
>
> Key: HIVE-22140
> URL: https://issues.apache.org/jira/browse/HIVE-22140
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Laszlo Bodor
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch
>
>
> Currently, different default value and even different unit are used for json 
> metric file generation frequency (for metastore and hiveserver2), which is 
> confusing, especially in a situation when a metastore config can fall back to 
> a corresponding hive config (metastore.metrics.file.frequency -> 
> hive.service.metrics.file.frequency). 
> I think ms would be appropriate for both of them, without even changing the 
> default 1minute for metastore (so changing it to 6ms is my proposal)
> hive.service.metrics.file.frequency
> Hiveserver2:
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> {code:java}
> HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", 
> "5000ms",
> new TimeValidator(TimeUnit.MILLISECONDS),
> "For metric class 
> org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
> "the frequency of updating JSON metrics file."),
> {code}
> Metastore:
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
> {code:java}
> METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency",
> "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES,
> "For json metric reporter, the frequency of updating JSON metrics 
> file."),
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2

2019-08-26 Thread Zoltan Haindrich (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915843#comment-16915843
 ] 

Zoltan Haindrich commented on HIVE-22140:
-

+1

> Metrics: unify codahale metric frequency unit between metastore and 
> hiveserver2
> ---
>
> Key: HIVE-22140
> URL: https://issues.apache.org/jira/browse/HIVE-22140
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Laszlo Bodor
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch
>
>
> Currently, different default value and even different unit are used for json 
> metric file generation frequency (for metastore and hiveserver2), which is 
> confusing, especially in a situation when a metastore config can fall back to 
> a corresponding hive config (metastore.metrics.file.frequency -> 
> hive.service.metrics.file.frequency). 
> I think ms would be appropriate for both of them, without even changing the 
> default 1minute for metastore (so changing it to 6ms is my proposal)
> hive.service.metrics.file.frequency
> Hiveserver2:
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> {code:java}
> HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", 
> "5000ms",
> new TimeValidator(TimeUnit.MILLISECONDS),
> "For metric class 
> org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
> "the frequency of updating JSON metrics file."),
> {code}
> Metastore:
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
> {code:java}
> METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency",
> "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES,
> "For json metric reporter, the frequency of updating JSON metrics 
> file."),
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2

2019-08-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914738#comment-16914738
 ] 

Hive QA commented on HIVE-22140:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12978441/HIVE-22140.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16745 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18394/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18394/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18394/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12978441 - PreCommit-HIVE-Build

> Metrics: unify codahale metric frequency unit between metastore and 
> hiveserver2
> ---
>
> Key: HIVE-22140
> URL: https://issues.apache.org/jira/browse/HIVE-22140
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Laszlo Bodor
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch
>
>
> Currently, different default value and even different unit are used for json 
> metric file generation frequency (for metastore and hiveserver2), which is 
> confusing, especially in a situation when a metastore config can fall back to 
> a corresponding hive config (metastore.metrics.file.frequency -> 
> hive.service.metrics.file.frequency). 
> I think ms would be appropriate for both of them, without even changing the 
> default 1minute for metastore (so changing it to 6ms is my proposal)
> hive.service.metrics.file.frequency
> Hiveserver2:
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> {code:java}
> HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", 
> "5000ms",
> new TimeValidator(TimeUnit.MILLISECONDS),
> "For metric class 
> org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
> "the frequency of updating JSON metrics file."),
> {code}
> Metastore:
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
> {code:java}
> METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency",
> "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES,
> "For json metric reporter, the frequency of updating JSON metrics 
> file."),
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2

2019-08-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914719#comment-16914719
 ] 

Hive QA commented on HIVE-22140:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 
34s{color} | {color:blue} standalone-metastore/metastore-common in master has 
32 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18394/dev-support/hive-personality.sh
 |
| git revision | master / ece9a54 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-common U: 
standalone-metastore/metastore-common |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18394/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Metrics: unify codahale metric frequency unit between metastore and 
> hiveserver2
> ---
>
> Key: HIVE-22140
> URL: https://issues.apache.org/jira/browse/HIVE-22140
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Reporter: Laszlo Bodor
>Assignee: Laszlo Bodor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch
>
>
> Currently, different default value and even different unit are used for json 
> metric file generation frequency (for metastore and hiveserver2), which is 
> confusing, especially in a situation when a metastore config can fall back to 
> a corresponding hive config (metastore.metrics.file.frequency -> 
> hive.service.metrics.file.frequency). 
> I think ms would be appropriate for both of them, without even changing the 
> default 1minute for metastore (so changing it to 6ms is my proposal)
> hive.service.metrics.file.frequency
> Hiveserver2:
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> {code:java}
> HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", 
> "5000ms",
> new TimeValidator(TimeUnit.MILLISECONDS),
> "For metric class 
> org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
> "the frequency of updating JSON metrics file."),
> {code}
> Metastore:
>