[jira] [Commented] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers
[ https://issues.apache.org/jira/browse/HIVE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928917#comment-16928917 ] Jesus Camacho Rodriguez commented on HIVE-22179: [~mgergely], can you fill in the fix version? Thanks > Break up DDLSemanticAnalyzer - extract Function related analyzers > - > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch, HIVE-22179.02.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyzer > and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them under > the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers
[ https://issues.apache.org/jira/browse/HIVE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927486#comment-16927486 ] Hive QA commented on HIVE-22179: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980028/HIVE-22179.02.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16751 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18535/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18535/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18535/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12980028 - PreCommit-HIVE-Build > Break up DDLSemanticAnalyzer - extract Function related analyzers > - > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch, HIVE-22179.02.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyzer > and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them under > the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers
[ https://issues.apache.org/jira/browse/HIVE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927464#comment-16927464 ] Hive QA commented on HIVE-22179: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 39s{color} | {color:blue} ql in master has 2244 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} ql: The patch generated 0 new + 270 unchanged - 11 fixed = 270 total (was 281) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 34s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18535/dev-support/hive-personality.sh | | git revision | master / 0505596 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18535/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Break up DDLSemanticAnalyzer - extract Function related analyzers > - > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch, HIVE-22179.02.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyzer > and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them under > the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers
[ https://issues.apache.org/jira/browse/HIVE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925011#comment-16925011 ] Hive QA commented on HIVE-22179: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12979767/HIVE-22179.01.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16748 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18500/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18500/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18500/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12979767 - PreCommit-HIVE-Build > Break up DDLSemanticAnalyzer - extract Function related analyzers > - > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch > > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyzer > and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them under > the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers
[ https://issues.apache.org/jira/browse/HIVE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925003#comment-16925003 ] Hive QA commented on HIVE-22179: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 36s{color} | {color:blue} ql in master has 2246 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} ql: The patch generated 0 new + 270 unchanged - 11 fixed = 270 total (was 281) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 11s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18500/dev-support/hive-personality.sh | | git revision | master / 5565311 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18500/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Break up DDLSemanticAnalyzer - extract Function related analyzers > - > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch > > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyzer > and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them under > the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)