[jira] [Commented] (HIVE-22182) SemanticAnalyzer populates map which is not used at all
[ https://issues.apache.org/jira/browse/HIVE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931129#comment-16931129 ] Laszlo Bodor commented on HIVE-22182: - pushed to master, thanks [~adombi] for the patch! > SemanticAnalyzer populates map which is not used at all > --- > > Key: HIVE-22182 > URL: https://issues.apache.org/jira/browse/HIVE-22182 > Project: Hive > Issue Type: Task > Components: Hive >Reporter: Akos Dombi >Assignee: Akos Dombi >Priority: Major > Attachments: HIVE-22182.patch > > > The {{SemanticAnalyzer}} class has two map fields which are populated but > never queried: > * {{topToTable}} > * {{topToTableProps}} > Last usage was removed in HIVE-11752. > h3. Purpose of this task > - Remove unused {{topToTable}} and {{topToTableProps}} fields -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22182) SemanticAnalyzer populates map which is not used at all
[ https://issues.apache.org/jira/browse/HIVE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927579#comment-16927579 ] Hive QA commented on HIVE-22182: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12979978/HIVE-22182.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16752 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18537/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18537/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18537/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12979978 - PreCommit-HIVE-Build > SemanticAnalyzer populates map which is not used at all > --- > > Key: HIVE-22182 > URL: https://issues.apache.org/jira/browse/HIVE-22182 > Project: Hive > Issue Type: Task > Components: Hive >Reporter: Akos Dombi >Assignee: Akos Dombi >Priority: Major > Attachments: HIVE-22182.patch > > > The {{SemanticAnalyzer}} class has two map fields which are populated but > never queried: > * {{topToTable}} > * {{topToTableProps}} > Last usage was removed in HIVE-11752. > h3. Purpose of this task > - Remove unused {{topToTable}} and {{topToTableProps}} fields -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22182) SemanticAnalyzer populates map which is not used at all
[ https://issues.apache.org/jira/browse/HIVE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927538#comment-16927538 ] Hive QA commented on HIVE-22182: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 36s{color} | {color:blue} ql in master has 2244 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} ql: The patch generated 0 new + 464 unchanged - 3 fixed = 464 total (was 467) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 16s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18537/dev-support/hive-personality.sh | | git revision | master / 5b1afb7 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18537/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > SemanticAnalyzer populates map which is not used at all > --- > > Key: HIVE-22182 > URL: https://issues.apache.org/jira/browse/HIVE-22182 > Project: Hive > Issue Type: Task > Components: Hive >Reporter: Akos Dombi >Assignee: Akos Dombi >Priority: Major > Attachments: HIVE-22182.patch > > > The {{SemanticAnalyzer}} class has two map fields which are populated but > never queried: > * {{topToTable}} > * {{topToTableProps}} > Last usage was removed in HIVE-11752. > h3. Purpose of this task > - Remove unused {{topToTable}} and {{topToTableProps}} fields -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22182) SemanticAnalyzer populates map which is not used at all
[ https://issues.apache.org/jira/browse/HIVE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927339#comment-16927339 ] Laszlo Bodor commented on HIVE-22182: - +1 > SemanticAnalyzer populates map which is not used at all > --- > > Key: HIVE-22182 > URL: https://issues.apache.org/jira/browse/HIVE-22182 > Project: Hive > Issue Type: Task > Components: Hive >Reporter: Akos Dombi >Assignee: Akos Dombi >Priority: Major > Attachments: HIVE-22182.patch > > > The {{SemanticAnalyzer}} class has two map fields which are populated but > never queried: > * {{topToTable}} > * {{topToTableProps}} > Last usage was removed in HIVE-11752. > h3. Purpose of this task > - Remove unused {{topToTable}} and {{topToTableProps}} fields -- This message was sent by Atlassian Jira (v8.3.2#803003)