[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[ https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991792#comment-16991792 ] Sam An commented on HIVE-22498: --- I clicked the ship it on review board. +1 here, too > Schema tool enhancements to merge catalogs > -- > > Key: HIVE-22498 > URL: https://issues.apache.org/jira/browse/HIVE-22498 > Project: Hive > Issue Type: Sub-task >Affects Versions: 4.0.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22498.2.patch, HIVE-22498.patch > > > Schema tool currently supports relocation of database from one catalog to > another, one at a time. While having to do this one at a time is painful, it > also lacks support for converting them to external tables during migration, > in lieu of the changes to the translation layer where a MANAGED table is > strictly ACID-only table. > Hence we also need to convert them to external tables during relocation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[ https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991719#comment-16991719 ] Naveen Gangam commented on HIVE-22498: -- [~ychena] [~samuelan] Could you please review the new version of this patch? Thank you > Schema tool enhancements to merge catalogs > -- > > Key: HIVE-22498 > URL: https://issues.apache.org/jira/browse/HIVE-22498 > Project: Hive > Issue Type: Sub-task >Affects Versions: 4.0.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22498.2.patch, HIVE-22498.patch > > > Schema tool currently supports relocation of database from one catalog to > another, one at a time. While having to do this one at a time is painful, it > also lacks support for converting them to external tables during migration, > in lieu of the changes to the translation layer where a MANAGED table is > strictly ACID-only table. > Hence we also need to convert them to external tables during relocation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990618#comment-16990618
]
Hive QA commented on HIVE-22498:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987771/HIVE-22498.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17762 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19798/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19798/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19798/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12987771 - PreCommit-HIVE-Build
> Schema tool enhancements to merge catalogs
> --
>
> Key: HIVE-22498
> URL: https://issues.apache.org/jira/browse/HIVE-22498
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-22498.2.patch, HIVE-22498.patch
>
>
> Schema tool currently supports relocation of database from one catalog to
> another, one at a time. While having to do this one at a time is painful, it
> also lacks support for converting them to external tables during migration,
> in lieu of the changes to the translation layer where a MANAGED table is
> strictly ACID-only table.
> Hence we also need to convert them to external tables during relocation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990596#comment-16990596
]
Hive QA commented on HIVE-22498:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
10s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 8 new + 36 unchanged - 0 fixed = 44 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
25s{color} | {color:red} standalone-metastore/metastore-server generated 4 new
+ 179 unchanged - 0 fixed = 183 total (was 179) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
invokes System.exit(...), which shuts down the entire virtual machine At
SchemaToolTaskMergeCatalog.java:down the entire virtual machine At
SchemaToolTaskMergeCatalog.java:[line 85] |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to clean up java.sql.ResultSet Obligation to clean up resource
created at SchemaToolTaskMergeCatalog.java:up java.sql.ResultSet Obligation to
clean up resource created at SchemaToolTaskMergeCatalog.java:[line 74] is not
discharged |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to clean up java.sql.Statement Obligation to clean up resource
created at SchemaToolTaskMergeCatalog.java:up java.sql.Statement Obligation to
clean up resource created at SchemaToolTaskMergeCatalog.java:[line 66] is not
discharged |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to close Statement At SchemaToolTaskMergeCatalog.java:Statement At
SchemaToolTaskMergeCatalog.java:[line 66] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19798/dev-support/hive-personality.sh
|
| git revision | master / a245e79 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19798/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19798/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19798/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore
[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975158#comment-16975158
]
Hive QA commented on HIVE-22498:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12985906/HIVE-22498.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17706 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb_schq]
(batchId=177)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=284)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19439/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19439/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19439/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12985906 - PreCommit-HIVE-Build
> Schema tool enhancements to merge catalogs
> --
>
> Key: HIVE-22498
> URL: https://issues.apache.org/jira/browse/HIVE-22498
> Project: Hive
> Issue Type: Sub-task
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-22498.patch
>
>
> Schema tool currently supports relocation of database from one catalog to
> another, one at a time. While having to do this one at a time is painful, it
> also lacks support for converting them to external tables during migration,
> in lieu of the changes to the translation layer where a MANAGED table is
> strictly ACID-only table.
> Hence we also need to convert them to external tables during relocation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22498) Schema tool enhancements to merge catalogs
[
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975112#comment-16975112
]
Hive QA commented on HIVE-22498:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
13s{color} | {color:blue} standalone-metastore/metastore-server in master has
178 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 8 new + 36 unchanged - 0 fixed = 44 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
24s{color} | {color:red} standalone-metastore/metastore-server generated 4 new
+ 178 unchanged - 0 fixed = 182 total (was 178) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
invokes System.exit(...), which shuts down the entire virtual machine At
SchemaToolTaskMergeCatalog.java:down the entire virtual machine At
SchemaToolTaskMergeCatalog.java:[line 85] |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to clean up java.sql.ResultSet Obligation to clean up resource
created at SchemaToolTaskMergeCatalog.java:up java.sql.ResultSet Obligation to
clean up resource created at SchemaToolTaskMergeCatalog.java:[line 74] is not
discharged |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to clean up java.sql.Statement Obligation to clean up resource
created at SchemaToolTaskMergeCatalog.java:up java.sql.Statement Obligation to
clean up resource created at SchemaToolTaskMergeCatalog.java:[line 66] is not
discharged |
| |
org.apache.hadoop.hive.metastore.tools.schematool.SchemaToolTaskMergeCatalog.execute()
may fail to close Statement At SchemaToolTaskMergeCatalog.java:Statement At
SchemaToolTaskMergeCatalog.java:[line 66] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19439/dev-support/hive-personality.sh
|
| git revision | master / 078182a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19439/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19439/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19439/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore
