[jira] [Commented] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version
[
https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018190#comment-17018190
]
Hive QA commented on HIVE-22739:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
14s{color} | {color:blue} standalone-metastore/metastore-server in master has
181 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20229/dev-support/hive-personality.sh
|
| git revision | master / f7d52d7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20229/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Schematool should check if upgradeFrom version is identical to current DB
> schema version
>
>
> Key: HIVE-22739
> URL: https://issues.apache.org/jira/browse/HIVE-22739
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-22739.1.patch
>
>
> Schematool should check if upgradeFrom version is identical to current DB
> schema version.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41
> We should check if the user input fromVersion is identical to current DB
> version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version
[ https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018192#comment-17018192 ] Alice Fan commented on HIVE-22739: -- Hi [~ngangam], Can you please help to review the change? Thanks! > Schematool should check if upgradeFrom version is identical to current DB > schema version > > > Key: HIVE-22739 > URL: https://issues.apache.org/jira/browse/HIVE-22739 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-22739.1.patch > > > Schematool should check if upgradeFrom version is identical to current DB > schema version. > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41 > We should check if the user input fromVersion is identical to current DB > version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version
[
https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018224#comment-17018224
]
Hive QA commented on HIVE-22739:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991197/HIVE-22739.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17877 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20229/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20229/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20229/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12991197 - PreCommit-HIVE-Build
> Schematool should check if upgradeFrom version is identical to current DB
> schema version
>
>
> Key: HIVE-22739
> URL: https://issues.apache.org/jira/browse/HIVE-22739
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Alice Fan
>Assignee: Alice Fan
>Priority: Major
> Attachments: HIVE-22739.1.patch
>
>
> Schematool should check if upgradeFrom version is identical to current DB
> schema version.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41
> We should check if the user input fromVersion is identical to current DB
> version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version
[ https://issues.apache.org/jira/browse/HIVE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024352#comment-17024352 ] Naveen Gangam commented on HIVE-22739: -- Change looks good to me. +1. > Schematool should check if upgradeFrom version is identical to current DB > schema version > > > Key: HIVE-22739 > URL: https://issues.apache.org/jira/browse/HIVE-22739 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Alice Fan >Assignee: Alice Fan >Priority: Major > Attachments: HIVE-22739.1.patch > > > Schematool should check if upgradeFrom version is identical to current DB > schema version. > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41 > We should check if the user input fromVersion is identical to current DB > version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
