[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[ https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025411#comment-17025411 ] László Bodor commented on HIVE-22770: - okay, this way, MapWorkSerializer makes no sense anymore, removed that also: [^HIVE-22770.06.patch] > Skip interning of MapWork fields for tez during deserialization > --- > > Key: HIVE-22770 > URL: https://issues.apache.org/jira/browse/HIVE-22770 > Project: Hive > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch, > HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch, > HIVE-22770.04.patch, HIVE-22770.05.patch, HIVE-22770.06.patch > > > HIVE-19937 introduced some interning logic into mapwork deserialization > process, but it's only related to spark, maybe we should skip this for tez, > reducing the cpu pressure in tez tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025406#comment-17025406
]
Hive QA commented on HIVE-22770:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12992033/HIVE-22770.05.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17954 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[results_cache_invalidation2]
(batchId=175)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20384/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20384/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20384/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12992033 - PreCommit-HIVE-Build
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch,
> HIVE-22770.04.patch, HIVE-22770.05.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[ https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025389#comment-17025389 ] Ashutosh Chauhan commented on HIVE-22770: - Can you please remove internFields() This method has no callers. Also, remove passing around Configuration object to different methods. That change is not useful anymore either. > Skip interning of MapWork fields for tez during deserialization > --- > > Key: HIVE-22770 > URL: https://issues.apache.org/jira/browse/HIVE-22770 > Project: Hive > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch, > HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch, > HIVE-22770.04.patch, HIVE-22770.05.patch > > > HIVE-19937 introduced some interning logic into mapwork deserialization > process, but it's only related to spark, maybe we should skip this for tez, > reducing the cpu pressure in tez tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025375#comment-17025375
]
Hive QA commented on HIVE-22770:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
30s{color} | {color:blue} ql in master has 1538 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20384/dev-support/hive-personality.sh
|
| git revision | master / 89c275e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20384/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch,
> HIVE-22770.04.patch, HIVE-22770.05.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[ https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025130#comment-17025130 ] László Bodor commented on HIVE-22770: - could you please take a look [~ashutoshc]? if it's okay, I'll merge it after the first green run... > Skip interning of MapWork fields for tez during deserialization > --- > > Key: HIVE-22770 > URL: https://issues.apache.org/jira/browse/HIVE-22770 > Project: Hive > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch, > HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch, > HIVE-22770.04.patch, HIVE-22770.05.patch > > > HIVE-19937 introduced some interning logic into mapwork deserialization > process, but it's only related to spark, maybe we should skip this for tez, > reducing the cpu pressure in tez tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025118#comment-17025118
]
Hive QA commented on HIVE-22770:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12992000/HIVE-22770.04.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17953 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestGetPartitionsUsingProjectionAndFilterSpecs.testGetPartitionsUsingValuesWithJDO
(batchId=231)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20378/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20378/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20378/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12992000 - PreCommit-HIVE-Build
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch,
> HIVE-22770.04.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025090#comment-17025090
]
Hive QA commented on HIVE-22770:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
50s{color} | {color:blue} ql in master has 1538 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 1 new + 162 unchanged - 0
fixed = 163 total (was 162) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20378/dev-support/hive-personality.sh
|
| git revision | master / 22f5ab5 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20378/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20378/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch,
> HIVE-22770.04.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024707#comment-17024707
]
Hive QA commented on HIVE-22770:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991934/HIVE-22770.03.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20367/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20367/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20367/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12991934/HIVE-22770.03.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12991934 - PreCommit-HIVE-Build
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024625#comment-17024625
]
Hive QA commented on HIVE-22770:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
55s{color} | {color:blue} ql in master has 1538 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 1 new + 162 unchanged - 0
fixed = 163 total (was 162) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
7s{color} | {color:red} ql generated 1 new + 1538 unchanged - 0 fixed = 1539
total (was 1538) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 51s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:[line 307] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20364/dev-support/hive-personality.sh
|
| git revision | master / b7650eb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20364/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20364/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20364/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch, HIVE-22770.03.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024468#comment-17024468
]
Ashutosh Chauhan commented on HIVE-22770:
-
Configuration conf = ((KryoWithHooks) kryo).getConf();
+ if (conf != null &&
conf.get(HiveConf.ConfVars.HIVE_EXECUTION_ENGINE.varname,
"").equalsIgnoreCase("spark")) {
+mapWork.internFields();
+ }
+
Lets remove above code block. With that removed we won't need {{new
Configuration}} which is an expensive call. That means we will never intern
fields.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch, HIVE-22770.02.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024403#comment-17024403
]
Hive QA commented on HIVE-22770:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12991890/HIVE-22770.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17946 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query32]
(batchId=303)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20356/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20356/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20356/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12991890 - PreCommit-HIVE-Build
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024361#comment-17024361
]
Hive QA commented on HIVE-22770:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
42s{color} | {color:blue} ql in master has 1533 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
55s{color} | {color:red} ql generated 1 new + 1533 unchanged - 0 fixed = 1534
total (was 1533) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At SerializationUtilities.java:[line 599] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20356/dev-support/hive-personality.sh
|
| git revision | master / 7bb1d1e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20356/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20356/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch,
> HIVE-22770.02.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this for tez,
> reducing the cpu pressure in tez tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024212#comment-17024212
]
Hive QA commented on HIVE-22770:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
47s{color} | {color:blue} ql in master has 1533 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
3s{color} | {color:red} ql generated 2 new + 1533 unchanged - 0 fixed = 1535
total (was 1533) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:[line 307] |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At SerializationUtilities.java:[line 600] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20351/dev-support/hive-personality.sh
|
| git revision | master / 037eace |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20351/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20351/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch, HIVE-22770.01.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe
[jira] [Commented] (HIVE-22770) Skip interning of MapWork fields for tez during deserialization
[
https://issues.apache.org/jira/browse/HIVE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023167#comment-17023167
]
Hive QA commented on HIVE-22770:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
17s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
25s{color} | {color:red} ql generated 2 new + 1532 unchanged - 0 fixed = 1534
total (was 1532) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in org.apache.hadoop.hive.ql.exec.SerializationUtilities.releaseKryo(Kryo) At
SerializationUtilities.java:[line 307] |
| | Unchecked/unconfirmed cast from com.esotericsoftware.kryo.Kryo to
org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At
SerializationUtilities.java:org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks
in
org.apache.hadoop.hive.ql.exec.SerializationUtilities$MapWorkSerializer.read(Kryo,
Input, Class) At SerializationUtilities.java:[line 600] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20322/dev-support/hive-personality.sh
|
| git revision | master / a344426 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20322/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20322/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Skip interning of MapWork fields for tez during deserialization
> ---
>
> Key: HIVE-22770
> URL: https://issues.apache.org/jira/browse/HIVE-22770
> Project: Hive
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22770.01.patch
>
>
> HIVE-19937 introduced some interning logic into mapwork deserialization
> process, but it's only related to spark, maybe we should skip this
