[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119926#comment-17119926 ] Hive QA commented on HIVE-23068: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13004372/HIVE-23068.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17219 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22689/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22689/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22689/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13004372 - PreCommit-HIVE-Build > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch, HIVE-23068.2.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndUpstreamParallelism= > 2132, selfAndUpstreamComplete= 0} > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo$FinishableStateTracker.registerForUpdates(QueryInfo.java:233) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo.registerForFinishableStateUpdates(QueryInfo.java:205) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryFragmentInfo.registerForFinishableStateUpdates(QueryFragmentInfo.java:160) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$TaskWrapper.maybeRegisterForFinishedStateNotifications(TaskExecutorService.java:1167) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:564) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:93) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl.submitWork(ContainerRunnerImpl.java:292) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.submitWork(LlapDaemon.java:610) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapProtocolServerImpl.submitWork(LlapProtocolServerImpl.java:122) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$LlapDaemonProtocol$2.callBlockingMethod(LlapDaemonProtocolProtos.java:22695) > ~[hive-exec-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.32-1] > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:82
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119906#comment-17119906 ] Hive QA commented on HIVE-23068: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 40s{color} | {color:blue} llap-server in master has 88 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} llap-server: The patch generated 4 new + 16 unchanged - 0 fixed = 20 total (was 16) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 46s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22689/dev-support/hive-personality.sh | | git revision | master / 8443e50 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22689/yetus/diff-checkstyle-llap-server.txt | | modules | C: llap-server U: llap-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22689/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch, HIVE-23068.2.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParalle
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119791#comment-17119791 ] Jason Dere commented on HIVE-23068: --- Not totally sure about what the fragment ID looks like during speculative execution, but I think the external client during some of its retry logic might be sending the same fragment ID (which it should not do). I'll resubmit the patch to try to get a clean precommit run. > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndUpstreamParallelism= > 2132, selfAndUpstreamComplete= 0} > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo$FinishableStateTracker.registerForUpdates(QueryInfo.java:233) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo.registerForFinishableStateUpdates(QueryInfo.java:205) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryFragmentInfo.registerForFinishableStateUpdates(QueryFragmentInfo.java:160) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$TaskWrapper.maybeRegisterForFinishedStateNotifications(TaskExecutorService.java:1167) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:564) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:93) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl.submitWork(ContainerRunnerImpl.java:292) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.submitWork(LlapDaemon.java:610) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapProtocolServerImpl.submitWork(LlapProtocolServerImpl.java:122) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$LlapDaemonProtocol$2.callBlockingMethod(LlapDaemonProtocolProtos.java:22695) > ~[hive-exec-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.32-1] > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at java.security.AccessController.doPrivileged(Native Method) > ~[?:1.8.0_191] > at javax.security.auth.Subject.doAs(Subject.java:422) ~[?:1.8.0_191] > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > {noformat} > I think the issue here is that this error occurred too late - based on the > stack trace, LLAP has already accepted/registered the fragment. The > subsequent clea
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119742#comment-17119742 ] Prasanth Jayachandran commented on HIVE-23068: -- lgtm, +1. {quote}(for example speculative execution of a query fragment). {quote} Can external clients with speculative execution generate the same fragment id? Not sure how external clients generates the full id but I would expect it to have different attempt numbers atleast just so that the different attempts does not step on each other during speculative execution. > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndUpstreamParallelism= > 2132, selfAndUpstreamComplete= 0} > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo$FinishableStateTracker.registerForUpdates(QueryInfo.java:233) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo.registerForFinishableStateUpdates(QueryInfo.java:205) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryFragmentInfo.registerForFinishableStateUpdates(QueryFragmentInfo.java:160) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$TaskWrapper.maybeRegisterForFinishedStateNotifications(TaskExecutorService.java:1167) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:564) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:93) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl.submitWork(ContainerRunnerImpl.java:292) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.submitWork(LlapDaemon.java:610) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapProtocolServerImpl.submitWork(LlapProtocolServerImpl.java:122) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$LlapDaemonProtocol$2.callBlockingMethod(LlapDaemonProtocolProtos.java:22695) > ~[hive-exec-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.32-1] > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at java.security.AccessController.doPrivileged(Native Method) > ~[?:1.8.0_191] > at javax.security.auth.Subject.doAs(Subject.java:422) ~[?:1.8.0_191] > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > {noformat} > I think the issue here is that this error o
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119203#comment-17119203 ] Hive QA commented on HIVE-23068: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12997500/HIVE-23068.1.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17290 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.daemon.impl.TestContainerRunnerImpl.testSubmitSameFragment (batchId=313) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22679/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22679/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22679/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12997500 - PreCommit-HIVE-Build > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndUpstreamParallelism= > 2132, selfAndUpstreamComplete= 0} > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo$FinishableStateTracker.registerForUpdates(QueryInfo.java:233) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo.registerForFinishableStateUpdates(QueryInfo.java:205) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryFragmentInfo.registerForFinishableStateUpdates(QueryFragmentInfo.java:160) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$TaskWrapper.maybeRegisterForFinishedStateNotifications(TaskExecutorService.java:1167) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:564) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:93) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl.submitWork(ContainerRunnerImpl.java:292) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.submitWork(LlapDaemon.java:610) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapProtocolServerImpl.submitWork(LlapProtocolServerImpl.java:122) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$LlapDaemonProtocol$2.callBlockingMethod(LlapDaemonProtocolProtos.java:22695) > ~[hive-exec-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.32-1] > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) > ~[hadoop-comm
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119194#comment-17119194 ] Hive QA commented on HIVE-23068: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 43s{color} | {color:blue} llap-server in master has 88 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} llap-server: The patch generated 4 new + 16 unchanged - 0 fixed = 20 total (was 16) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 56s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22679/dev-support/hive-personality.sh | | git revision | master / 934faa7 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22679/yetus/diff-checkstyle-llap-server.txt | | modules | C: llap-server U: llap-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22679/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23068.1.patch > > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndU
[jira] [Commented] (HIVE-23068) Error when submitting fragment to LLAP via external client: IllegalStateException: Only a single registration allowed per entity
[ https://issues.apache.org/jira/browse/HIVE-23068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065170#comment-17065170 ] Jason Dere commented on HIVE-23068: --- Ideally the duplicate fragment/attempt request should fail at a point where it does not have to invoke fragmentComplete()/unregisterFragment(), which may have bad effects on the first request that was already submitted. > Error when submitting fragment to LLAP via external client: > IllegalStateException: Only a single registration allowed per entity > > > Key: HIVE-23068 > URL: https://issues.apache.org/jira/browse/HIVE-23068 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > > LLAP external client (via hive-warehouse-connector) somehow seems to be > sending duplicate submissions for the same fragment/attempt. When the 2nd > request is sent this results in the following error: > {noformat} > 2020-03-17T06:49:11,239 WARN [IPC Server handler 2 on 15001 ()] > org.apache.hadoop.ipc.Server: IPC Server handler 2 on 15001, call Call#75 > Retry#0 > org.apache.hadoop.hive.llap.protocol.LlapProtocolBlockingPB.submitWork from > 19.40.252.114:33906 > java.lang.IllegalStateException: Only a single registration allowed per > entity. Duplicate for > TaskWrapper{task=attempt_1854104024183112753_6052_0_00_000128_1, > inWaitQueue=true, inPreemptionQueue=false, registeredForNotifications=true, > canFinish=true, canFinish(in queue)=true, isGuaranteed=false, > firstAttemptStartTime=1584442003327, dagStartTime=1584442003327, > withinDagPriority=0, vertexParallelism= 2132, selfAndUpstreamParallelism= > 2132, selfAndUpstreamComplete= 0} > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo$FinishableStateTracker.registerForUpdates(QueryInfo.java:233) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryInfo.registerForFinishableStateUpdates(QueryInfo.java:205) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.QueryFragmentInfo.registerForFinishableStateUpdates(QueryFragmentInfo.java:160) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$TaskWrapper.maybeRegisterForFinishedStateNotifications(TaskExecutorService.java:1167) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:564) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.schedule(TaskExecutorService.java:93) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl.submitWork(ContainerRunnerImpl.java:292) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.submitWork(LlapDaemon.java:610) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.impl.LlapProtocolServerImpl.submitWork(LlapProtocolServerImpl.java:122) > ~[hive-llap-server-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.26-3] > at > org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$LlapDaemonProtocol$2.callBlockingMethod(LlapDaemonProtocolProtos.java:22695) > ~[hive-exec-3.1.0.3.1.4.26-3.jar:3.1.0.3.1.4.32-1] > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at java.security.AccessController.doPrivileged(Native Method) > ~[?:1.8.0_191] > at javax.security.auth.Subject.doAs(Subject.java:422) ~[?:1.8.0_191] > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682) > ~[hadoop-common-3.1.1.3.1.4.26-3.jar:?] > {noformat} > I think the issue here is that this error occurred too late - based on the > stack trace, LLAP has already accepted/registered the fragment. The > subsequent cleanup of this fragment/attempt also affects the first request. > Which results in the LLAP crash de