subject:"\[jira\] \[Commented\] \(HIVE\-23100\) Create RexNode factory and use it in CalcitePlanner"

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-19 Thread Zoltan Haindrich (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087162#comment-17087162
 ] 

Zoltan Haindrich commented on HIVE-23100:
-

+1

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.09.patch, HIVE-23100.10.patch, HIVE-23100.11.patch, 
> HIVE-23100.12.patch, HIVE-23100.13.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-19 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086827#comment-17086827
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000400/HIVE-23100.13.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17139 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21766/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21766/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21766/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000400 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.09.patch, HIVE-23100.10.patch, HIVE-23100.11.patch, 
> HIVE-23100.12.patch, HIVE-23100.13.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-19 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086822#comment-17086822
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
54s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
57s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
52s{color} | {color:blue} itests/util in master has 53 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
54s{color} | {color:red} ql: The patch generated 110 new + 988 unchanged - 44 
fixed = 1098 total (was 1032) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
15s{color} | {color:red} itests/util: The patch generated 1 new + 36 unchanged 
- 0 fixed = 37 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
9s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 52s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 409] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 375] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeE

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-18 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086737#comment-17086737
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000391/HIVE-23100.12.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 17139 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_2]
 (batchId=108)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=170)
org.apache.hadoop.hive.metastore.TestMetastoreHousekeepingLeaderEmptyConfig.testHouseKeepingThreadExistence
 (batchId=174)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21763/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21763/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21763/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000391 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.09.patch, HIVE-23100.10.patch, HIVE-23100.11.patch, 
> HIVE-23100.12.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-18 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086734#comment-17086734
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 8s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
53s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
54s{color} | {color:blue} itests/util in master has 53 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
59s{color} | {color:red} ql: The patch generated 110 new + 988 unchanged - 44 
fixed = 1098 total (was 1032) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
16s{color} | {color:red} itests/util: The patch generated 1 new + 36 unchanged 
- 0 fixed = 37 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
7s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 29s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 409] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 375] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeE

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-18 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086386#comment-17086386
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000314/HIVE-23100.11.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21741/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21741/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21741/

Messages:
{noformat}
 This message was trimmed, see log for full details 
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCExpandExpressionsRule.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/LBProcFactory.java:
 does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/DruidSqlOperatorConverter.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/ExprFactory.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/ExprNodeDescExprFactory.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/ExprNodeTypeCheck.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/JoinCondTypeCheckProcFactory.java:
 does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckCtx.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactoryUtils.java:
 does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java: does 
not exist in index
error: 
a/ql/src/test/org/apache/hadoop/hive/ql/parse/type/TestTypeCheckProcFactory.java:
 does not exist in index
error: 
a/ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java: 
does not exist in index
error: a/ql/src/test/org/apache/hadoop/hive/ql/testutil/BaseScalarUdfTest.java: 
does not exist in index
error: 
a/ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFConcat.java: 
does not exist in index
error: 
a/ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRound.java: 
does not exist in index
error: a/ql/src/test/queries/clientpositive/partition_coltype_literals.q: does 
not exist in index
error: a/ql/src/test/results/clientpositive/alter_partition_coltype.q.out: does 
not exist in index
error: a/ql/src/test/results/clientpositive/avrotblsjoin.q.out: does not exist 
in index
error: a/ql/src/test/results/clientpositive/collision.q.out: does not exist in 
index
error: a/ql/src/test/results/clientpositive/constprog_cast.q.out: does not 
exist in index
error: a/ql/src/test/results/clientpositive/decimal_precision2.q.out: does not 
exist in index
error: a/ql/src/test/results/clientpositive/druid/druid_timeseries.q.out: does 
not exist in index
error: a/ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out: 
does not exist in index
error: 
a/ql/src/test/results/clientpositive/groupby_multi_single_reducer3.q.out: does 
not exist in index
error: a/ql/src/test/results/clientpositive/in_typecheck_char.q.out: does not 
exist in index
error: a/ql/src/test/results/clientpositive/in_typecheck_varchar.q.out: does 
not exist in index
error: a/ql/src/test/results/clientpositive/infer_const_type.q.out: does not 
exist in index
error: a/ql/src/test/results/clientpositive/llap/cbo_limit.q.out: does not 
exist in index
error: a/ql/src/test/results/clientpositive/llap/check_constraint.q.out: does 
not exist in index
error: 
a/ql/src/test/results/clientpositive/llap/constraints_optimization.q.out: does 
not exist in index
error: 
a/ql/src/test/results/clientpositive/llap/identity_project_remov

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-17 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085921#comment-17085921
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000220/HIVE-23100.10.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17130 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=6)
org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testDropPartitionsWithPurge 
(batchId=263)
org.apache.hadoop.hive.ql.parse.TestScheduledReplicationScenarios.testAcidTablesReplLoadBootstrapIncr
 (batchId=204)
org.apache.hive.service.auth.TestImproperTrustDomainAuthenticationHttp.org.apache.hive.service.auth.TestImproperTrustDomainAuthenticationHttp
 (batchId=208)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21724/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21724/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21724/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000220 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.09.patch, HIVE-23100.10.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-17 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085897#comment-17085897
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
35s{color} | {color:blue} ql in master has 1529 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
47s{color} | {color:red} ql: The patch generated 110 new + 988 unchanged - 44 
fixed = 1098 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
47s{color} | {color:red} ql generated 7 new + 1524 unchanged - 5 fixed = 1531 
total (was 1529) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 46s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 409] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 375] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  At 
RexNodeExprF

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-11 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081603#comment-17081603
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999611/HIVE-23100.09.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18211 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21575/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21575/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21575/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12999611 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.09.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-11 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081598#comment-17081598
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
45s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
50s{color} | {color:red} ql: The patch generated 108 new + 991 unchanged - 41 
fixed = 1099 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
54s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 14s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  A

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-10 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1708#comment-1708
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999496/HIVE-23100.08.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 18211 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_14]
 (batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce] 
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_14] 
(batchId=17)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_14]
 (batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_short_regress]
 (batchId=182)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_14]
 (batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_14] 
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress]
 (batchId=141)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21557/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21557/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21557/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12999496 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch, 
> HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-10 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081101#comment-17081101
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
44s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
50s{color} | {color:red} ql: The patch generated 109 new + 990 unchanged - 42 
fixed = 1099 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
0s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 13s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  A

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-08 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078266#comment-17078266
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999284/HIVE-23100.07.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 18195 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
org.apache.hadoop.hive.ql.plan.mapping.TestCounterMapping.testBreakupAnd2 
(batchId=360)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21511/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21511/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21511/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12999284 - PreCommit-HIVE-Build

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-08 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078231#comment-17078231
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
52s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
53s{color} | {color:red} ql: The patch generated 289 new + 985 unchanged - 47 
fixed = 1274 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  
0s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 21s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 425] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  A

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-07 Thread Jesus Camacho Rodriguez (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077759#comment-17077759
 ] 

Jesus Camacho Rodriguez commented on HIVE-23100:


This patch became larger than expected. I have tried to keep some work out of 
it to prevent it from growing even larger, e.g., there is some logic in 
{{RexConverter}} that is possibly not needed anymore or some further 
refactoring that could be done in {{CalcitePlanner}}. My goal was to land this 
big block first and then tackle all those issues in smaller follow-ups.
The main new component is the {{RexNodeExprFactory}} that mimics 
{{ExprNodeDescFactory}} functionality but produces/works with {{RexNode}} 
objects. {{RexNodeExprFactory}} relies on a {{FunctionHelper}} implementation 
to get function information, adapt inputs according to that function, or 
generate the final {{RexCall}} node that represents the expression. There are 
multiple changes in the patch related to issues that had to be worked through, 
e.g., related to the type system differences between Hive and Calcite 
expressions. Additionally, the patch exposes CALCITE-3898 (I uploaded a patch 
for that issue too).

PR in in https://github.com/apache/hive/pull/970. [~vgarg], [~kgyrtkirk], could 
you take a look? Thanks

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch, 
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch, 
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-07 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077509#comment-17077509
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999197/HIVE-23100.06.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 278 failed/errored test(s), 18195 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown]
 (batchId=299)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_udaf_percentile_approx_23]
 (batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[collision] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[date_timestamp_prec] 
(batchId=104)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[deleteAnalyze] 
(batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_case] (batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_eq_with_case_when] 
(batchId=95)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_when] (batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[foldts] (batchId=66)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby13] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_id1] 
(batchId=98)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets_grouping]
 (batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets_view]
 (batchId=79)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_join_preds] 
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[innerjoin1] (batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_lazyserde2] 
(batchId=93)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_lazyserde] 
(batchId=31)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[intersect_all_rj] 
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join_cond_pushdown_unqual5]
 (batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge_test_dummy_operator]
 (batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[multi_insert_with_join2] 
(batchId=91)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_10]
 (batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pcs] (batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_gby_join] 
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join2] (batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join3] (batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join] (batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin4] (batchId=100)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin5] (batchId=18)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[type_widening] 
(batchId=53)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_percentile_approx_23]
 (batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_to_unix_timestamp] 
(batchId=65)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_width_bucket] 
(batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_offcbo] 
(batchId=52)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_between_columns] 
(batchId=80)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_1] 
(batchId=98)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_2] 
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce] 
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_2] 
(batchId=83)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_3] 
(batchId=66)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_4] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_10] 
(batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_sum_if_when]
 (batchId=93)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_case] 
(batchId=67)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_decimal64_boundary]
 (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[view_cast] (batchId=47)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key2] 
(batchId=111)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key3] 
(batchId=110)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_ppd_key_range]
 (batchId=111)
org.apache.hadoop.hive.cli.TestHBaseCl

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-07 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077493#comment-17077493
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
43s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
32s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
51s{color} | {color:red} ql: The patch generated 289 new + 985 unchanged - 47 
fixed = 1274 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
46s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 51s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 426] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExp

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-05 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075975#comment-17075975
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998973/HIVE-23100.05.patch

{color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 155 failed/errored test(s), 18171 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[collision] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_multi_single_reducer3]
 (batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[in_typecheck_char] 
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[in_typecheck_varchar] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stat_estimate_related_col]
 (batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[structin] (batchId=37)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[case_with_row_sequence]
 (batchId=304)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key2] 
(batchId=111)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key3] 
(batchId=110)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timeseries]
 (batchId=205)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_expressions]
 (batchId=205)
org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic]
 (batchId=307)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez2]
 (batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint]
 (batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_table_perf]
 (batchId=192)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_in]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_identity_reuse]
 (batchId=187)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_limit] 
(batchId=159)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_multi_single_reducer3]
 (batchId=140)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[identity_project_remove_skip]
 (batchId=141)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_10]
 (batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_gby_join] 
(batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join2] 
(batchId=137)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join3] 
(batchId=126)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join] 
(batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join_filter] 
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_views] 
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_between_in] 
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_10] 
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress]
 (batchId=141)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query34] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query73] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query85] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query89] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query8] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query91] 
(batchId=309)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query10] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query11] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query12] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query13] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query15] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query16] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query17] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query18] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query20] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query21] 
(batchId=307)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-05 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075962#comment-17075962
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
48s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
49s{color} | {color:red} ql: The patch generated 250 new + 921 unchanged - 46 
fixed = 1171 total (was 967) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
55s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 43s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 382] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  At

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-04 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075109#comment-17075109
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998805/HIVE-23100.04.patch

{color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 134 failed/errored test(s), 18153 tests 
executed
*Failed tests:*
{noformat}
TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=307)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=307)
TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=307)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_cast] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[distinct_groupby] 
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_in_or_dup] 
(batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[identity_project_remove_skip]
 (batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[in_typecheck_mixed] 
(batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join45] (batchId=23)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join47] (batchId=37)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin47] (batchId=69)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin2] (batchId=63)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_const] 
(batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_non_constant_in_expr]
 (batchId=88)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[case_with_row_sequence]
 (batchId=304)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key2] 
(batchId=111)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key3] 
(batchId=110)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timeseries]
 (batchId=205)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_expressions]
 (batchId=205)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test_ts]
 (batchId=205)
org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic]
 (batchId=307)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_llap_counters1]
 (batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_llap_counters]
 (batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] 
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
 (batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez2]
 (batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[identity_project_remove_skip]
 (batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_ALL]
 (batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_ANY]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_assertion_type]
 (batchId=173)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[udf_in] 
(batchId=107)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket_map_join_tez2]
 (batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_limit] 
(batchId=159)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[identity_project_remove_skip]
 (batchId=141)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_10]
 (batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_gby_join] 
(batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join2] 
(batchId=137)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join3] 
(batchId=126)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join] 
(batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join_filter] 
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_views] 
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_10] 
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress]
 (batchId=141)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query13] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query34] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query48] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query73] 
(batchId=309)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query85] 
(batch

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-04-04 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075104#comment-17075104
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  5m 
41s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
9s{color} | {color:red} ql: The patch generated 251 new + 921 unchanged - 44 
fixed = 1172 total (was 965) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
52s{color} | {color:red} ql generated 7 new + 1523 unchanged - 5 fixed = 1530 
total (was 1528) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 35s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 408] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 374] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3389] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 367] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 213] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 224] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  At

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-03-28 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070057#comment-17070057
 ] 

Hive QA commented on HIVE-23100:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998118/HIVE-23100.patch

{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 608 failed/errored test(s), 18140 tests 
executed
*Failed tests:*
{noformat}
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=307)
TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=307)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_coltype] 
(batchId=30)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_select] 
(batchId=71)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avrotblsjoin] 
(batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cast_datetime_with_sql_2016_format]
 (batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_const] (batchId=20)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_udaf_percentile_approx_23]
 (batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_windowing] 
(batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[char_nested_types] 
(batchId=76)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[collision] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[concat_op] (batchId=86)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer8] 
(batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_genericudf] 
(batchId=38)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_struct_table] 
(batchId=21)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view] (batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_join] (batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision2] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_udf] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[deleteAnalyze] 
(batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_join_breaktask2] 
(batchId=88)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_numeric] 
(batchId=93)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_case] (batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_eq_with_case_when] 
(batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[foldts] (batchId=66)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby13] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_id1] 
(batchId=98)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_join_pushdown] 
(batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_multi_single_reducer3]
 (batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[hypothetical_set_aggregates]
 (batchId=102)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[implicit_cast_during_insert]
 (batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[in_typecheck_char] 
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[in_typecheck_varchar] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_map_operators]
 (batchId=76)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_const_type] 
(batchId=79)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_join_preds] 
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[innerjoin1] (batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[intersect_all_rj] 
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_1] (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_2] (batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_3] (batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_alt] (batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_arithmetic] 
(batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_comparison] 
(batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_udf] 
(batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join_cond_pushdown_unqual5]
 (batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join_literals] 
(batchId=102)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[json_serde1] (batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[json_serde2] (batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[keep_uniform] 
(ba

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-03-28 Thread Hive QA (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070047#comment-17070047
 ] 

Hive QA commented on HIVE-23100:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
44s{color} | {color:blue} ql in master has 1529 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
47s{color} | {color:red} ql: The patch generated 103 new + 787 unchanged - 31 
fixed = 890 total (was 818) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
59s{color} | {color:red} ql generated 7 new + 1524 unchanged - 5 fixed = 1531 
total (was 1529) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:work for negative numbers 
in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
 RelDataType, RexBuilder)  At RexNodeConverter.java:[line 462] |
|  |  Check for oddness that won't work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:work for negative numbers in 
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
 List, RexBuilder)  At RexNodeConverter.java:[line 428] |
|  |  Dead store to inputPosMap in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At 
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
 Map)  At CalcitePlanner.java:[line 3377] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
 boolean, String, List)  At HiveFunctionHelper.java:[line 295] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
  At RexNodeExprFactory.java:[line 211] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At 
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
  At RexNodeExprFactory.java:[line 222] |
|  |  org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString 
doesn't override org.apache.calcite.util.NlsString.equals(Object)  At

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

2020-03-28 Thread Jesus Camacho Rodriguez (Jira)



[ 
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070011#comment-17070011
 ] 

Jesus Camacho Rodriguez commented on HIVE-23100:


Uploaded initial patch to trigger ptest run.

> Create RexNode factory and use it in CalcitePlanner
> ---
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

[jira] [Commented] (HIVE-23100) Create RexNode factory and use it in CalcitePlanner

24 matches

Site Navigation

Mail list logo

Footer information