[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090451#comment-17090451 ] Denys Kuzmenko commented on HIVE-23103: --- +1 > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.12.patch, > HIVE-23103.12.patch, HIVE-23103.12.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090164#comment-17090164 ] Peter Vary commented on HIVE-23103: --- [~dkuzmenko]: Could you please review? > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.12.patch, > HIVE-23103.12.patch, HIVE-23103.12.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090096#comment-17090096 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000806/HIVE-23103.12.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17124 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21859/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21859/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21859/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13000806 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.12.patch, > HIVE-23103.12.patch, HIVE-23103.12.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090080#comment-17090080 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 57s{color} | {color:blue} standalone-metastore/metastore-server in master has 190 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 29s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 516 unchanged - 0 fixed = 517 total (was 516) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 25s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 20s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21859/dev-support/hive-personality.sh | | git revision | master / 7ff8bd0 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21859/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21859/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21859/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.12.patch, > HIVE-23103.12.patch, HIVE-23103.12.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not,
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088269#comment-17088269 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000574/HIVE-23103.11.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17134 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_llap_counters1] (batchId=57) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21812/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21812/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21812/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000574 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088256#comment-17088256 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 20s{color} | {color:blue} standalone-metastore/metastore-server in master has 190 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 516 unchanged - 0 fixed = 517 total (was 516) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 25s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 39s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21812/dev-support/hive-personality.sh | | git revision | master / 00423c1 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21812/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21812/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21812/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.11.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; >
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087792#comment-17087792 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000486/HIVE-23103.10.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17134 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query27] (batchId=228) org.apache.hadoop.hive.common.metrics.metrics2.TestCodahaleReportersConf.testNoFallback (batchId=244) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21799/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21799/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21799/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000486 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087758#comment-17087758 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 19s{color} | {color:blue} standalone-metastore/metastore-server in master has 191 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 22s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 518 unchanged - 0 fixed = 519 total (was 518) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 17s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 0s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21799/dev-support/hive-personality.sh | | git revision | master / 6a47f9e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21799/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21799/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21799/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.10.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087314#comment-17087314 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000452/HIVE-23103.09.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 43 failed/errored test(s), 17137 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] (batchId=37) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_par_vec_table_non_dictionary_encoding] (batchId=94) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[temp_table_multi_insert_partitioned] (batchId=106) org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testAcidOrcWritePreservesFieldNames (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testAcidWithSchemaEvolution (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testAlterTable (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testBucketCodec (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testBucketizedInputFormat (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testCompactWithDelete (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testDeleteEventsCompaction (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testDeleteIn (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testDynamicPartitionsMerge (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testDynamicPartitionsMerge2 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testETLSplitStrategyForACID (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testEmptyInTblproperties (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testFailHeartbeater (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testFailureOnAlteringTransactionalProperties (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testFileSystemUnCaching (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite1 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite2 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwriteWithSelfJoin (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge2 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge3 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMergeWithPredicate (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMultiInsert (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testMultiInsertStatement (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidInsert (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion02 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion2 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3 (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testOpenTxnsCounter (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcNoPPD (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcPPD (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testOriginalFileReaderWhenNonAcidConvertedToAcid (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testSchemaEvolutionCompaction (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testUpdateMixedCase (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.testValidTxnsBookkeeping (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.updateDeletePartitioned (batchId=273) org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner (batchId=273) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21786/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21786/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21786/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 43 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000452 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL:
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087299#comment-17087299 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 16s{color} | {color:blue} standalone-metastore/metastore-server in master has 191 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 24s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 518 unchanged - 0 fixed = 519 total (was 518) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 17s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21786/dev-support/hive-personality.sh | | git revision | master / 91a92e3 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21786/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21786/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21786/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.09.patch, > HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087132#comment-17087132 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000441/HIVE-23103.08.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17139 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_par_vec_table_non_dictionary_encoding] (batchId=93) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query14] (batchId=228) org.apache.hadoop.hive.ql.TestWarehouseExternalDir.org.apache.hadoop.hive.ql.TestWarehouseExternalDir (batchId=182) org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testExternalDefaultPaths (batchId=182) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21777/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21777/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21777/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000441 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087123#comment-17087123 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 22s{color} | {color:blue} standalone-metastore/metastore-server in master has 191 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 26s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 518 unchanged - 0 fixed = 519 total (was 518) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 40s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21777/dev-support/hive-personality.sh | | git revision | master / 4634cc4 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21777/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21777/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21777/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.08.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db.
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086678#comment-17086678 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000375/HIVE-23103.07.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17141 tests executed *Failed tests:* {noformat} org.apache.hive.beeline.hs2connection.TestBeelineWithUserHs2ConnectionFile.testBeelineConnectionSSL[0: tranportMode=all] (batchId=208) org.apache.hive.jdbc.TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServerZKTurnedOff (batchId=216) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21758/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21758/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21758/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000375 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086672#comment-17086672 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 23s{color} | {color:blue} standalone-metastore/metastore-server in master has 191 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 26s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 518 unchanged - 0 fixed = 519 total (was 518) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21758/dev-support/hive-personality.sh | | git revision | master / c3fb689 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21758/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21758/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21758/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.04.patch, HIVE-23103.05.patch, HIVE-23103.06.patch, > HIVE-23103.07.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086387#comment-17086387 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000319/HIVE-23103.06.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21742/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21742/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21742/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2020-04-18 09:08:46.618 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-21742/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-04-18 09:08:46.620 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 15ebf9e HIVE-23194 : Use Queue Instead of List for CollectOperator (David Mollitor via Ashutosh Chauhan) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 15ebf9e HIVE-23194 : Use Queue Instead of List for CollectOperator (David Mollitor via Ashutosh Chauhan) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-04-18 09:08:47.838 + rm -rf ../yetus_PreCommit-HIVE-Build-21742 + mkdir ../yetus_PreCommit-HIVE-Build-21742 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-21742 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21742/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 Going to apply patch with: git apply -p0 + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc6247308755754114112.exe, --version] libprotoc 2.6.1 protoc-jar: executing: [/tmp/protoc6247308755754114112.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 protoc-jar: executing: [/tmp/protoc3977630998860319135.exe, --version] libprotoc 2.6.1 ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java does not exist: must build /data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g org/apache/hadoop/hive/ql/parse/HiveLexer.g Output file /data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java does not exist: must build
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085924#comment-17085924 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000300/HIVE-23103.05.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21725/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21725/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21725/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2020-04-17 16:44:10.960 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-21725/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-04-17 16:44:10.963 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive 1610ef5..51dda9a master -> origin/master + git reset --hard HEAD HEAD is now at 1610ef5 HIVE-23218 : LlapRecordReader queue limit computation is not optimal (Ramesh Kumar via Ashutosh Chauhan) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at 51dda9a HIVE-23093: Create new metastore config value for jdbc max batch size (Marton Bod via Peter Vary) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-04-17 16:44:12.495 + rm -rf ../yetus_PreCommit-HIVE-Build-21725 + mkdir ../yetus_PreCommit-HIVE-Build-21725 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-21725 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21725/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 Going to apply patch with: git apply -p0 + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc2565435905194460973.exe, --version] libprotoc 2.6.1 protoc-jar: executing: [/tmp/protoc2565435905194460973.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 protoc-jar: executing: [/tmp/protoc5534756864747268167.exe, --version] libprotoc 2.6.1 ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java does not exist: must build /data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085357#comment-17085357 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13000177/HIVE-23103.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17128 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_memcheck] (batchId=33) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query27] (batchId=228) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21708/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21708/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21708/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13000177 - PreCommit-HIVE-Build > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085347#comment-17085347 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 13s{color} | {color:blue} standalone-metastore/metastore-server in master has 191 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 22s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 1 new + 517 unchanged - 0 fixed = 518 total (was 517) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21708/dev-support/hive-personality.sh | | git revision | master / 661e40a | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21708/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21708/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21708/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.03.patch, > HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084813#comment-17084813 ] Peter Vary commented on HIVE-23103: --- With the new changes batching will not be relevant for openTxns, but become relevant for commitTxn. Attaching the new patch, and the microbench results: {code} Baseline: Benchmark(dbProduct) (txnType) Mode Cnt Score Error Units TxnHandlerBenchRunner.commitTxn ORACLEDEFAULTss 100 42.988 ± 4.569 ms/op TxnHandlerBenchRunner.commitTxn ORACLE READ_ONLYss 100 45.029 ± 4.686 ms/op After patch: Benchmark(dbProduct) (txnType) Mode Cnt Score Error Units TxnHandlerBenchRunner.commitTxn ORACLEDEFAULTss 100 36.208 ± 3.869 ms/op TxnHandlerBenchRunner.commitTxn ORACLE READ_ONLYss 100 37.038 ± 3.746 ms/op {code} > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.02.patch, HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071493#comment-17071493 ] Hive QA commented on HIVE-23103: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12998250/HIVE-23103.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 179 failed/errored test(s), 18142 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testGetValidWriteIds (batchId=241) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testOpenTxnNotExcluded (batchId=241) org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxns (batchId=241) org.apache.hadoop.hive.metastore.client.TestDropPartitions.otherCatalog[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionArchivedPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionBogusCatalog[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameBogusCatalog[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameEmptyName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidNameFormat[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidNameNoValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameLessValue[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameMoreValue[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingDB[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingPart[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNullName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataAndPurgeExternalTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataAndPurge[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataNoPurge[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataPurge[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteData[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteParentDir[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyDB[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyPartVals[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyVal[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionExternalTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionLessValsInList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionMoreValsInList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingDB[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingPartVals[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNotDeleteDataPurge[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNotDeleteData[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullDB[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullPartDropOptions[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullPartVals[Remote] (batchId=230)
[jira] [Commented] (HIVE-23103) Oracle statement batching
[ https://issues.apache.org/jira/browse/HIVE-23103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071472#comment-17071472 ] Hive QA commented on HIVE-23103: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 11s{color} | {color:blue} standalone-metastore/metastore-server in master has 190 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 5 new + 577 unchanged - 0 fixed = 582 total (was 577) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21346/dev-support/hive-personality.sh | | git revision | master / d2ad5b0 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21346/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21346/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Oracle statement batching > - > > Key: HIVE-23103 > URL: https://issues.apache.org/jira/browse/HIVE-23103 > Project: Hive > Issue Type: Improvement > Components: Transactions >Reporter: Peter Vary >Assignee: Peter Vary >Priority: Major > Attachments: HIVE-23103.patch > > > Examine how to really get better performance for oracle statement batches. > [Oracle JDBC > doc|https://docs.oracle.com/cd/E11882_01/java.112/e16548/oraperf.htm#JJDBC28752] > describes: > {quote}The Oracle implementation of standard update batching does not > implement true batching for generic statements and callable statements. Even > though Oracle JDBC supports the use of standard batching for {{Statement}} > and {{CallableStatement}} objects, you are unlikely to see performance > improvement. > {quote} > I would look for connection properties to set, so it is handled anyway, or if > not, then use: > {code} > begin > query1; > query2; > query3; > end; > {code} > to we will have only a single roundtrip for the db. -- This message was sent by Atlassian Jira (v8.3.4#803005)