[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-07 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077457#comment-17077457
 ] 

David Mollitor commented on HIVE-23128:
---

I spoke with [~mgergely] directly.  His +1 is contingent on removing 
superfluous {{final}} keywords from the patch.

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch, 
> HIVE-23128.2.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-07 Thread Miklos Gergely (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077420#comment-17077420
 ] 

Miklos Gergely commented on HIVE-23128:
---

+1

 

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch, 
> HIVE-23128.2.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-07 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077354#comment-17077354
 ] 

David Mollitor commented on HIVE-23128:
---

[~kgyrtkirk] Speaking of dot (.) would you mind taking a look at this?

 

I've already been working with [~mgergely] internally a bit on this.

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch, 
> HIVE-23128.2.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-07 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076972#comment-17076972
 ] 

Hive QA commented on HIVE-23128:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999063/HIVE-23128.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 18171 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21483/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21483/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21483/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12999063 - PreCommit-HIVE-Build

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch, 
> HIVE-23128.2.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076944#comment-17076944
 ] 

Hive QA commented on HIVE-23128:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
41s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
39s{color} | {color:red} ql: The patch generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21483/dev-support/hive-personality.sh
 |
| git revision | master / 7122748 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21483/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21483/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch, 
> HIVE-23128.2.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-04 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075043#comment-17075043
 ] 

Hive QA commented on HIVE-23128:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998754/HIVE-23128.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18173 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query16]
 (batchId=307)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21433/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21433/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21433/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12998754 - PreCommit-HIVE-Build

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-03 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075036#comment-17075036
 ] 

Hive QA commented on HIVE-23128:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
34s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
40s{color} | {color:red} ql: The patch generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21433/dev-support/hive-personality.sh
 |
| git revision | master / e89995a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21433/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21433/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch, HIVE-23128.2.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian 

[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-02 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074135#comment-17074135
 ] 

Hive QA commented on HIVE-23128:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998653/HIVE-23128.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 18167 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[whroot_external1]
 (batchId=162)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.catalogPatternsDontWork[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.noSuchCatalog[Remote] 
(batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.tablesInDifferentCatalog[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaCaseSensitive[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullNoDbNoTbl[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyDb[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTbl[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTypes[Remote]
 (batchId=230)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMeta[Remote]
 (batchId=230)
org.apache.hadoop.hive.ql.security.TestStorageBasedMetastoreAuthorizationProvider.testSimplePrivileges
 (batchId=285)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21410/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21410/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21410/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12998653 - PreCommit-HIVE-Build

> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23128) SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified

2020-04-02 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074110#comment-17074110
 ] 

Hive QA commented on HIVE-23128:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
46s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
43s{color} | {color:red} ql: The patch generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21410/dev-support/hive-personality.sh
 |
| git revision | master / 7f9ce94 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21410/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21410/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> SHOW CREATE TABLE Creates Incorrect Syntax When Database Specified
> --
>
> Key: HIVE-23128
> URL: https://issues.apache.org/jira/browse/HIVE-23128
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.4.0, 3.1.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23128.1.patch
>
>
> {code:sql}
> show create table `sample_07`;
> show create table `default`.`sample_07`;
> show create table `default.sample_07`;
> {code}
> {code:none|title=Results}
> CREATE TABLE `sample_07`(...)
> CREATE TABLE `default.sample_07`(...)
> CREATE TABLE `default.sample_07`(...);
> {code}
> All three {{show create table}} statements complete in Hive 2.x and 3.x and 
> generate {{CREATE TABLE}} statements as show above. The first result is 
> correct because it does not include the database name, however, the 
> subsequent two results are invalid: each field must be quoted individually.  
> This causes a failure in recent versions of Hive because "SemanticException 
> Table or database name may not contain dot(.) character."
> {quote}If any components of a multiple-part name require quoting, quote them 
> individually rather than quoting the name as a whole. For example, write 
> `my-table`.`my-column`, not `my-table.my-column`.
>  * [https://dev.mysql.com/doc/refman/8.0/en/identifier-qualifiers.html]{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)