[jira] [Commented] (HIVE-23208) Update guaranteed capacity in ZK only when WM is enabled

2020-04-16 Thread Ashutosh Chauhan (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084981#comment-17084981
 ] 

Ashutosh Chauhan commented on HIVE-23208:
-

+1

> Update guaranteed capacity in ZK only when WM is enabled
> 
>
> Key: HIVE-23208
> URL: https://issues.apache.org/jira/browse/HIVE-23208
> Project: Hive
>  Issue Type: Improvement
>  Components: llap
>Reporter: Rajesh Balamohan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23208.1.patch
>
>
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java#L1091]
>  
> Though WM is not enabled, it ends up updating ZK for every dag completion 
> event. For short running queries with concurrency, this ends up with lots of 
> calls to ZK.
> It would be good to invoke this only when WM is enabled.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23208) Update guaranteed capacity in ZK only when WM is enabled

2020-04-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084801#comment-17084801
 ] 

Hive QA commented on HIVE-23208:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/1376/HIVE-23208.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17128 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21694/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21694/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21694/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 1376 - PreCommit-HIVE-Build

> Update guaranteed capacity in ZK only when WM is enabled
> 
>
> Key: HIVE-23208
> URL: https://issues.apache.org/jira/browse/HIVE-23208
> Project: Hive
>  Issue Type: Improvement
>  Components: llap
>Reporter: Rajesh Balamohan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23208.1.patch
>
>
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java#L1091]
>  
> Though WM is not enabled, it ends up updating ZK for every dag completion 
> event. For short running queries with concurrency, this ends up with lots of 
> calls to ZK.
> It would be good to invoke this only when WM is enabled.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23208) Update guaranteed capacity in ZK only when WM is enabled

2020-04-16 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084768#comment-17084768
 ] 

Hive QA commented on HIVE-23208:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
24s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21694/dev-support/hive-personality.sh
 |
| git revision | master / c004341 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21694/yetus/patch-asflicense-problems.txt
 |
| modules | C: llap-tez U: llap-tez |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21694/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Update guaranteed capacity in ZK only when WM is enabled
> 
>
> Key: HIVE-23208
> URL: https://issues.apache.org/jira/browse/HIVE-23208
> Project: Hive
>  Issue Type: Improvement
>  Components: llap
>Reporter: Rajesh Balamohan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23208.1.patch
>
>
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java#L1091]
>  
> Though WM is not enabled, it ends up updating ZK for every dag completion 
> event. For short running queries with concurrency, this ends up with lots of 
> calls to ZK.
> It would be good to invoke this only when WM is enabled.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)