[ https://issues.apache.org/jira/browse/HIVE-23225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085400#comment-17085400 ]
Jesus Camacho Rodriguez commented on HIVE-23225: ------------------------------------------------ In addition, some methods should simply not exist since the logic does not belong to the {{ExprFactory}}. > Simplify ExprFactory, ExprNodeDescExprFactory and RexNodeExprFactory > -------------------------------------------------------------------- > > Key: HIVE-23225 > URL: https://issues.apache.org/jira/browse/HIVE-23225 > Project: Hive > Issue Type: Improvement > Reporter: Jesus Camacho Rodriguez > Priority: Major > > The new {{ExprFactory}} was created based on existing calls from > {{TypeCheckProcFactory}}. Now that we have the {{ExprNodeDesc}} and > {{RexNode}} implementations, it seems we could do some work consolidating > those methods, simplifying the super/subclasses, etc. For instance, the > handling of literal values seems quite convoluted (handled by many different > method) and could possibly be abstracted in a different way. -- This message was sent by Atlassian Jira (v8.3.4#803005)