[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104080#comment-17104080
 ] 

Hive QA commented on HIVE-23429:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002575/HIVE-23429.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17246 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22258/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22258/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22258/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002575 - PreCommit-HIVE-Build

> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
>  Labels: performance
> Attachments: HIVE-23429.1.patch, HIVE-23429.2.patch
>
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104053#comment-17104053
 ] 

Hive QA commented on HIVE-23429:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
26s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
46s{color} | {color:blue} ql in master has 1527 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} llap-tez: The patch generated 1 new + 36 unchanged - 0 
fixed = 37 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 40s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-22258/dev-support/hive-personality.sh
 |
| git revision | master / 6491151 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22258/yetus/diff-checkstyle-llap-tez.txt
 |
| modules | C: llap-tez ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22258/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
>  Labels: performance
> Attachments: HIVE-23429.1.patch, HIVE-23429.2.patch
>
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Ashutosh Chauhan (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104031#comment-17104031
 ] 

Ashutosh Chauhan commented on HIVE-23429:
-

+1

> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
>  Labels: performance
> Attachments: HIVE-23429.1.patch, HIVE-23429.2.patch
>
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104005#comment-17104005
 ] 

Hive QA commented on HIVE-23429:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002564/HIVE-23429.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17226 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.parse.TestTableLevelReplicationScenarios.org.apache.hadoop.hive.ql.parse.TestTableLevelReplicationScenarios
 (batchId=187)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22256/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22256/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22256/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002564 - PreCommit-HIVE-Build

> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
>  Labels: performance
> Attachments: HIVE-23429.1.patch
>
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103998#comment-17103998
 ] 

Hive QA commented on HIVE-23429:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
26s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
45s{color} | {color:blue} ql in master has 1527 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} llap-tez: The patch generated 1 new + 36 unchanged - 0 
fixed = 37 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m  4s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-22256/dev-support/hive-personality.sh
 |
| git revision | master / 6491151 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22256/yetus/diff-checkstyle-llap-tez.txt
 |
| modules | C: llap-tez ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22256/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Major
>  Labels: performance
> Attachments: HIVE-23429.1.patch
>
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23429) LLAP: Optimize retrieving queryId details in LlapTaskCommunicator

2020-05-10 Thread Rajesh Balamohan (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103984#comment-17103984
 ] 

Rajesh Balamohan commented on HIVE-23429:
-

Related ticket: https://issues.apache.org/jira/browse/TEZ-2672

> LLAP: Optimize retrieving queryId details in LlapTaskCommunicator
> -
>
> Key: HIVE-23429
> URL: https://issues.apache.org/jira/browse/HIVE-23429
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Priority: Major
>  Labels: performance
>
>  
> [https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java#L825]
>  
> For small jobs, this becomes a bottleneck to unpack entire payload to lookup 
> HIVEQUERYID parameter. It would be good to share HIVEQUERYID in dagConf and 
> retrieve it back via DagInfo.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)