[jira] [Commented] (HIVE-23504) Propagate query cancellations to druid when a hive query is cancelled
[
https://issues.apache.org/jira/browse/HIVE-23504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111690#comment-17111690
]
Hive QA commented on HIVE-23504:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003396/HIVE-23504.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17270 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22468/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22468/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22468/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13003396 - PreCommit-HIVE-Build
> Propagate query cancellations to druid when a hive query is cancelled
> -
>
> Key: HIVE-23504
> URL: https://issues.apache.org/jira/browse/HIVE-23504
> Project: Hive
> Issue Type: Bug
> Components: Druid integration, Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-23504.01.patch
>
>
> See Query cancellation here -
> [https://druid.apache.org/docs/latest/querying/querying.html]
> Queries can be cancelled explicitly using their unique identifier. If the
> query identifier is set at the time of query, or is otherwise known, the
> following endpoint can be used on the Broker or Router to cancel the query.
>
> {{DELETE /druid/v2/{queryId}}}
>
> Copy
> For example, if the query ID is {{abc123}}, the query can be cancelled as
> follows:
>
> {{curl -X DELETE "http://host:port/druid/v2/abc123"}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23504) Propagate query cancellations to druid when a hive query is cancelled
[
https://issues.apache.org/jira/browse/HIVE-23504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111668#comment-17111668
]
Hive QA commented on HIVE-23504:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
23s{color} | {color:blue} ql in master has 1527 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
40s{color} | {color:red} ql generated 1 new + 1527 unchanged - 0 fixed = 1528
total (was 1527) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Found reliance on default encoding in
org.apache.hadoop.hive.ql.exec.tez.TezTask.cancelDruidQuery():in
org.apache.hadoop.hive.ql.exec.tez.TezTask.cancelDruidQuery(): new
java.io.InputStreamReader(InputStream) At TezTask.java:[line 758] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-22468/dev-support/hive-personality.sh
|
| git revision | master / 2f7a607 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-22468/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-22468/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-22468/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Propagate query cancellations to druid when a hive query is cancelled
> -
>
> Key: HIVE-23504
> URL: https://issues.apache.org/jira/browse/HIVE-23504
> Project: Hive
> Issue Type: Bug
> Components: Druid integration, Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-23504.01.patch
>
>
> See Query cancellation here -
> [https://druid.apache.org/docs/latest/querying/querying.html]
> Queries can be cancelled explicitly using their unique identifier. If the
> query identifier is set at the time of query, or is otherwise known, the
> following endpoint can be used on the Broker or Router to cancel the query.
>
> {{DELETE /druid/v2/{queryId}}}
>
> Copy
> For example, if the query ID is {{abc123}}, the query can be cancelled as
> follows:
>
> {{curl -X DELETE "http://host:port/druid/v2/abc123"}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
