[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-13 Thread Ashutosh Chauhan (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134901#comment-17134901
 ] 

Ashutosh Chauhan commented on HIVE-23666:
-

+1

> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23666.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-12 Thread Ramesh Kumar Thangarajan (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134624#comment-17134624
 ] 

Ramesh Kumar Thangarajan commented on HIVE-23666:
-

I have created the PR at [https://github.com/apache/hive/pull/1103]. Can you 
please help me review the patch?

> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23666.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-12 Thread Ashutosh Chauhan (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134548#comment-17134548
 ] 

Ashutosh Chauhan commented on HIVE-23666:
-

[~rameshkumar] do you have RB or GH for the change? Its hard to read this patch 
without a diff tool.

> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23666.1.patch
>
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-12 Thread Jesus Camacho Rodriguez (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134546#comment-17134546
 ] 

Jesus Camacho Rodriguez commented on HIVE-23666:


+1

> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23666.1.patch
>
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-08 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128760#comment-17128760
 ] 

Hive QA commented on HIVE-23666:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13005164/HIVE-23666.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17107 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22789/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22789/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22789/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13005164 - PreCommit-HIVE-Build

> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23666.1.patch
>
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23666) checkHashModeEfficiency is skipped when a groupby operator doesn't have a grouping set

2020-06-08 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128744#comment-17128744
 ] 

Hive QA commented on HIVE-23666:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
40s{color} | {color:blue} ql in master has 1522 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
11s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 42s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-22789/dev-support/hive-personality.sh
 |
| git revision | master / 2a3a42f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22789/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-22789/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set
> --
>
> Key: HIVE-23666
> URL: https://issues.apache.org/jira/browse/HIVE-23666
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-23666.1.patch
>
>
> checkHashModeEfficiency is skipped when a groupby operator doesn't have a 
> grouping set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)