[jira] [Commented] (HIVE-26631) Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class
[ https://issues.apache.org/jira/browse/HIVE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634911#comment-17634911 ] Stamatis Zampetakis commented on HIVE-26631: At this stage it makes sense to drop the respective configuration parameters from Hive so I am going to merge the current PR. > Remove unused variable requestTimeout and beBackoffSlotLength in the > initServer method of the ThriftBinaryCLIService class > -- > > Key: HIVE-26631 > URL: https://issues.apache.org/jira/browse/HIVE-26631 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0-alpha-1 >Reporter: weiliang hao >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Upgrade thrift from 0.13.0 to 0.14.1 in > issuse(https://issues.apache.org/jira/browse/HIVE-25098)， The settings of > requestTimeout and beBackoffSlotLength are removed for TThreadPoolServer.Args > objects. However, variable requestTimeout and beBackoffSlotLength unused, > better to clean up them and HiveConf: > * hive.server2.thrift.exponential.backoff.slot.length > * hive.server2.thrift.login.timeout -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HIVE-26631) Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class
[ https://issues.apache.org/jira/browse/HIVE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634903#comment-17634903 ] Stamatis Zampetakis commented on HIVE-26631: Thanks for the information [~haoweiliang] . Below a few additional notes based on your observations. The variables were introduced by HIVE-4766 (at this point thrift was at version 0.9.2) to prevent beeline from hanging when Thrift is overloaded. However, in THRIFT-5297 (thrift 0.14.0) they decided to drop the configuration parameters and simply drop the connection if server is too busy. With THRIFT-5297 in place there is no risk of hanging but it is also not possible to configure how much to wait before rejecting the connection. >From a Hive perspective HIVE-25098 partially breaks HIVE-4766 so the former is >a somewhat backward incompatible change. > Remove unused variable requestTimeout and beBackoffSlotLength in the > initServer method of the ThriftBinaryCLIService class > -- > > Key: HIVE-26631 > URL: https://issues.apache.org/jira/browse/HIVE-26631 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0-alpha-1 >Reporter: weiliang hao >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Upgrade thrift from 0.13.0 to 0.14.1 in > issuse(https://issues.apache.org/jira/browse/HIVE-25098)， The settings of > requestTimeout and beBackoffSlotLength are removed for TThreadPoolServer.Args > objects. However, variable requestTimeout and beBackoffSlotLength unused, > better to clean up them and HiveConf: > * hive.server2.thrift.exponential.backoff.slot.length > * hive.server2.thrift.login.timeout -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HIVE-26631) Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class
[ https://issues.apache.org/jira/browse/HIVE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633751#comment-17633751 ] weiliang hao commented on HIVE-26631: - [~zabetak] In this issuse（https://issues.apache.org/jira/browse/THRIFT-5297 ），the parameters requestTimeout and beBackoffSlotLength are removed。Because it adds a lot of complexity to the code and doesn't make a whole lot of sense. > Remove unused variable requestTimeout and beBackoffSlotLength in the > initServer method of the ThriftBinaryCLIService class > -- > > Key: HIVE-26631 > URL: https://issues.apache.org/jira/browse/HIVE-26631 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0-alpha-1 >Reporter: weiliang hao >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Upgrade thrift from 0.13.0 to 0.14.1 in > issuse(https://issues.apache.org/jira/browse/HIVE-25098)， The settings of > requestTimeout and beBackoffSlotLength are removed for TThreadPoolServer.Args > objects. However, variable requestTimeout and beBackoffSlotLength unused, > better to clean up them and HiveConf: > * hive.server2.thrift.exponential.backoff.slot.length > * hive.server2.thrift.login.timeout -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HIVE-26631) Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class
[ https://issues.apache.org/jira/browse/HIVE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625012#comment-17625012 ] Stamatis Zampetakis commented on HIVE-26631: Are there any other equivalent/similar settings in the newer (0.14.1) Thrift version? Do we know why Thrift removed these configuration options? > Remove unused variable requestTimeout and beBackoffSlotLength in the > initServer method of the ThriftBinaryCLIService class > -- > > Key: HIVE-26631 > URL: https://issues.apache.org/jira/browse/HIVE-26631 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0-alpha-1 >Reporter: weiliang hao >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Upgrade thrift from 0.13.0 to 0.14.1 in > issuse(https://issues.apache.org/jira/browse/HIVE-25098)， The settings of > requestTimeout and beBackoffSlotLength are removed for TThreadPoolServer.Args > objects. However, variable requestTimeout and beBackoffSlotLength unused, > better to clean up them and HiveConf: > * hive.server2.thrift.exponential.backoff.slot.length > * hive.server2.thrift.login.timeout -- This message was sent by Atlassian Jira (v8.20.10#820010)
